464805 2023-01-25 15:48:14 +0000 Modifier only shortcuts assigned through system settings-shortcuts trigger on "press" action instead of "release" 2024-08-03 01:24:02 +0000 1 1 3 Frameworks and Libraries frameworks-kglobalaccel general 5.249.0 Other Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=452113 https://bugs.kde.org/show_bug.cgi?id=470113 https://bugs.kde.org/show_bug.cgi?id=470257 https://bugs.kde.org/show_bug.cgi?id=470256 https://bugs.kde.org/show_bug.cgi?id=420493 https://bugs.kde.org/show_bug.cgi?id=481373 NOR normal --- 1 chermnykh2001 fanzhuyifan bugseforuns butirsky chermnykh2001 fanzhuyifan ilia.karpov.96 kde kde madLyfe nate oded tietininon xalt7x.service https://invent.kde.org/plasma/kglobalacceld/-/commit/d20d58d4729fd94b3373b803de89054c2e2550de 6.1 0 oldest_to_newest 2201818 0 chermnykh2001 2023-01-25 15:48:14 +0000 SUMMARY Modifier only shortcuts on X11 trigger on "press" action instead of "release". This results in triggering multiple shortcuts when pressing a shortcut with modifier. STEPS TO REPRODUCE 1. Bind a shortcut to a modifier (for example "super/meta" key for krunner) 2. Bind meta+space to another shortcut (in my case it triggers keyboard layout switch via fcitx5) 3. Press meta+space OBSERVED RESULT Both shortcuts got triggered (keyboard layout switch + krunner) EXPECTED RESULT Only meta+space shortcut triggers (keyboard layout switch) SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.26.90 KDE Frameworks Version: 5.102.0 Qt Version: 5.15.8 Xorg 21.1.6-1 2201899 1 nate 2023-01-25 18:07:11 +0000 Works for me on Wayland FWIW. 2201950 2 bugseforuns 2023-01-25 21:00:33 +0000 possibly duplicate of bug 452113 2201960 3 nate 2023-01-25 21:23:16 +0000 Hmm, maybe the have the same root cause? Needs investigation. 2227926 4 kde 2023-05-04 08:40:59 +0000 There are two paths for modifier only shortcuts: - kwin did a path of modifier shortcuts, which was release only - in kglobalaccel a modifier only shortcut will fire on press, like another shortcut. It's slightly more complex as that kglobalaccel usage was designed to cover press-to-talk like cases. Those can't be delayed. It will need to be a flag on shortcut bind or done exclusively client side 2233087 5 oded 2023-05-25 13:40:40 +0000 I can reproduce this issue in Plasma 6 on Wayland: When setting a modifier only shortcut, it triggers on key press. If the same modifier is used in another shortcut (for example CTRL vs CTRL+S) than both events are being triggered, though if the modifier-only shortcut is quick enough to grab focus away from the application that is supposed to handle the second shortcut, then it might not happen at all. For example: STEPS TO REPRODUCE: 1. In the keyboard shortcut settings, find Krunner and add to it a shortcut of "Control". 2. Start another application that can "save" on CTRL+S - for example, Firefox. 3. Press CTRL+S OBSERVED RESULT Krunner appears. EXPECTED RESULT The "Save" dialog should come up. 2233088 6 butirsky 2023-05-25 13:47:10 +0000 (In reply to Nate Graham from comment #1) > Works for me on Wayland FWIW. What was your test Nate? Can you confirm the fail above? 2233499 7 oded 2023-05-28 10:50:48 +0000 (In reply to Oded Arbel from comment #5) > I can reproduce this issue in Plasma 6 on Wayland: > ... > STEPS TO REPRODUCE: > 1. In the keyboard shortcut settings, find Krunner and add to it a shortcut > of "Control". > 2. Start another application that can "save" on CTRL+S - for example, > Firefox. > 3. Press CTRL+S Setting up modifier-only shortcuts using kwinrc ([ModifierOnlyShortcuts] section), instead of using the System Settings shortcuts KCM, the modifier-only shortcut does trigger correctly on release. I'm not sure what the KCM is doing that is different than setting the kwinrc setting, but there are obviously two different systems that pertain to do the same thing, where one of them is doing it wrong. 2281129 8 vlad.zahorodnii 2024-01-17 15:54:34 +0000 *** Bug 479807 has been marked as a duplicate of this bug. *** 2289115 9 chermnykh2001 2024-02-15 20:19:07 +0000 *** Bug 481373 has been marked as a duplicate of this bug. *** 2289125 10 fanzhuyifan 2024-02-15 20:54:18 +0000 Moved to kglobalaccel since the modifier-only shortcuts handled by kwin activate on release, and this is about regular shortcuts handled by a different code path. 2289128 11 fanzhuyifan 2024-02-15 20:57:34 +0000 Also just a heads-up that I plan to take a look at this some time. 2290420 12 fanzhuyifan 2024-02-20 16:31:52 +0000 https://invent.kde.org/plasma/kglobalacceld/-/merge_requests/44 2303449 13 fanzhuyifan 2024-03-20 17:02:06 +0000 Git commit d20d58d4729fd94b3373b803de89054c2e2550de by Yifan Zhu. Committed on 20/03/2024 at 17:00. Pushed by fanzhuyifan into branch 'master'. Enhance modifier-only shortcuts Trigger modifier-only shortcuts trigger on release, and support multi-key modifier-only shortcuts, which trigger only when all the modifiers are released within some interval. Related: bug 470256 M +50 -19 src/globalshortcutsregistry.cpp M +15 -0 src/globalshortcutsregistry.h M +38 -1 src/sequencehelpers_p.cpp M +2 -0 src/sequencehelpers_p.h https://invent.kde.org/plasma/kglobalacceld/-/commit/d20d58d4729fd94b3373b803de89054c2e2550de 2342302 14 fanzhuyifan 2024-08-01 20:20:20 +0000 *** Bug 474024 has been marked as a duplicate of this bug. *** 2342685 15 fanzhuyifan 2024-08-03 01:24:02 +0000 *** Bug 467341 has been marked as a duplicate of this bug. ***