<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>464519</bug_id>
          
          <creation_ts>2023-01-19 19:29:42 +0000</creation_ts>
          <short_desc>Close button on &quot;Finished&quot; message does not close the message</short_desc>
          <delta_ts>2023-01-28 21:11:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>systemsettings</product>
          <component>kcm_fontinst</component>
          <version>master</version>
          <rep_platform>Neon</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>HI</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Paul Worrall">p.r.worrall</reporter>
          <assigned_to name="Plasma Bugs List">plasma-bugs-null</assigned_to>
          <cc>nate</cc>
          
          <cf_commitlink>https://invent.kde.org/plasma/plasma-workspace/commit/d4dac2915c73e8f1f41571c9d1bec26871082a3e</cf_commitlink>
          <cf_versionfixedin>5.27</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2199845</commentid>
    <comment_count>0</comment_count>
    <who name="Paul Worrall">p.r.worrall</who>
    <bug_when>2023-01-19 19:29:42 +0000</bug_when>
    <thetext>STEPS TO REPRODUCE
1. Launch the KCM and select &quot;Install from File...&quot;
2. Navigate to and select a .ttf file
3. Choose &quot;Personal&quot;
4. Click the &quot;Close&quot; button on &quot;Finished&quot; message box

OBSERVED RESULT
Nothing happens

EXPECTED RESULT
Message box closes

SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.102.0
Qt Version: 5.15.8
Graphics Platform: X11</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2201040</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-01-23 21:42:36 +0000</bug_when>
    <thetext>Hmm, I just tried this (Wayland, Fedora 37, git master stuff) and the font was installed successfully without any king of &quot;finished&quot; message box.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2201163</commentid>
    <comment_count>2</comment_count>
    <who name="Paul Worrall">p.r.worrall</who>
    <bug_when>2023-01-24 08:20:43 +0000</bug_when>
    <thetext>The &quot;Finished&quot; message may have been disabled - it has a &quot;Don&apos;t tell me in future&quot; tick box</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2201275</commentid>
    <comment_count>3</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-01-24 16:22:25 +0000</bug_when>
    <thetext>Right you are. Can confirm now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2202601</commentid>
    <comment_count>4</comment_count>
    <who name="ratijas">me</who>
    <bug_when>2023-01-27 22:11:44 +0000</bug_when>
    <thetext>Git commit 90e59648610397ac611c906bbdefc7f4a6906017 by ivan tkachenko, on behalf of Nate Graham.
Committed on 27/01/2023 at 22:00.
Pushed by ngraham into branch &apos;master&apos;.

kcms/kfontinst: close &quot;Finished&quot; dialog box when clicking OK

The code handling when the &quot;OK&quot; button got clicked was not actually
closing the dialog box, so clicking on it did nothing.
FIXED-IN: 5.27

M  +1    -0    kcms/kfontinst/kcmfontinst/JobRunner.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/90e59648610397ac611c906bbdefc7f4a6906017</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2202602</commentid>
    <comment_count>5</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-01-27 22:12:14 +0000</bug_when>
    <thetext>Git commit 0aa62e1c693024bca3cd234682a4523a0372cf41 by Nate Graham.
Committed on 27/01/2023 at 22:12.
Pushed by ngraham into branch &apos;cherry-pick-90e59648&apos;.

kcms/kfontinst: close &quot;Finished&quot; dialog box when clicking OK

The code handling when the &quot;OK&quot; button got clicked was not actually
closing the dialog box, so clicking on it did nothing.
FIXED-IN: 5.27


(cherry picked from commit 90e59648610397ac611c906bbdefc7f4a6906017)

M  +1    -0    kcms/kfontinst/kcmfontinst/JobRunner.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/0aa62e1c693024bca3cd234682a4523a0372cf41</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2202917</commentid>
    <comment_count>6</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-01-28 21:11:50 +0000</bug_when>
    <thetext>Git commit d4dac2915c73e8f1f41571c9d1bec26871082a3e by Nate Graham.
Committed on 28/01/2023 at 21:11.
Pushed by ngraham into branch &apos;Plasma/5.27&apos;.

kcms/kfontinst: close &quot;Finished&quot; dialog box when clicking OK

The code handling when the &quot;OK&quot; button got clicked was not actually
closing the dialog box, so clicking on it did nothing.
FIXED-IN: 5.27
(cherry picked from commit 90e59648610397ac611c906bbdefc7f4a6906017)

M  +1    -0    kcms/kfontinst/kcmfontinst/JobRunner.cpp

https://invent.kde.org/plasma/plasma-workspace/commit/d4dac2915c73e8f1f41571c9d1bec26871082a3e</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>