459325 2022-09-18 12:42:19 +0000 Keyboard shortcut change should be effective only after clicking the 'Apply' button 2023-01-12 13:28:30 +0000 1 1 2 Applications systemsettings kcm_kwintabbox master Neon Linux RESOLVED FIXED NOR normal --- 1 bugseforuns kwin-bugs-null nate plasma-bugs-null sbancuz https://invent.kde.org/plasma/kwin/commit/76ac4be31632b436ea78611f07490c352a88b192 5.27 0 oldest_to_newest 2153923 0 bugseforuns 2022-09-18 12:42:19 +0000 SUMMARY Keyboard shortcut change should be effective only after clicking the 'Apply' button for consistency reasons, because this is the behavior in Screen Locking and Notifications KCMs. STEPS TO REPRODUCE 1. open Task Switcher KCM 2. click on any button used to set/change a keyboard shortcut 3. press the desired shortcut OBSERVED RESULT pressed shortcut is effective without click on 'Apply' button EXPECTED RESULT 'Apply' button is activated after pressing the shortcut and the change is effective only after clicking on it SOFTWARE/OS VERSIONS Operating System: KDE neon Unstable Edition KDE Plasma Version: 5.26.80 KDE Frameworks Version: 5.98.0 Qt Version: 5.15.6 Graphics Platform: Wayland 2195065 1 nate 2023-01-09 20:28:40 +0000 *** Bug 463846 has been marked as a duplicate of this bug. *** 2195580 2 bug-janitor 2023-01-11 00:18:57 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3417 2196518 3 vlad.zahorodnii 2023-01-12 13:28:30 +0000 Git commit 76ac4be31632b436ea78611f07490c352a88b192 by Vlad Zahorodnii, on behalf of Ismael Asensio. Committed on 12/01/2023 at 12:15. Pushed by vladz into branch 'master'. kcms/tabbox: Make shortcuts config save on apply Currently, tabbox shortcuts are directly saved to KGlobalAccel when they change, which is inconsistent with the rest of the KCM and leads to confusion regarding Defaults and isSaveNeeded status. Let's instead manage the changes internally and just save them to KGlobalAccel on Apply/Save. m_actionsCollection is only used as a helpful way to store this internal configuration, and doesn't really needs saving to or restoring from config. FIXED-IN: 5.27 M +62 -42 src/kcms/tabbox/kwintabboxconfigform.cpp M +5 -2 src/kcms/tabbox/kwintabboxconfigform.h M +6 -0 src/kcms/tabbox/main.cpp https://invent.kde.org/plasma/kwin/commit/76ac4be31632b436ea78611f07490c352a88b192