<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>459318</bug_id>
          
          <creation_ts>2022-09-18 11:05:28 +0000</creation_ts>
          <short_desc>non-default keyboard shortcut should be detected as changed setting</short_desc>
          <delta_ts>2023-01-12 21:43:56 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>systemsettings</product>
          <component>kcm_kwintabbox</component>
          <version>master</version>
          <rep_platform>Neon</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Patrick Silva">bugseforuns</reporter>
          <assigned_to name="KWin default assignee">kwin-bugs-null</assigned_to>
          <cc>isma.af</cc>
    
    <cc>nate</cc>
    
    <cc>plasma-bugs-null</cc>
    
    <cc>postix</cc>
          
          <cf_commitlink>https://invent.kde.org/plasma/kwin/-/commit/76ac4be31632b436ea78611f07490c352a88b192</cf_commitlink>
          <cf_versionfixedin>5.27</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2153899</commentid>
    <comment_count>0</comment_count>
    <who name="Patrick Silva">bugseforuns</who>
    <bug_when>2022-09-18 11:05:28 +0000</bug_when>
    <thetext>SUMMARY
Cannot reproduce with Screen Locking KCM

STEPS TO REPRODUCE
1. open Task Switcher KCM with its default settings
2. set a non-default keyboard shortcut
3. click on &apos;Highlight changed settings&apos; button

OBSERVED RESULT
the KCM is not highlighted with an orange dot

EXPECTED RESULT
the KCM is highlighted with an orange dot


SOFTWARE/OS VERSIONS
Operating System: KDE neon Unstable Edition
KDE Plasma Version: 5.26.80
KDE Frameworks Version: 5.98.0
Qt Version: 5.15.6
Graphics Platform: Wayland</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2195067</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2023-01-09 20:29:39 +0000</bug_when>
    <thetext>*** Bug 448894 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2195581</commentid>
    <comment_count>2</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2023-01-11 00:18:59 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3417</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2196019</commentid>
    <comment_count>3</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2023-01-11 20:31:49 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/3426</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2196708</commentid>
    <comment_count>4</comment_count>
    <who name="Ismael Asensio">isma.af</who>
    <bug_when>2023-01-12 20:20:51 +0000</bug_when>
    <thetext>Git commit b11416c3968d0a31926afb2a192e1d7e2cbdb004 by Ismael Asensio.
Committed on 12/01/2023 at 18:58.
Pushed by iasensio into branch &apos;master&apos;.

kcms/tabbox: Highlight non-default shortcuts

This sets the property on the shortcut widgets when they
should get highlighted: the option is selected in System
Settings and the shortcut is not the default.

It requires a change in `KXMLGui/KKeyShortcutWidget` to
actually paint the highlihgt ring.
(commit 47572c26, KF103)

M  +11   -0    src/kcms/tabbox/kwintabboxconfigform.cpp
M  +1    -0    src/kcms/tabbox/kwintabboxconfigform.h
M  +1    -0    src/kcms/tabbox/main.cpp

https://invent.kde.org/plasma/kwin/commit/b11416c3968d0a31926afb2a192e1d7e2cbdb004</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2196740</commentid>
    <comment_count>5</comment_count>
    <who name="Ismael Asensio">isma.af</who>
    <bug_when>2023-01-12 21:43:56 +0000</bug_when>
    <thetext>Fixed with the combination of:

https://invent.kde.org/plasma/kwin/-/commit/76ac4be31632b436ea78611f07490c352a88b192 (Plasma 5.27)
https://invent.kde.org/frameworks/kxmlgui/-/commit/47572c26eb7fbc8977c4ad6f1414bb0ad4ff9385 (Frameworks 5.103)</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>