<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>456564</bug_id>
          
          <creation_ts>2022-07-10 21:46:05 +0000</creation_ts>
          <short_desc>Accepting an imported transaction is a low-severity action, should rather not require modal confirmation dialog</short_desc>
          <delta_ts>2024-12-19 10:04:47 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>kmymoney</product>
          <component>ux-ui</component>
          <version>git (master)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Dawid Wróbel">me</reporter>
          <assigned_to name="KMyMoney Devel Mailing List">kmymoney-devel</assigned_to>
          
          
          <cf_commitlink>https://invent.kde.org/office/kmymoney/commit/50edbb240b009f9bb1ac8e66d78371a579a3302b</cf_commitlink>
          <cf_versionfixedin>5.2</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2138184</commentid>
    <comment_count>0</comment_count>
    <who name="Dawid Wróbel">me</who>
    <bug_when>2022-07-10 21:46:05 +0000</bug_when>
    <thetext>SUMMARY
Accepting an imported transaction is a low-severity action, should rather not require modal confirmation dialog. The action can be reverted and by itself does not edit the content of the transaction, outside of changing its flag.

STEPS TO REPRODUCE
1. Accept an imported transaction

OBSERVED RESULT
A modal dialog is shown asking to confirm the action

EXPECTED RESULT
Action should be accepted immediately. If needed, it can be reverted either by &quot;Undoing&quot; the action, or by switching its &quot;Imported&quot; flag back on with Transaction -&gt; Mark Transaction As... -&gt; Imported (which currently is *not* one of the items listed there)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2138189</commentid>
    <comment_count>1</comment_count>
    <who name="Jack">ostroffjh</who>
    <bug_when>2022-07-10 22:17:27 +0000</bug_when>
    <thetext>I also point out that for consistency, an imported transaction is accepted by editing it or by clicking on the status column to change from not marked to confirmed, neither of which requires confirmation.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2138244</commentid>
    <comment_count>2</comment_count>
    <who name="Thomas Baumgart">thb</who>
    <bug_when>2022-07-11 09:03:10 +0000</bug_when>
    <thetext>Git commit 50edbb240b009f9bb1ac8e66d78371a579a3302b by Thomas Baumgart.
Committed on 11/07/2022 at 06:17.
Pushed by tbaumgart into branch &apos;master&apos;.

Remove confirmation dialog when accepting imported transactions

M  +1    -11   kmymoney/views/ledgerview.cpp

https://invent.kde.org/office/kmymoney/commit/50edbb240b009f9bb1ac8e66d78371a579a3302b</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>