455207 2022-06-13 10:01:10 +0000 Recorder "Clean up Recordings" button title doesn't make any sense 2024-11-08 11:43:31 +0000 1 1 2 Applications krita Dockers/Recorder 5.0.6 Other All RESOLVED FIXED NOR minor --- 1 loentar griffinvalley halla https://invent.kde.org/graphics/krita/-/commit/337b9a77af66e536d11aadf2bbe3f734ec1a13d1 0 oldest_to_newest 2130775 0 loentar 2022-06-13 10:01:10 +0000 This change replaced custom buttons to dialog standard, but also the button caption got occasionally changed. https://invent.kde.org/graphics/krita/-/commit/ab725611515257eb56b52a8dc1b200d38cda6588 Before change: "Clean Up" After change: "Close without Saving" Expected to be "Clean Up", because button's action is to remove selected directories to free space. 2130962 1 halla 2022-06-14 06:51:12 +0000 Wolthera, can you take a look? 2372721 2 dimula73 2024-11-08 11:41:56 +0000 Git commit e1deda8a9d1017cafdff4aa832ff5d6357a99024 by Dmitry Kazakov. Committed on 08/11/2024 at 11:41. Pushed by dkazakov into branch 'master'. [string freeze exception] Recover "Clean Up" button in the Recordings Manager When the manager was refactored into supporting QDialogButtonBox, then clean-up button was replaced with a "Discard" button. Even though it sounds sensible in English, it has a different meaning in QDialogButtonBox and, therefore, in translations. In translations, the button is usually translated as "Close without saving", which is not what the button actually does in Krita. M +5 -3 plugins/dockers/recorder/recorder_snapshots_manager.cpp M +1 -0 plugins/dockers/recorder/recorder_snapshots_manager.h M +1 -1 plugins/dockers/recorder/recorder_snapshots_manager.ui https://invent.kde.org/graphics/krita/-/commit/e1deda8a9d1017cafdff4aa832ff5d6357a99024 2372722 3 dimula73 2024-11-08 11:43:31 +0000 Git commit 337b9a77af66e536d11aadf2bbe3f734ec1a13d1 by Dmitry Kazakov. Committed on 08/11/2024 at 11:43. Pushed by dkazakov into branch 'krita/5.2'. [string freeze exception] Recover "Clean Up" button in the Krita's Recordings Manager When the manager was refactored into supporting QDialogButtonBox, then clean-up button was replaced with a "Discard" button. Even though it sounds sensible in English, it has a different meaning in QDialogButtonBox and, therefore, in translations. In translations, the button is usually translated as "Close without saving", which is not what the button actually does in Krita. CC:kde-i18n-doc@kde.org CC:kimageshop@kde.org M +5 -3 plugins/dockers/recorder/recorder_snapshots_manager.cpp M +1 -0 plugins/dockers/recorder/recorder_snapshots_manager.h M +1 -1 plugins/dockers/recorder/recorder_snapshots_manager.ui https://invent.kde.org/graphics/krita/-/commit/337b9a77af66e536d11aadf2bbe3f734ec1a13d1