<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>453853</bug_id>
          
          <creation_ts>2022-05-15 20:27:57 +0000</creation_ts>
          <short_desc>file size display: please follow BinaryUnitDialect everywhere</short_desc>
          <delta_ts>2023-07-21 21:21:36 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>dolphin</product>
          <component>view-engine: general</component>
          <version>21.12.3</version>
          <rep_platform>Gentoo Packages</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=364321</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>57240</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Erik Quaeghebeur">bugs.kde.org</reporter>
          <assigned_to name="Dolphin Bug Assignee">dolphin-bugs-null</assigned_to>
          <cc>dolphin-bugs-null</cc>
    
    <cc>jackhill3103</cc>
    
    <cc>karl</cc>
    
    <cc>nate</cc>
    
    <cc>vmelkon</cc>
          
          <cf_commitlink>https://invent.kde.org/frameworks/kcoreaddons/-/commit/58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10</cf_commitlink>
          <cf_versionfixedin>Frameworks 6.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2123634</commentid>
    <comment_count>0</comment_count>
    <who name="Erik Quaeghebeur">bugs.kde.org</who>
    <bug_when>2022-05-15 20:27:57 +0000</bug_when>
    <thetext>SUMMARY
Dolphin does not seem to follow the BinaryUnitDialect config option everywhere. Likely it is just a matter of replacing some function with some higher-level ones, as in a few places, Dolphin does do the right thing.

STEPS TO REPRODUCE
1. Set BinaryUnitDialect=2 in [Locale] section of $KDEHOME/.config/kdeglobals (setting to metric/SI instead of IEC)
2. Start Dolphin
3. Open some folder with files, select, hover, etc.

OBSERVED RESULT
Mostly IEC formatting is used instead of metric (metric is used in the status bar when selecting/hovering over a file and also for showing the available disc space)

EXPECTED RESULT
Metric formatting is used everywhere

SOFTWARE/OS VERSIONS
KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3

ADDITIONAL INFORMATION
The BinaryUnitDialect config option is described in Bug 57240. This option is for now still without a GUI, but Bug 364321 makes it clear this is about to change. So apps like Dolphin should be made ready to follow BinaryUnitDialect.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2124021</commentid>
    <comment_count>1</comment_count>
    <who name="">vmelkon</who>
    <bug_when>2022-05-17 03:33:59 +0000</bug_when>
    <thetext>I have tested this on Kubuntu 22.04
I can confirm that I have the same result.

KDE Plasma Version: 5.24.4
KDE Frameworks Version: 5.92.0
Qt Version: 5.15.3

I have tried BinaryUnitDialect=2 and BinaryUnitDialect=1.
If I have no file selected, on the Status bar it shows
68 folder, 6 files (6.4 MiB). It is showing MiB instead of MB.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2211873</commentid>
    <comment_count>2</comment_count>
    <who name="Karl Ove Hufthammer">karl</who>
    <bug_when>2023-02-26 11:23:12 +0000</bug_when>
    <thetext>This also applies to displaying file sizes in the settings dialog, e.g., for the ‘Skip previews for local files above:’ setting (‘General’ category). Here (file settings/general/previewssettingspage.cpp) the value is hardcoded using the (translatable) string ‘MiB’.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2213358</commentid>
    <comment_count>3</comment_count>
    <who name="">vmelkon</who>
    <bug_when>2023-03-02 17:03:11 +0000</bug_when>
    <thetext>I verified it on Kubuntu 22.04.
In the configure - Dolphin dialog box,
On the left side, select General.
On the right side, select the Preview tab.
At the bottom, Skip previews for local files above, the units are always in MiB

This also effects System Monitor. It always shows RAM usage and network activity as KiB and MiB and GiB. There doesn’t seem to be a way to configure it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2240483</commentid>
    <comment_count>4</comment_count>
    <who name="Jack Hill">jackhill3103</who>
    <bug_when>2023-07-09 22:23:02 +0000</bug_when>
    <thetext>*** Bug 472112 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2240540</commentid>
    <comment_count>5</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2023-07-10 10:52:20 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/system/dolphin/-/merge_requests/572</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2240683</commentid>
    <comment_count>6</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2023-07-11 15:43:32 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kcoreaddons/-/merge_requests/352</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2241218</commentid>
    <comment_count>7</comment_count>
    <who name="Jack Hill">jackhill3103</who>
    <bug_when>2023-07-15 20:20:43 +0000</bug_when>
    <thetext>Git commit 58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10 by Jack Hill.
Committed on 12/07/2023 at 17:01.
Pushed by cullmann into branch &apos;master&apos;.

Use BinaryUnitDialect from config when using DefaultBinaryDialect in formatByteSize

Still fall back to IECBinaryDialect if the value isn&apos;t set, or isn&apos;t set
properly.
Related: bug 472111

M  +8    -2    src/lib/util/kformatprivate.cpp

https://invent.kde.org/frameworks/kcoreaddons/-/commit/58cb8fcc5f8290cf2ecac5c3f5ebd9ac69aa8f10</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>