<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>453426</bug_id>
          
          <creation_ts>2022-05-05 15:22:47 +0000</creation_ts>
          <short_desc>New QML version of Present Windows can&apos;t (optionally) exclude minimized windows</short_desc>
          <delta_ts>2022-05-06 15:48:47 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>kwin</product>
          <component>effects-present-windows</component>
          <version>git master</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=441627</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>329540</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Nate Graham">nate</reporter>
          <assigned_to name="KWin default assignee">kwin-bugs-null</assigned_to>
          
          
          <cf_commitlink>https://invent.kde.org/plasma/kwin/commit/eca9b5047ab4833cb33de81b1e75a128f5d758e1</cf_commitlink>
          <cf_versionfixedin>5.25</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2121447</commentid>
    <comment_count>0</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2022-05-05 15:22:47 +0000</bug_when>
    <thetext>This was a feature of the old one, and I used it and miss it.

I want it in the Overview effect too (see Bug 441627), so maybe the tech stack can implement it in a way that both get it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2121701</commentid>
    <comment_count>1</comment_count>
    <who name="Marco Martin">notmart</who>
    <bug_when>2022-05-06 11:37:50 +0000</bug_when>
    <thetext>Git commit ae1937badc097a864ecfc62e79e7a3899c3be572 by Marco Martin.
Committed on 06/05/2022 at 11:37.
Pushed by mart into branch &apos;master&apos;.

Remove completely present windows

since it has been replaced by windowview, and Desktop Grid
is ported as well, remove present windows which is effectively dead code
now
Related: bug 447001, bug 362844, bug 450487, bug 374481, bug 185381, bug 413342, bug 451150, bug 283333, bug 315314, bug 397500, bug 321236, bug 436572, bug 335782

M  +0    -1    src/effects/CMakeLists.txt
D  +0    -45   src/effects/presentwindows/CMakeLists.txt
D  +0    -17   src/effects/presentwindows/main.cpp
D  +0    -18   src/effects/presentwindows/main.qml
D  +0    -75   src/effects/presentwindows/metadata.json
D  +0    -2054 src/effects/presentwindows/presentwindows.cpp
D  +0    -343  src/effects/presentwindows/presentwindows.h
D  +0    -51   src/effects/presentwindows/presentwindows.kcfg
D  +0    -104  src/effects/presentwindows/presentwindows_config.cpp
D  +0    -46   src/effects/presentwindows/presentwindows_config.h
D  +0    -487  src/effects/presentwindows/presentwindows_config.ui
D  +0    -36   src/effects/presentwindows/presentwindows_proxy.cpp
D  +0    -35   src/effects/presentwindows/presentwindows_proxy.h
D  +0    -6    src/effects/presentwindows/presentwindowsconfig.kcfgc

https://invent.kde.org/plasma/kwin/commit/ae1937badc097a864ecfc62e79e7a3899c3be572</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2121737</commentid>
    <comment_count>2</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2022-05-06 13:23:23 +0000</bug_when>
    <thetext>Removing the old code doesn&apos;t make bugs affecting the new code go away; re-opening.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2121781</commentid>
    <comment_count>3</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2022-05-06 15:48:47 +0000</bug_when>
    <thetext>Git commit eca9b5047ab4833cb33de81b1e75a128f5d758e1 by Nate Graham, on behalf of Marco Martin.
Committed on 06/05/2022 at 15:48.
Pushed by ngraham into branch &apos;master&apos;.

effects/windowview+overview: get back option to hide minimized windows

Option to hide minimized windows as old present windows effect had.
Related: bug 441627
FIXED-IN: 5.25

M  +16   -5    src/effects/overview/kcm/overvieweffectkcm.ui
M  +3    -0    src/effects/overview/overviewconfig.kcfg
M  +5    -0    src/effects/overview/overvieweffect.cpp
M  +4    -0    src/effects/overview/overvieweffect.h
M  +1    -0    src/effects/overview/qml/ScreenView.qml
M  +5    -4    src/effects/windowview/kcm/windowvieweffectkcm.ui
M  +1    -0    src/effects/windowview/qml/main.qml
M  +3    -0    src/effects/windowview/windowviewconfig.kcfg
M  +5    -0    src/effects/windowview/windowvieweffect.cpp
M  +4    -0    src/effects/windowview/windowvieweffect.h
M  +20   -0    src/scripting/v3/clientmodel.cpp
M  +6    -0    src/scripting/v3/clientmodel.h

https://invent.kde.org/plasma/kwin/commit/eca9b5047ab4833cb33de81b1e75a128f5d758e1</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>