453289 2022-05-02 09:26:57 +0000 Dolphin doesn't mark the parent folder when Up button is being used 2022-06-08 19:26:29 +0000 1 1 3 Frameworks and Libraries frameworks-kio URL navigator 5.93.0 Other Linux RESOLVED FIXED regression NOR minor --- 1 mo78 kio-bugs-null 3809940and bugseforuns dolphin-bugs-null felixernst kdelibs-bugs-null me nate php4fan popov895 postix programmer.pesesoft+kde putr4.s rauchwolke sausagefactory0 uhhadd https://invent.kde.org/frameworks/kio/commit/75c62a2d436b359bde211b7255895ed04595ce20 5.95 0 oldest_to_newest 2120574 0 mo78 2022-05-02 09:26:57 +0000 SUMMARY *** Dolphin doesn't mark the parent folder when Up button is being used. It used to work fine but after some upgrade it stoped. It's very inconvenient with directories with bunch of folders. *** STEPS TO REPRODUCE 1. Enter a folder. 2. Exit the folder using the Up button (it's working with Back button). OBSERVED RESULT The parent folder isn't marked/selected. EXPECTED RESULT The parent folder should be marked/selected. SOFTWARE/OS VERSIONS Linux/KDE Plasma: KDE Plasma Version: 5.24.4 KDE Frameworks Version: 5.93.0 Qt Version: 5.15.3 2120969 1 nate 2022-05-03 17:56:26 +0000 *** Bug 453176 has been marked as a duplicate of this bug. *** 2120981 2 mo78 2022-05-03 18:11:48 +0000 @Nate, I don't think this problem is the same. For me Dolphin doesn't select anything when Up is being used. 2121197 3 nate 2022-05-04 16:04:00 +0000 *** Bug 453347 has been marked as a duplicate of this bug. *** 2121199 4 php4fan 2022-05-04 16:18:41 +0000 > I don't think this problem is the same. For me Dolphin doesn't select anything when Up is being used. It's kind of "implicitly selected". It's not fully highlighted with a blue background, but it is underlined with a blue line, and it behaves as selected at least in that, if you hit Enter, it's the one you go into. The problem, anyway, is that the child folder you're coming from is not selected, and it should (and used to be), so it does seem to be the exact same issue described in the other bugs. BTW when you say "parent" I think you mean "child". If P is the parent of C and C is the child of P, you navigate from C to P and the one that fails to be selected is C. 2121242 5 mo78 2022-05-04 18:09:21 +0000 Yes, I now checked it and it's indeed underlined, you're right :) I don't know if it will be parent or child (I'm a non-native speaker), but I think everybody realized what the problem is :) 2121392 6 felixernst 2022-05-05 12:41:05 +0000 I can not reproduce this bug on current master. It seems to select the child folder one has emerged from correctly after using the "Up" action. >It's kind of "implicitly selected". It's not fully highlighted with a blue background, >but it is underlined with a blue line, and it behaves as selected at least in that, >if you hit Enter, it's the one you go into. This is actually the behaviour I would prefer in general. We have a bug report that wishes for this behaviour to be implemented everywhere. See https://bugs.kde.org/show_bug.cgi?id=424723. It is true that the behaviour reported here is currently inconsistent and I don't know what caused this but I would rather see https://bugs.kde.org/show_bug.cgi?id=424723 fixed than this one. But since we already seem to be back to the old behaviour on master, I guess this will have to wait. 2121402 7 php4fan 2022-05-05 13:32:00 +0000 > This is actually the behaviour I would prefer in general. To clarify, the folder that gets underlined now (after this regression has appeared) is the first one in the folder, NOT the one you came from. If you suggest that *the folder you came from* gets just underlined (like the first folder is now) instead of fully selected (like the folder you came from used to be), I'm not sure of all the implications of that, but I think it's fine, as long as, at least: - pressing enter will enter that folder - using the right arrows will select the folder next to that one. which I think is what would happen, since it's what now happens to the first folder, which gets underlined. 2122034 8 sausagefactory0 2022-05-08 06:11:50 +0000 Can confirm, it's always the first folder that gets underlined, not the folder I navigated from using UP. Also I'm sure it was working correctly a few months ago, so it must be a recent regression. 2122052 9 felixernst 2022-05-08 10:56:01 +0000 >To clarify, the folder that gets underlined now (after this regression has appeared) >is the first one in the folder, NOT the one you came from. Oh okay. I had missed this. >If you suggest that *the folder you came from* gets just underlined (like the first folder is now) >instead of fully selected (like the folder you came from used to be), I'm not sure of all the >implications of that, but I think it's fine, as long as, at least: […] Yes, that is what the other bug reporter is suggesting and I am agreeing with. But now that I saw that the old behaviour is already back in the current master development branch, this is now not related to this bug report anymore. 2123342 10 sausagefactory0 2022-05-14 11:16:21 +0000 > I can not reproduce this bug on current master. It seems to select the child > folder one has emerged from correctly after using the "Up" action. I installed dolphin-git-22.04.0.r67.g0fc218fd2-1 from AUR on Arch Linux, which is supposed to be the current master, and the bug still reproduces. The folder that's underlined is always the first, and not the one I navigated up from. 2123749 11 felixernst 2022-05-16 12:50:50 +0000 I can now also reproduce the bug on master. Not sure why I wasn't able to reproduce it the last time I tried. 2123754 12 mo78 2022-05-16 12:57:40 +0000 It's a crucial behaviour and without it it's a nightmare. Let's hope for a quick fix. 2123833 13 felixernst 2022-05-16 16:40:57 +0000 >I can now also reproduce the bug on master. >Not sure why I wasn't able to reproduce it the last time I tried. The reason why I wasn't able to reproduce with Dolphin master was that the regression was introduced by a change in frameworks and not by a change in Dolphin. Since I had updated frameworks since then I was suddenly able to reproduce the bug on master. I was successful in identifying the faulty commit in the KIO framework: https://invent.kde.org/frameworks/kio/-/commit/fdacbf4e290c856a72a5988f5a612360a76af896 It was the first commit I tried because it looked like it might be the reason. I am therefore moving this bug to KIO now since framework changes shouldn't cause regressions in application code. I'll also let the person responsible for this regression know that this bug exists. I hope they will be able to fix it quickly. 2123970 14 mo78 2022-05-16 20:54:46 +0000 @Felix Ernst Thank you so much! 2124066 15 felixernst 2022-05-17 09:10:43 +0000 You are welcome! 2129025 16 bug-janitor 2022-06-04 18:44:03 +0000 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kio/-/merge_requests/862 2129091 17 rauchwolke 2022-06-05 09:18:26 +0000 (In reply to Bug Janitor Service from comment #16) > A possibly relevant merge request was started @ > https://invent.kde.org/frameworks/kio/-/merge_requests/862 the patch fixes the bug for me 2129962 18 nate 2022-06-08 18:54:34 +0000 *** Bug 455035 has been marked as a duplicate of this bug. *** 2129971 19 nate 2022-06-08 19:12:07 +0000 Git commit 75c62a2d436b359bde211b7255895ed04595ce20 by Nate Graham, on behalf of Janet Blackquill. Committed on 08/06/2022 at 19:12. Pushed by ngraham into branch 'master'. KCoreUrlNavigator: add urlSelectionRequested signal M +3 -0 src/filewidgets/kurlnavigator.cpp M +3 -0 src/gui/kcoreurlnavigator.cpp M +12 -0 src/gui/kcoreurlnavigator.h https://invent.kde.org/frameworks/kio/commit/75c62a2d436b359bde211b7255895ed04595ce20