<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>447314</bug_id>
          
          <creation_ts>2021-12-21 04:47:03 +0000</creation_ts>
          <short_desc>Undoing liquify stroke also undoes liquify configuration</short_desc>
          <delta_ts>2021-12-21 13:50:21 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Tools/Transform</component>
          <version>nightly build (please specify the git hash!)</version>
          <rep_platform>Appimage</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>tomtomtomreportingin</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/commit/d740628f7436c320f8f3f8ae13f284d2c3fcc531</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2087265</commentid>
    <comment_count>0</comment_count>
    <who name="">tomtomtomreportingin</who>
    <bug_when>2021-12-21 04:47:03 +0000</bug_when>
    <thetext>5.0 git 50f8936

SUMMARY
Undoing liquify strokes also undoes changes to the liquify settings. This makes experimenting with different settings extremely annoying. This does not appear to be a regression.

STEPS TO REPRODUCE
1. Open an image.
2. Select Liquify mode in the transform tool.
3. Change a liquify setting.
4. Stroke with liquify.
5. Undo.

OBSERVED RESULT
Both the stroke and settings change are undone.

EXPECTED RESULT
Only the stroke should be undone.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Debian sid
KDE Plasma Version: 5.23.3
KDE Frameworks Version: 5.88.0
Qt Version: 5.12.11 (appimage)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2087298</commentid>
    <comment_count>1</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2021-12-21 10:00:06 +0000</bug_when>
    <thetext>Git commit 6c90c301541ad36321fb6176061d8b10bb1b9a0a by Dmitry Kazakov.
Committed on 21/12/2021 at 09:59.
Pushed by dkazakov into branch &apos;master&apos;.

Fix undo of liquify properties

Undo state should be added when the user ends editing any liquify
property (press Enter or switches focus).

M  +9    -0    plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp

https://invent.kde.org/graphics/krita/commit/6c90c301541ad36321fb6176061d8b10bb1b9a0a</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2087335</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2021-12-21 13:50:21 +0000</bug_when>
    <thetext>Git commit d740628f7436c320f8f3f8ae13f284d2c3fcc531 by Dmitry Kazakov.
Committed on 21/12/2021 at 10:00.
Pushed by dkazakov into branch &apos;krita/5.0&apos;.

Fix undo of liquify properties

Undo state should be added when the user ends editing any liquify
property (press Enter or switches focus).
(cherry picked from commit 6c90c301541ad36321fb6176061d8b10bb1b9a0a)

M  +9    -0    plugins/tools/tool_transform2/kis_tool_transform_config_widget.cpp

https://invent.kde.org/graphics/krita/commit/d740628f7436c320f8f3f8ae13f284d2c3fcc531</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>