<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>446985</bug_id>
          
          <creation_ts>2021-12-14 16:02:35 +0000</creation_ts>
          <short_desc>Workspace chooser and workspace menu has different code paths for saving workspace</short_desc>
          <delta_ts>2022-03-08 14:37:23 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Resource Management</component>
          <version>nightly build (please specify the git hash!)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Alvin Wong">alvin</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/commit/b8ebef709c09b80662d044df6654ea77e7326687</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2085339</commentid>
    <comment_count>0</comment_count>
    <who name="Alvin Wong">alvin</who>
    <bug_when>2021-12-14 16:02:35 +0000</bug_when>
    <thetext>They each do slightly different things

Workspace chooser: https://invent.kde.org/graphics/krita/-/blob/aebd23117d7772b583e18def74e89d5b74536040/libs/ui/widgets/kis_workspace_chooser.cpp#L129
Workspace menu: https://invent.kde.org/graphics/krita/-/blob/aebd23117d7772b583e18def74e89d5b74536040/libs/ui/KisMainWindow.cpp#L2559</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2110084</commentid>
    <comment_count>1</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2022-03-08 14:24:36 +0000</bug_when>
    <thetext>Git commit 0b2b592441fc822c34c5ace8d5fae8fe624b6381 by Halla Rempt.
Committed on 08/03/2022 at 14:23.
Pushed by rempt into branch &apos;krita/5.0&apos;.

Synchronize the two places where we save a new workspace.

I don&apos;t see a way to actually not duplicate the code, though.

M  +3    -6    libs/ui/KisMainWindow.cpp
M  +2    -2    libs/ui/widgets/kis_workspace_chooser.cpp

https://invent.kde.org/graphics/krita/commit/0b2b592441fc822c34c5ace8d5fae8fe624b6381</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2110086</commentid>
    <comment_count>2</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2022-03-08 14:37:23 +0000</bug_when>
    <thetext>Git commit b8ebef709c09b80662d044df6654ea77e7326687 by Halla Rempt.
Committed on 08/03/2022 at 14:37.
Pushed by rempt into branch &apos;master&apos;.

Synchronize the two places where we save a new workspace.

I don&apos;t see a way to actually not duplicate the code, though.
(cherry picked from commit 0b2b592441fc822c34c5ace8d5fae8fe624b6381)

M  +3    -6    libs/ui/KisMainWindow.cpp
M  +2    -2    libs/ui/widgets/kis_workspace_chooser.cpp

https://invent.kde.org/graphics/krita/commit/b8ebef709c09b80662d044df6654ea77e7326687</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>