446792 2021-12-10 17:11:57 +0000 New brush presets seem to use last selected brush's thumbnail by default 2024-10-24 12:36:18 +0000 1 1 2 Applications krita Brush engines 5.0.0-beta2 Other Linux RESOLVED FIXED NOR normal --- 1 griffinvalley krita-bugs-null halla https://invent.kde.org/graphics/krita/-/commit/c1e51b4020d95433851144da92172b790466edc7 0 oldest_to_newest 2084407 0 griffinvalley 2021-12-10 17:11:57 +0000 SUMMARY When saving a new brush preset for an engine, the last selected brush' thumbnail will be used. STEPS TO REPRODUCE 1. Select a preset 2. Use the plus in the brush settings dialog to create a new preset for an unrelated engine. 3. Save preset. OBSERVED RESULT The thumbnail of the brush selected at 1. will be used as the preset image. EXPECTED RESULT I'm not sure... I guess I was expecting a blank image, because the default presets for each engine have a blank image. 2368870 1 dimula73 2024-10-24 12:35:57 +0000 Git commit 429bb8493b4c11ae28888b79f21dff3c56e7ef0b by Dmitry Kazakov. Committed on 24/10/2024 at 12:35. Pushed by dkazakov into branch 'master'. Fix the current preset thumbnail to be present in the preset save dialog We shouldn't update the thumb separately, just load it every time when the dialog is open (in the end, it doesn't happen too often). Related: bug 488673 M +0 -3 libs/ui/kis_paintop_box.cc M +7 -6 libs/ui/widgets/kis_paintop_presets_editor.cpp M +0 -4 libs/ui/widgets/kis_paintop_presets_editor.h https://invent.kde.org/graphics/krita/-/commit/429bb8493b4c11ae28888b79f21dff3c56e7ef0b 2368871 2 dimula73 2024-10-24 12:36:18 +0000 Git commit c1e51b4020d95433851144da92172b790466edc7 by Dmitry Kazakov. Committed on 24/10/2024 at 12:36. Pushed by dkazakov into branch 'krita/5.2'. Fix the current preset thumbnail to be present in the preset save dialog We shouldn't update the thumb separately, just load it every time when the dialog is open (in the end, it doesn't happen too often). Related: bug 488673 M +0 -2 libs/ui/kis_paintop_box.cc M +7 -6 libs/ui/widgets/kis_paintop_presets_editor.cpp M +0 -4 libs/ui/widgets/kis_paintop_presets_editor.h https://invent.kde.org/graphics/krita/-/commit/c1e51b4020d95433851144da92172b790466edc7