<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>445282</bug_id>
          
          <creation_ts>2021-11-10 15:41:14 +0000</creation_ts>
          <short_desc>Overwriting a MyPaint preset creates a file with wrong extension (.myb instead of .kpp)</short_desc>
          <delta_ts>2021-11-25 13:53:12 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Resource Management</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>release_blocker</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          <dependson>439817</dependson>
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Dmitry Kazakov">dimula73</reporter>
          <assigned_to name="amyspark">amy</assigned_to>
          <cc>amy</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/commit/a4f84ca9a3070ff4fe5949da3e8028fe131f3b26</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2076623</commentid>
    <comment_count>0</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2021-11-10 15:41:14 +0000</bug_when>
    <thetext>git sha1: e109a49e80eb47ffed80fafc9503e12a0af5d3df

STEPS TO REPRODUCE
1. Select &quot;i) Wet Knife Plus (mypaint)&quot; preset. Change its diameter to make it dirty
2. Press Overwrite

The file is saved as &quot;i)_Wet_Knife_Plus_(mypaint).0001.myb&quot;, but it should be i)_Wet_Knife_Plus_(mypaint).0001.kpp, because it is a normal Krita preset now, not a JSON.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2078844</commentid>
    <comment_count>1</comment_count>
    <who name="amyspark">amy</who>
    <bug_when>2021-11-19 16:19:43 +0000</bug_when>
    <thetext>Will have a look at it, though I believe this is a consequence of bug 439817.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2080660</commentid>
    <comment_count>2</comment_count>
    <who name="amyspark">amy</who>
    <bug_when>2021-11-25 13:49:38 +0000</bug_when>
    <thetext>Git commit 14e8cd88b267d0c083cb7bee693d02f684d022d6 by L. E. Segovia.
Committed on 25/11/2021 at 13:47.
Pushed by lsegovia into branch &apos;krita/5.0&apos;.

Fix naming of MyPaint brushes on versioned serialization

Before this commit, versioned .myb files would apply the .kpp suffix,
only to be overridden by the save preset dialog.
Related: bug 445281, bug 439817

M  +5    -6    libs/ui/dialogs/KisDlgSavePreset.cpp
M  +6    -4    plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp
M  +0    -7    plugins/paintops/mypaint/MyPaintPaintOpPreset.h

https://invent.kde.org/graphics/krita/commit/14e8cd88b267d0c083cb7bee693d02f684d022d6</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2080665</commentid>
    <comment_count>3</comment_count>
    <who name="amyspark">amy</who>
    <bug_when>2021-11-25 13:53:12 +0000</bug_when>
    <thetext>Git commit a4f84ca9a3070ff4fe5949da3e8028fe131f3b26 by L. E. Segovia.
Committed on 25/11/2021 at 13:50.
Pushed by lsegovia into branch &apos;master&apos;.

Fix naming of MyPaint brushes on versioned serialization

Before this commit, versioned .myb files would apply the .kpp suffix,
only to be overridden by the save preset dialog.
Related: bug 445281, bug 439817
(cherry picked from commit 14e8cd88b267d0c083cb7bee693d02f684d022d6)

M  +5    -6    libs/ui/dialogs/KisDlgSavePreset.cpp
M  +6    -4    plugins/paintops/mypaint/MyPaintPaintOpPreset.cpp
M  +0    -7    plugins/paintops/mypaint/MyPaintPaintOpPreset.h

https://invent.kde.org/graphics/krita/commit/a4f84ca9a3070ff4fe5949da3e8028fe131f3b26</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>