444741 2021-10-31 20:26:09 +0000 CSV importer: account name auto detection generates too many false-positives 2024-12-19 10:04:48 +0000 1 1 2 Applications kmymoney importer 5.1.2 Other Other RESOLVED FIXED NOR normal --- 1 me kmymoney-devel https://invent.kde.org/office/kmymoney/commit/1ebd8c704deb2af890aa54c60411f6e627bd8a4b 5.2 0 oldest_to_newest 2073771 0 me 2021-10-31 20:26:09 +0000 SUMMARY With account name auto detection, CSV importer will automatically attempt to match the imported CSV against existing accounts. However, in case the CSV header only actually contains column names, this may lead to false positives. For example, considering a CSV file containing following header: "Type,Product,Started Date,Completed Date,Description,Amount,Fee,Currency,State,Balance" the importer will match against an "Art" account, having found a match for it in "Started". The solution is to make the autodetection configurable per profile, not globally, which will allow to take advantage of its heuristics only when it actually makes sense. 2073774 1 bug-janitor 2021-10-31 20:31:10 +0000 A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/127 2073776 2 bug-janitor 2021-10-31 20:39:16 +0000 A possibly relevant merge request was started @ https://invent.kde.org/office/kmymoney/-/merge_requests/128 2138164 3 me 2022-07-10 17:17:13 +0000 Git commit 9ec90abbc80a92bf8a7673bedac73219c10b7902 by Dawid Wróbel. Committed on 10/07/2022 at 09:47. Pushed by wrobelda into branch '5.1'. [CSV] Configure account autodetection per profile CSV importer had a global option enabling account name autodetection based on the header contents. This, however, should only really be enabled if the CSV file contains actual account name, and therefore configurable *per profile*. Also: run clang-format against touched source files. M +31 -29 kmymoney/plugins/csv/import/core/csvimportercore.cpp M +120 -65 kmymoney/plugins/csv/import/core/csvimportercore.h M +39 -24 kmymoney/plugins/csv/import/core/tests/csvimportercore-test.cpp M +4 -0 kmymoney/plugins/csv/import/csvwizard.cpp M +0 -6 kmymoney/plugins/csv/import/pluginsettings.kcfg M +44 -1 kmymoney/plugins/csv/import/rowswizardpage.ui M +8 -1 kmymoney/settings/kmymoney.upd https://invent.kde.org/office/kmymoney/commit/9ec90abbc80a92bf8a7673bedac73219c10b7902 2138165 4 me 2022-07-10 17:17:26 +0000 Git commit 1ebd8c704deb2af890aa54c60411f6e627bd8a4b by Dawid Wróbel. Committed on 10/07/2022 at 09:42. Pushed by wrobelda into branch 'master'. [CSV] Configure account autodetection per profile CSV importer had a global option enabling account name autodetection based on the header contents. This, however, should only really be enabled if the CSV file contains actual account name, and therefore configurable *per profile*. Also: run clang-format against touched source files. M +31 -29 kmymoney/plugins/csv/import/core/csvimportercore.cpp M +120 -65 kmymoney/plugins/csv/import/core/csvimportercore.h M +39 -24 kmymoney/plugins/csv/import/core/tests/csvimportercore-test.cpp M +4 -0 kmymoney/plugins/csv/import/csvwizard.cpp M +0 -6 kmymoney/plugins/csv/import/pluginsettings.kcfg M +44 -1 kmymoney/plugins/csv/import/rowswizardpage.ui M +7 -1 kmymoney/settings/kmymoney.upd https://invent.kde.org/office/kmymoney/commit/1ebd8c704deb2af890aa54c60411f6e627bd8a4b