444414 2021-10-26 07:43:05 +0000 Transaction notes are not imported from paypal account 2022-06-02 15:08:53 +0000 1 1 2 Applications kmymoney onlinebanking 5.1.2 Other All RESOLVED FIXED NOR normal --- 0 ralf.habacker kmymoney-devel https://invent.kde.org/office/kmymoney/commit/5b5aa00cdb4e4376056b2dddf7c4db932b0e091d 5.1.3 0 oldest_to_newest 2072319 0 ralf.habacker 2021-10-26 07:43:05 +0000 SUMMARY Sending or receiving money with Paypal allows you to enter a note describing the transaction. This note is not currently imported into kmymoney STEPS TO REPRODUCE 1. download the portable kmymoney snapshot from https://kmymoney.org/snapshots.php. 2. unzip the archive, launch kmymoney, configure a Paypal account (see https://aquamaniac.de/rdm/projects/aqbanking/wiki/Paypal_einrichten or use the settings menu in kmymoney) and assign it to a kmymoney account. 3. make sure that there are transactions with notes in the Paypal account 4. update the assigned account OBSERVED RESULT The imported transactions do not contain the entered notes EXPECTED RESULT The imported transactions should contain the entered notes SOFTWARE/OS VERSIONS Windows: 10 KDE Frameworks Version: 5.65 Qt Version: 5.11 2072325 1 ralf.habacker 2021-10-26 08:00:13 +0000 Current versions of aqbanking do not provide the required attribute, therefore bugreport https://www.aquamaniac.de/rdm/issues/246 was submitted. 2091724 2 ralf.habacker 2022-01-10 14:14:33 +0000 aqbanking 6.3.1 got support to fetch transactions notes from a paypal account. 2091725 3 145297 ralf.habacker 2022-01-10 14:16:10 +0000 Created attachment 145297 Patch from 4.8 branch to fetch transaction note from a paypal account P 2091726 4 145298 ralf.habacker 2022-01-10 14:17:11 +0000 Created attachment 145298 Patch from 4.8 branch to update memos on present transactions 2092162 5 tbaumgart 2022-01-11 17:09:56 +0000 I don't understand the patch "to update memos on present transactions". If a transaction is a duplicate, it is already imported once. How could it change when imported a second time? That can't be. If this is meant only for paypal transactions imported with a prior version of AqBanking, I vote against it, because it might also affect other importers. If you want that, remove the transaction in the ledger and re-import. 2092445 6 ralf.habacker 2022-01-12 08:15:09 +0000 > If an operation is a duplicate, it has already been imported once. How can it change if it is imported a second time? Before aqbanking 6.3.1, (paypal) transactions were imported without memo, although there might be a memo, i.e. Aqbanking now provides more data than before. Since the duplicate check does not include the memo field, this change is not detected and therefore this commit checks for the detected duplicates if the memo field of the present transaction is empty and imports the memo field only in this case. This is effectively a one-time attribute update of the memo field. > If this is only for paypal transactions imported with a previous version of AqBanking, I vote against it because it could affect other importers as well. This functionality can in principle be extended to all aqbanking sources, but requires that the aqbanking backend in question populates the memo field. If the memo field is not filled by aqbanking, nothing happens. > If you want to do this, remove the transaction in the general ledger and import it again. That's what I did at first, but found out that if you have a large number of transactions, this is very time consuming as you have to manually find and delete all the transactions that don't have a memo in order to re-import those. To give the user control over this process, an option could be added in the online settings of an account to explicitly enable this feature. 2092506 7 thb 2022-01-12 11:58:29 +0000 Git commit 74ba29e8c0a31a29bb48236f3b01b38968c58485 by Thomas Baumgart. Committed on 11/01/2022 at 17:14. Pushed by tbaumgart into branch 'master'. Include user supplied paypal note in memo field M +15 -3 kmymoney/plugins/kbanking/kbanking.cpp https://invent.kde.org/office/kmymoney/commit/74ba29e8c0a31a29bb48236f3b01b38968c58485 2093028 8 ralf.habacker 2022-01-13 11:42:58 +0000 In an ideal world, kmymoney could, at the next launch after an update that brings this feature, tell the user that there is now the possibility to apply memos to Paypal accounts and ask the user if this should be done once for all existing transactions. This would require skipping the transactions where the memo text is already included. 2128515 9 ralf.habacker 2022-06-02 15:08:53 +0000 Git commit 5b5aa00cdb4e4376056b2dddf7c4db932b0e091d by Ralf Habacker, on behalf of Thomas Baumgart. Committed on 02/06/2022 at 15:04. Pushed by habacker into branch '5.1'. Include user supplied paypal note in memo field FIXED-IN:5.1.3 (cherry picked from commit 74ba29e8c0a31a29bb48236f3b01b38968c58485) M +15 -3 kmymoney/plugins/kbanking/kbanking.cpp https://invent.kde.org/office/kmymoney/commit/5b5aa00cdb4e4376056b2dddf7c4db932b0e091d 145297 2022-01-10 14:16:10 +0000 2022-01-10 14:16:10 +0000 Patch from 4.8 branch to fetch transaction note from a paypal account 0001-kbanking-append-content-of-memo-field-from-aqbanking.patch text/plain 1019 ralf.habacker RnJvbSAyZTczZGJiOWU4ODY4YTA5Y2I2N2JjYmVhNjk1OTQ1ZmIzMDI0MTY3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYWxmIEhhYmFja2VyIDxyYWxmLmhhYmFja2VyQGZyZWVuZXQu ZGU+CkRhdGU6IFR1ZSwgMjYgT2N0IDIwMjEgMDE6MTc6MTUgKzAyMDAKU3ViamVjdDogW1BBVENI IDEvM10ga2Jhbmtpbmc6IGFwcGVuZCBjb250ZW50IG9mIG1lbW8gZmllbGQgZnJvbSBhcWJhbmtp bmcKIHRyYW5zYWN0aW9uIGlmIG5vdCBlbXB0eQoKLS0tCiBrbXltb25leS9wbHVnaW5zL2tiYW5r aW5nL215bW9uZXliYW5raW5nLmNwcCB8IDEwICsrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAx MCBpbnNlcnRpb25zKCspCgpkaWZmIC0tZ2l0IGEva215bW9uZXkvcGx1Z2lucy9rYmFua2luZy9t eW1vbmV5YmFua2luZy5jcHAgYi9rbXltb25leS9wbHVnaW5zL2tiYW5raW5nL215bW9uZXliYW5r aW5nLmNwcAppbmRleCBlNDM3MjkzMDUuLjM2NzIwZDBiMSAxMDA2NDQKLS0tIGEva215bW9uZXkv cGx1Z2lucy9rYmFua2luZy9teW1vbmV5YmFua2luZy5jcHAKKysrIGIva215bW9uZXkvcGx1Z2lu cy9rYmFua2luZy9teW1vbmV5YmFua2luZy5jcHAKQEAgLTEyMDcsNiArMTIwNywxNiBAQCB2b2lk IEtNeU1vbmV5QmFua2luZzo6X3hhVG9TdGF0ZW1lbnQoTXlNb25leVN0YXRlbWVudCAma3MsCiAg IH0KICNlbmRpZgogCisgIHAgPSBBQl9UcmFuc2FjdGlvbl9HZXRNZW1vKHQpOworICBpZiAocCkg eworICAgIFFTdHJpbmcgdG1wTWVtbzsKKworICAgIHMgKz0gUVN0cmluZzo6ZnJvbVV0ZjgocCku dHJpbW1lZCgpOworICAgIHRtcE1lbW89UVN0cmluZzo6ZnJvbVV0ZjgocCkudHJpbW1lZCgpOwor ICAgIHRtcE1lbW8ucmVwbGFjZSgnXG4nLCAnICcpOworICAgIG1lbW8uYXBwZW5kKHRtcE1lbW8p OworICB9CisKICAga3QubV9zdHJNZW1vID0gbWVtbzsKIAogICAvLyBjYWxjdWxhdGUgdGhlIGhh c2ggY29kZSBhbmQgc3RhcnQgd2l0aCB0aGUgcGF5ZWUgaW5mbwotLSAKMi4yNi4yCgo= 145298 2022-01-10 14:17:11 +0000 2022-01-10 14:17:11 +0000 Patch from 4.8 branch to update memos on present transactions 0002-On-importing-from-online-account-update-memo-if-not-.patch text/plain 3259 ralf.habacker RnJvbSAzZjNjNmQxNzE1N2UwZGEwYjNkODYzODUxYzgxNmQxNTIzZTRlMDU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSYWxmIEhhYmFja2VyIDxyYWxmLmhhYmFja2VyQGZyZWVuZXQu ZGU+CkRhdGU6IFRodSwgMjggT2N0IDIwMjEgMDE6NTM6MzggKzAyMDAKU3ViamVjdDogW1BBVENI IDIvM10gT24gaW1wb3J0aW5nIGZyb20gb25saW5lIGFjY291bnQgdXBkYXRlIG1lbW8gaWYgbm90 CiBwcmVzZW50IGluIGR1cGxpY2F0ZWQgdHJhbnNhY3Rpb25zCgotLS0KIGtteW1vbmV5L2NvbnZl cnRlci9teW1vbmV5c3RhdGVtZW50cmVhZGVyLmNwcCB8IDE5ICsrKysrKysrKysrKysrKysrKy0K IDEgZmlsZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0t Z2l0IGEva215bW9uZXkvY29udmVydGVyL215bW9uZXlzdGF0ZW1lbnRyZWFkZXIuY3BwIGIva215 bW9uZXkvY29udmVydGVyL215bW9uZXlzdGF0ZW1lbnRyZWFkZXIuY3BwCmluZGV4IGI5NDI0MDZl Zi4uODRjNjdlMDMxIDEwMDY0NAotLS0gYS9rbXltb25leS9jb252ZXJ0ZXIvbXltb25leXN0YXRl bWVudHJlYWRlci5jcHAKKysrIGIva215bW9uZXkvY29udmVydGVyL215bW9uZXlzdGF0ZW1lbnRy ZWFkZXIuY3BwCkBAIC03NCw2ICs3NCw3IEBAIHB1YmxpYzoKICAgICAgIHRyYW5zYWN0aW9uc0Fk ZGVkKDApLAogICAgICAgdHJhbnNhY3Rpb25zTWF0Y2hlZCgwKSwKICAgICAgIHRyYW5zYWN0aW9u c0R1cGxpY2F0ZSgwKSwKKyAgICAgIHRyYW5zYWN0aW9uc01lbW9VcGRhdGVkKDApLAogICAgICAg c2Nhbm5lZENhdGVnb3JpZXMoZmFsc2UpIHt9CiAKICAgY29uc3QgUVN0cmluZyYgZmVlSWQoY29u c3QgTXlNb25leUFjY291bnQmIGludkFjYyk7CkBAIC05MSw2ICs5Miw3IEBAIHB1YmxpYzoKICAg aW50ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zYWN0aW9uc0FkZGVkOwogICBpbnQg ICAgICAgICAgICAgICAgICAgICAgICAgICAgdHJhbnNhY3Rpb25zTWF0Y2hlZDsKICAgaW50ICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zYWN0aW9uc0R1cGxpY2F0ZTsKKyAgaW50ICAg ICAgICAgICAgICAgICAgICAgICAgICAgIHRyYW5zYWN0aW9uc01lbW9VcGRhdGVkOwogICBRTWFw PFFTdHJpbmcsIGJvb2w+ICAgICAgICAgICAgdW5pcUlkczsKICAgUU1hcDxRU3RyaW5nLCBNeU1v bmV5U2VjdXJpdHk+IHNlY3VyaXRpZXNCeVN5bWJvbDsKICAgUU1hcDxRU3RyaW5nLCBNeU1vbmV5 U2VjdXJpdHk+IHNlY3VyaXRpZXNCeU5hbWU7CkBAIC00OTUsNiArNDk3LDcgQEAgYm9vbCBNeU1v bmV5U3RhdGVtZW50UmVhZGVyOjppbXBvcnQoY29uc3QgTXlNb25leVN0YXRlbWVudCYgcywgUVN0 cmluZ0xpc3QmIG1lc3MKICAgbWVzc2FnZXMgKz0gaTE4bmNwKCJ4IHRyYW5zYWN0aW9ucyBoYXZl IGJlZW4gYWRkZWQiLCAiICAgICUxIGFkZGVkIiwgIiAgICAlMSBhZGRlZCIsIGQtPnRyYW5zYWN0 aW9uc0FkZGVkKTsKICAgbWVzc2FnZXMgKz0gaTE4bnAoIiAgICAlMSBtYXRjaGVkIiwgIiAgICAl MSBtYXRjaGVkIiwgZC0+dHJhbnNhY3Rpb25zTWF0Y2hlZCk7CiAgIG1lc3NhZ2VzICs9IGkxOG5w KCIgICAgJTEgZHVwbGljYXRlIiwgIiAgICAlMSBkdXBsaWNhdGVzIiwgZC0+dHJhbnNhY3Rpb25z RHVwbGljYXRlKTsKKyAgbWVzc2FnZXMgKz0gaTE4bnAoIiAgICAlMSBtZW1vIHVwZGF0ZSIsICIg ICAgJTEgbWVtbyB1cGRhdGVzIiwgZC0+dHJhbnNhY3Rpb25zTWVtb1VwZGF0ZWQpOwogICBtZXNz YWdlcyArPSBpMThuKCIgIFBheWVlcyIpOwogICBtZXNzYWdlcyArPSBpMThuY3AoInggdHJhbnNh Y3Rpb25zIGhhdmUgYmVlbiBjcmVhdGVkIiwgIiAgICAlMSBjcmVhdGVkIiwgIiAgICAlMSBjcmVh dGVkIiwgcGF5ZWVDb3VudCk7CiAgIG1lc3NhZ2VzICs9IFFTdHJpbmcoKTsKQEAgLTEzNjAsNyAr MTM2MywyMSBAQCB2b2lkIE15TW9uZXlTdGF0ZW1lbnRSZWFkZXI6OmhhbmRsZU1hdGNoaW5nT2ZF eGlzdGluZ1RyYW5zYWN0aW9uKFRyYW5zYWN0aW9uTWF0YwogICAgIGNhc2UgVHJhbnNhY3Rpb25N YXRjaEZpbmRlcjo6TWF0Y2hOb3RGb3VuZDoKICAgICAgIGJyZWFrOwogICAgIGNhc2UgVHJhbnNh Y3Rpb25NYXRjaEZpbmRlcjo6TWF0Y2hEdXBsaWNhdGU6Ci0gICAgICBkLT50cmFuc2FjdGlvbnNE dXBsaWNhdGUrKzsKKyAgICAgIGlmIChtYXRjaGVkVHJhbnNhY3Rpb24uc3BsaXRzKClbMF0ubWVt bygpLmlzRW1wdHkoKSAmJiAhaW1wb3J0ZWRUcmFuc2FjdGlvbi5zcGxpdHMoKVswXS5tZW1vKCku aXNFbXB0eSgpKSB7CisgICAgICAgICAgZC0+dHJhbnNhY3Rpb25zTWVtb1VwZGF0ZWQrKzsKKyAg ICAgICAgICBRTGlzdDxNeU1vbmV5U3BsaXQ+OjpJdGVyYXRvciBpdF9tOworICAgICAgICAgIFFM aXN0PE15TW9uZXlTcGxpdD46OkNvbnN0SXRlcmF0b3IgaXRfaTsKKyAgICAgICAgICBmb3IgKGl0 X20gPSBtYXRjaGVkVHJhbnNhY3Rpb24uc3BsaXRzKCkuYmVnaW4oKSwKKyAgICAgICAgICAgICAg IGl0X2kgPSBpbXBvcnRlZFRyYW5zYWN0aW9uLnNwbGl0cygpLmJlZ2luKCk7IGl0X20gIT0gbWF0 Y2hlZFRyYW5zYWN0aW9uLnNwbGl0cygpLmVuZCgpOyArK2l0X20sICsraXRfaSkgeworICAgICAg ICAgICAgKCppdF9tKS5zZXRNZW1vKCgqaXRfaSkubWVtbygpKTsKKyAgICAgICAgICB9CisgICAg ICAgICAgTXlNb25leUZpbGU6Omluc3RhbmNlKCktPm1vZGlmeVRyYW5zYWN0aW9uKG1hdGNoZWRU cmFuc2FjdGlvbik7CisgICAgICB9IGVsc2UgeworICAgICAgICAgIGlmICghbWF0Y2hlZFRyYW5z YWN0aW9uLnNwbGl0cygpWzBdLm1lbW8oKS5pc0VtcHR5KCkgJiYgIWltcG9ydGVkVHJhbnNhY3Rp b24uc3BsaXRzKClbMF0ubWVtbygpLmlzRW1wdHkoKSkgeworICAgICAgICAgICAgcURlYnVnKCJp ZDonJXMnIG06JyVzJyBpOiclcydcbiIsIHFQcmludGFibGUobWF0Y2hlZFRyYW5zYWN0aW9uLmlk KCkpLCBxUHJpbnRhYmxlKG1hdGNoZWRUcmFuc2FjdGlvbi5zcGxpdHMoKVswXS5tZW1vKCkpLCBx UHJpbnRhYmxlKGltcG9ydGVkVHJhbnNhY3Rpb24uc3BsaXRzKClbMF0ubWVtbygpKSk7CisgICAg ICAgICAgfQorICAgICAgICAgIGQtPnRyYW5zYWN0aW9uc0R1cGxpY2F0ZSsrOworICAgICAgfQog ICAgICAgcURlYnVnKCJEZXRlY3RlZCB0cmFuc2FjdGlvbiBkdXBsaWNhdGUiKTsKICAgICAgIGJy ZWFrOwogICAgIGNhc2UgVHJhbnNhY3Rpb25NYXRjaEZpbmRlcjo6TWF0Y2hJbXByZWNpc2U6Ci0t IAoyLjI2LjIKCg==