443411 2021-10-06 20:37:28 +0000 Regression: %w and %t placeholders not available in bell notifications 2022-04-19 16:53:34 +0000 1 1 2 Applications konsole general 21.08.1 Other Linux RESOLVED FIXED NOR normal --- 1 jpalus+kde konsole-bugs-null avg jbb ninjalj philipp.keck tumaix https://invent.kde.org/utilities/konsole/commit/0fe44c52310a6c276388cf30c81b6fc45a39da32 v22.04.0 0 oldest_to_newest 2066853 0 jpalus+kde 2021-10-06 20:37:28 +0000 Moving from https://invent.kde.org/utilities/konsole/-/issues/26 SUMMARY After 67508680 konsole no longer passes widget when triggering notification for bell which in turns makes %w and %t placeholders unavailable. STEPS TO REPRODUCE 1. Configure bell notification with execute command having %t placeholder OBSERVED RESULT %t placeholder is not replaced EXPECTED RESULT %t should be replaced with window title 2072713 1 khindenburg 2021-10-27 16:18:48 +0000 Jonah Brüchert do you have to look at this? 2074334 2 khindenburg 2021-11-02 22:06:21 +0000 Can you explain where you're getting %t? 2074335 3 jpalus+kde 2021-11-02 22:25:29 +0000 Not sure if I follow, do you mean where it's replaced (https://invent.kde.org/frameworks/knotifications/-/commit/e25f1f552a9ce6b684e573f26c82cfc76bfcbe18) or how do I use it (for mimicking urgency hint in sway) or perhaps something else? 2074336 4 khindenburg 2021-11-02 22:28:48 +0000 OK thanks that makes sense as to why my testing was confusing me 2084341 5 avg 2021-12-10 09:36:36 +0000 I can confirm the same problem with, e.g., '%w' using Konsole 21.08.3. 2090922 6 bug-janitor 2022-01-07 23:52:02 +0000 A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/573 2092096 7 khindenburg 2022-01-11 16:12:27 +0000 Git commit 0fe44c52310a6c276388cf30c81b6fc45a39da32 by Kurt Hindenburg, on behalf of Luis Javier Merino Morán. Committed on 11/01/2022 at 15:57. Pushed by hindenburg into branch 'master'. Pass widget again to KNotification on bell 67508680 refactored TerminalBell out from TerminalDisplay, and in the process stopped passing the TerminalDisplay widget to KNotification, which resulted in issues when notifications where configured to mark the task bar entry or run a command with %w/%t substitutions (for window id and window title). Many thanks to Nicole Kleinhoff and Jan Palus who identified the commit that introduced the regression. Related: bug 445520, bug 443117 M +3 -2 src/terminalDisplay/TerminalBell.cpp M +2 -1 src/terminalDisplay/TerminalBell.h M +1 -1 src/terminalDisplay/TerminalDisplay.cpp https://invent.kde.org/utilities/konsole/commit/0fe44c52310a6c276388cf30c81b6fc45a39da32 2118251 8 ninjalj 2022-04-19 16:53:34 +0000 *** Bug 452767 has been marked as a duplicate of this bug. ***