442375 2021-09-13 08:47:18 +0000 [Wayland] Hamburger menu opens as window if app window is unfocused 2022-11-06 23:27:01 +0000 1 1 3 Frameworks and Libraries frameworks-kconfigwidgets general 5.86.0 Other Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=444312 wayland-only NOR normal --- 1 guimarcalsilva kdelibs-bugs-null bugseforuns dolphin-bugs-null felixernst jebin12raj kde nate https://invent.kde.org/frameworks/kconfigwidgets/commit/82c40f18709484fd462643aa113a8ccf961b646a 5.89 0 oldest_to_newest 2060669 0 guimarcalsilva 2021-09-13 08:47:18 +0000 SUMMARY STEPS TO REPRODUCE 1. Open Dolphin or Gwenview 2. Click on the desktop to unfocus the window 3. Click on the hamburger menu button on the top right corner OBSERVED RESULT Hamburger menu gets its own window EXPECTED RESULT The menu should either open as intended on the first click or not get triggered and instead only focus the window (like what happens with the hamburger menu on System Settings when doing the same thing). SOFTWARE/OS VERSIONS Operating System: KDE neon 5.22 KDE Plasma Version: 5.22.5 KDE Frameworks Version: 5.85.0 Qt Version: 5.15.3 Kernel Version: 5.11.0-34-generic (64-bit) Graphics Platform: Wayland Processors: 4 × Intel® Core™ i5-6200U CPU @ 2.30GHz Memory: 3.7 GiB of RAM Graphics Processor: Mesa Intel® HD Graphics 520 2060670 1 kde 2021-09-13 08:52:19 +0000 Moving to dolphin until kwin is proven to be at fault. 2060672 2 guimarcalsilva 2021-09-13 09:00:58 +0000 (In reply to David Edmundson from comment #1) > Moving to dolphin until kwin is proven to be at fault. Well, the issue also happens with Gwenview, so ir can't be expecific to Dolphin. 2061491 3 nate 2021-09-16 18:49:05 +0000 Could be an issue in KHamburgerMenu itself too. Given that it happens in both apps, moving to where it lives for now. 2062749 4 felixernst 2021-09-21 14:56:06 +0000 Yes, my guess is that the bug is produced because no parent is set for the QMenu in KHamburgerMenuPrivate::newMenu(). It is saved in a std::unique_ptr currently which makes the normal workaround (https://community.kde.org/Guidelines_and_HOWTOs/Wayland_Porting_Notes#Popup_Menus) to this not easily applicable. It is also doubly tricky because this menu is set to be the menu of any potential amount of hamburger menus that the application might want to place anywhere including in multiple windows. In practice we are not doing that currently but this means that there is no clear parent window that can be reliably chosen and expected to be alive for longer than the QMenu itself. 2072089 5 bugseforuns 2021-10-25 19:53:40 +0000 Similar bug affects Yakuake, see bug 437163 2072091 6 guimarcalsilva 2021-10-25 20:06:32 +0000 On System Settings this bug doesn't happen because clicking on the hamburger menu focuses the window first and then you have to click again to activate it. Would it be possible to make the hamburger menu non-interactive if the window is unfocused? 2072432 7 bug-janitor 2021-10-26 15:40:02 +0000 A possibly relevant merge request was started @ https://invent.kde.org/frameworks/kconfigwidgets/-/merge_requests/83 2076334 8 nate 2021-11-09 17:23:04 +0000 Git commit 82c40f18709484fd462643aa113a8ccf961b646a by Nate Graham, on behalf of Felix Ernst. Committed on 09/11/2021 at 17:22. Pushed by ngraham into branch 'master'. Fix hamburger menu opening as a window on Wayland Before this commit, if an app window is unfocused and the first click on the window is the hamburger menu button, the menu would appear displaced as a separate window on Wayland. This commit fixes this by setting a sane transientParent for the menu. This is slightly difficult because there can be any number of hamburger buttons in any number of different windows so we need to figure out spontaneously which button was pressed to open the menu. M +24 -2 src/khamburgermenuhelpers.cpp M +1 -1 src/khamburgermenuhelpers_p.h https://invent.kde.org/frameworks/kconfigwidgets/commit/82c40f18709484fd462643aa113a8ccf961b646a 2169949 9 felixernst 2022-11-06 23:27:01 +0000 *** Bug 444355 has been marked as a duplicate of this bug. ***