<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>442316</bug_id>
          
          <creation_ts>2021-09-12 02:11:32 +0000</creation_ts>
          <short_desc>Gimp image brush file (gih, gbr) with color saves and opens as grayscale</short_desc>
          <delta_ts>2021-09-21 14:13:05 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>File formats</component>
          <version>nightly build (please specify the git hash!)</version>
          <rep_platform>macOS (DMG)</rep_platform>
          <op_sys>macOS</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>triaged</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>apelsinchoklad</reporter>
          <assigned_to name="wolthera">griffinvalley</assigned_to>
          <cc>griffinvalley</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/commit/04ac88205e1c8cfafebcbd96da8166c18de1738d</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2060458</commentid>
    <comment_count>0</comment_count>
    <who name="">apelsinchoklad</who>
    <bug_when>2021-09-12 02:11:32 +0000</bug_when>
    <thetext>SUMMARY
Saving and opening gimp image brush(gbr) and gimp image hose(gih) files with &quot;Create mask from color&quot; unchecked saves and opens as grayscale. (krita-nightly_7f1fe37)

.gih and .gbr files saved in Krita 4.4.8 opens as grayscale but appears correctly when used as brush tip. ​


STEPS TO REPRODUCE
1. Paint something with colors
2. Export as gih or gbr file with &quot;Create mask from color&quot; unchecked
3. Open file/import brush tip and set brush mode to Color image

OBSERVED RESULT
The file/brush stamp appears as grayscale, both in krita 5 and 4.4.8

EXPECTED RESULT
🌈

SOFTWARE/OS VERSIONS
macOS: 10.13.6 High Sierra
Krita Plus: 7f1fe37

ADDITIONAL INFORMATION
When creating brush tip with the +Stamp button in the Brush Editor; Brush Style: Animated appears as grayscale in the preview but works correctly on canvas.

https://krita-artists.org/t/greyscale-animated-brush-does-it-have-to-be-that-way/28769</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2062159</commentid>
    <comment_count>1</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2021-09-19 13:45:13 +0000</bug_when>
    <thetext>Confirmed, very strange, it seems the layer and the document is an RGB one, but yes, it doesn&apos;t load the data as RGB?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2062164</commentid>
    <comment_count>2</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2021-09-19 14:13:21 +0000</bug_when>
    <thetext>Git commit eb127330c81d739f636c413c8b63b51d239706c6 by Wolthera van Hövell tot Westerflier.
Committed on 19/09/2021 at 14:10.
Pushed by woltherav into branch &apos;krita/5.0&apos;.

Interpret gbr/gih brush with application=imagestamp to load with color.

Otherwise, the brush image returns a grayscale image, which is useful for
using the brush in the engines, but not for loading it as a document.

M  +3    -1    plugins/impex/brush/kis_brush_import.cpp

https://invent.kde.org/graphics/krita/commit/eb127330c81d739f636c413c8b63b51d239706c6</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2062165</commentid>
    <comment_count>3</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2021-09-19 14:13:50 +0000</bug_when>
    <thetext>Git commit da4a70a77eb52db06babbf66e777922420546f2c by Wolthera van Hövell, on behalf of Wolthera van Hövell tot Westerflier.
Committed on 19/09/2021 at 14:13.
Pushed by woltherav into branch &apos;master&apos;.

Interpret gbr/gih brush with application=imagestamp to load with color.

Otherwise, the brush image returns a grayscale image, which is useful for
using the brush in the engines, but not for loading it as a document.


(cherry picked from commit eb127330c81d739f636c413c8b63b51d239706c6)

M  +3    -1    plugins/impex/brush/kis_brush_import.cpp

https://invent.kde.org/graphics/krita/commit/da4a70a77eb52db06babbf66e777922420546f2c</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2062675</commentid>
    <comment_count>4</comment_count>
    <who name="">apelsinchoklad</who>
    <bug_when>2021-09-21 09:50:00 +0000</bug_when>
    <thetext>(In reply to wolthera from comment #3)
&gt; Git commit da4a70a77eb52db06babbf66e777922420546f2c by Wolthera van Hövell,
&gt; on behalf of Wolthera van Hövell tot Westerflier.
&gt; Committed on 19/09/2021 at 14:13.
&gt; Pushed by woltherav into branch &apos;master&apos;.
&gt; 
&gt; Interpret gbr/gih brush with application=imagestamp to load with color.
&gt; 
&gt; Otherwise, the brush image returns a grayscale image, which is useful for
&gt; using the brush in the engines, but not for loading it as a document.
&gt; 
&gt; 
&gt; (cherry picked from commit eb127330c81d739f636c413c8b63b51d239706c6)
&gt; 
&gt; M  +3    -1    plugins/impex/brush/kis_brush_import.cpp
&gt; 
&gt; https://invent.kde.org/graphics/krita/commit/
&gt; da4a70a77eb52db06babbf66e777922420546f2c

Opening now works fine. 👍 Saving from menu (File —&gt; Save/Save as.../Export...) still saves as grayscale (krita-nightly_355c72f).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2062738</commentid>
    <comment_count>5</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2021-09-21 14:12:45 +0000</bug_when>
    <thetext>Git commit 55aba9a7a818c7f2df843979bee8c0699887c118 by Wolthera van Hövell tot Westerflier.
Committed on 21/09/2021 at 14:12.
Pushed by woltherav into branch &apos;krita/5.0&apos;.

Also fix saving gbr/gih brushes.

Seems like an overzealous change that caused this one...

M  +1    -1    plugins/impex/brush/kis_brush_export.cpp

https://invent.kde.org/graphics/krita/commit/55aba9a7a818c7f2df843979bee8c0699887c118</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2062739</commentid>
    <comment_count>6</comment_count>
    <who name="wolthera">griffinvalley</who>
    <bug_when>2021-09-21 14:13:05 +0000</bug_when>
    <thetext>Git commit 04ac88205e1c8cfafebcbd96da8166c18de1738d by Wolthera van Hövell, on behalf of Wolthera van Hövell tot Westerflier.
Committed on 21/09/2021 at 14:13.
Pushed by woltherav into branch &apos;master&apos;.

Also fix saving gbr/gih brushes.

Seems like an overzealous change that caused this one...


(cherry picked from commit 55aba9a7a818c7f2df843979bee8c0699887c118)

M  +1    -1    plugins/impex/brush/kis_brush_export.cpp

https://invent.kde.org/graphics/krita/commit/04ac88205e1c8cfafebcbd96da8166c18de1738d</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>