<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>442201</bug_id>
          
          <creation_ts>2021-09-09 03:20:27 +0000</creation_ts>
          <short_desc>Mesh Gradient&apos;s color stop icon confuses with shape control point icon, they are both a white square icon</short_desc>
          <delta_ts>2021-11-19 16:00:34 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Tools/Vector</component>
          <version>5.0.0-beta1</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Tyson Tan">tysontanx</reporter>
          <assigned_to name="sh_zam">shzam</assigned_to>
          <cc>halla</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/commit/0ebb72689133fae01b45d4d8be7b48e2595895b3</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2059752</commentid>
    <comment_count>0</comment_count>
    <who name="Tyson Tan">tysontanx</who>
    <bug_when>2021-09-09 03:20:27 +0000</bug_when>
    <thetext>The Mesh Gradient mode in Shape Select Tool&apos;s Fill tab has a default Rows and Columns value of 1x1. It is useless in this state -- you can&apos;t even assign a color stop! New users would be confused to think this option is broken.

I recommend to set the default value to 3x3 -- that&apos;s a minimum version of what most people consider a mesh.

While we are here, I also recommend to change the color stop icon to a yellow diamond, just like what&apos;s in the Gradient mode next to it. This will help artists to differentiate them with the shape control point icon, which is also a square at the moment.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2059753</commentid>
    <comment_count>1</comment_count>
    <who name="Tyson Tan">tysontanx</who>
    <bug_when>2021-09-09 03:28:30 +0000</bug_when>
    <thetext>Ah, there are color stops on the corners even when it is 1x1!

So it&apos;s just too easy to confuse the color stop points with the shape control points.

Then I will change the bug solely about changing the color stop icon to a yellow diamond.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2059788</commentid>
    <comment_count>2</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2021-09-09 08:23:25 +0000</bug_when>
    <thetext>Sharaf, can you take a look?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2065504</commentid>
    <comment_count>3</comment_count>
    <who name="sh_zam">shzam</who>
    <bug_when>2021-10-01 12:27:36 +0000</bug_when>
    <thetext>Git commit bea8ca5074d9b14d0673294e70268442abc83f4a by Sharaf Zaman.
Committed on 01/10/2021 at 12:26.
Pushed by szaman into branch &apos;master&apos;.

Make Mesh Gradient handles more consistent with mesh transform

M  +14   -0    plugins/tools/defaulttool/defaulttool/KoShapeMeshGradientHandles.cpp
M  +3    -0    plugins/tools/defaulttool/defaulttool/KoShapeMeshGradientHandles.h
M  +6    -4    plugins/tools/defaulttool/defaulttool/SelectionDecorator.cpp

https://invent.kde.org/graphics/krita/commit/bea8ca5074d9b14d0673294e70268442abc83f4a</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2078839</commentid>
    <comment_count>4</comment_count>
    <who name="sh_zam">shzam</who>
    <bug_when>2021-11-19 16:00:14 +0000</bug_when>
    <thetext>Git commit 252a9b38c971f2e0b606bfc6f24ad6a88d719a3b by Sharaf Zaman.
Committed on 19/11/2021 at 15:59.
Pushed by szaman into branch &apos;master&apos;.

Fix improper handle placement for mesh gradients..

..when in alternate units.

M  +9    -1    plugins/tools/defaulttool/defaulttool/KoShapeMeshGradientHandles.cpp

https://invent.kde.org/graphics/krita/commit/252a9b38c971f2e0b606bfc6f24ad6a88d719a3b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2078840</commentid>
    <comment_count>5</comment_count>
    <who name="sh_zam">shzam</who>
    <bug_when>2021-11-19 16:00:32 +0000</bug_when>
    <thetext>Git commit 0ebb72689133fae01b45d4d8be7b48e2595895b3 by Sharaf Zaman.
Committed on 19/11/2021 at 15:56.
Pushed by szaman into branch &apos;krita/5.0&apos;.

Make Mesh Gradient handles more consistent with mesh transform
(cherry picked from commit bea8ca5074d9b14d0673294e70268442abc83f4a)

M  +14   -0    plugins/tools/defaulttool/defaulttool/KoShapeMeshGradientHandles.cpp
M  +3    -0    plugins/tools/defaulttool/defaulttool/KoShapeMeshGradientHandles.h
M  +6    -4    plugins/tools/defaulttool/defaulttool/SelectionDecorator.cpp

https://invent.kde.org/graphics/krita/commit/0ebb72689133fae01b45d4d8be7b48e2595895b3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2078841</commentid>
    <comment_count>6</comment_count>
    <who name="sh_zam">shzam</who>
    <bug_when>2021-11-19 16:00:34 +0000</bug_when>
    <thetext>Git commit 3fc20f9383d616d1aca4d038358e73b4263c36fb by Sharaf Zaman.
Committed on 19/11/2021 at 15:57.
Pushed by szaman into branch &apos;krita/5.0&apos;.

Fix improper handle placement for mesh gradients..

..when in alternate units.
(cherry picked from commit f63ec6ef015aaf648002ad28ce88bb935842a192)

M  +9    -1    plugins/tools/defaulttool/defaulttool/KoShapeMeshGradientHandles.cpp

https://invent.kde.org/graphics/krita/commit/3fc20f9383d616d1aca4d038358e73b4263c36fb</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>