<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>440695</bug_id>
          
          <creation_ts>2021-08-07 14:31:06 +0000</creation_ts>
          <short_desc>Unable to inspect the Splits when account is closed.</short_desc>
          <delta_ts>2021-11-04 17:08:03 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>kmymoney</product>
          <component>ux-ui</component>
          <version>5.1.2</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Dawid Wróbel">me</reporter>
          <assigned_to name="KMyMoney Devel Mailing List">kmymoney-devel</assigned_to>
          <cc>bugzilla</cc>
          
          <cf_commitlink>https://invent.kde.org/office/kmymoney/commit/15efbeb0c749152436f051c1f4a7454e650690b3</cf_commitlink>
          <cf_versionfixedin>5.1.3</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2051835</commentid>
    <comment_count>0</comment_count>
    <who name="Dawid Wróbel">me</who>
    <bug_when>2021-08-07 14:31:06 +0000</bug_when>
    <thetext>SUMMARY
When account is closed, it is impossible to inspect the splits of any transaction in that account. What&apos;s worse, it&apos;s also impossible to inspect these transactions from the counterparty account/category.


STEPS TO REPRODUCE
1. Close an account with a transaction that has split
2. Try to inspect the splits of that transaction
3. Go to one the splits&apos; account/category and try to inspect the splits from that view

OBSERVED RESULT
You can&apos;t inspect the splits from any of these views.

EXPECTED RESULT
Splits view should open (in view mode only) even if any of its splits&apos; account is closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2055225</commentid>
    <comment_count>1</comment_count>
    <who name="Dawid Wróbel">me</who>
    <bug_when>2021-08-22 14:55:10 +0000</bug_when>
    <thetext>Another issue is that if any of the accounts included in a split transaction is closed, it becomes impossible to edit it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2073229</commentid>
    <comment_count>2</comment_count>
    <who name="Fabiano Caruana">bugzilla</who>
    <bug_when>2021-10-29 12:55:05 +0000</bug_when>
    <thetext>Hello KMyMoney-Team,

I also would like to be able to view the split bookings even with a closed account (not edit).
At the moment I have to reactivate the account for this function (and then don&apos;t forget to close it again).

regards
Udo</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2073648</commentid>
    <comment_count>3</comment_count>
    <who name="Thomas Baumgart">thb</who>
    <bug_when>2021-10-31 09:14:50 +0000</bug_when>
    <thetext>Git commit 15efbeb0c749152436f051c1f4a7454e650690b3 by Thomas Baumgart.
Committed on 31/10/2021 at 09:14.
Pushed by tbaumgart into branch &apos;5.1&apos;.

Implement read-only mode for transaction editors

This change is for the stable branch only. Master needs its own
implementation.
FIXED-IN: 5.1.3

M  +10   -0    kmymoney/dialogs/investtransactioneditor.cpp
M  +38   -16   kmymoney/dialogs/kmymoneysplittable.cpp
M  +7    -1    kmymoney/dialogs/kmymoneysplittable.h
M  +39   -17   kmymoney/dialogs/ksplittransactiondlg.cpp
M  +7    -0    kmymoney/dialogs/ksplittransactiondlg.h
M  +11   -0    kmymoney/dialogs/stdtransactioneditor.cpp
M  +7    -1    kmymoney/dialogs/transactioneditor.cpp
M  +7    -0    kmymoney/dialogs/transactioneditor.h
M  +28   -26   kmymoney/dialogs/transactioneditor_p.h
M  +16   -45   kmymoney/views/kgloballedgerview.cpp
M  +0    -23   kmymoney/views/kgloballedgerview_p.h

https://invent.kde.org/office/kmymoney/commit/15efbeb0c749152436f051c1f4a7454e650690b3</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2073837</commentid>
    <comment_count>4</comment_count>
    <who name="Fabiano Caruana">bugzilla</who>
    <bug_when>2021-11-01 06:03:10 +0000</bug_when>
    <thetext>Hi Thomas,

I have tested with the AppImage ... GREAT !!!

Thank you!

greetings
Udo</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2074817</commentid>
    <comment_count>5</comment_count>
    <who name="Thomas Baumgart">thb</who>
    <bug_when>2021-11-04 17:08:03 +0000</bug_when>
    <thetext>Git commit e0e1c65ef53e631b3fea63ddc64340478794bf72 by Thomas Baumgart.
Committed on 04/11/2021 at 17:07.
Pushed by tbaumgart into branch &apos;master&apos;.

Implement read-only mode for transaction editors

This is the implementation of the feature in master

M  +5    -0    kmymoney/views/journaldelegate.cpp
M  +8    -4    kmymoney/views/kmymoneyview.cpp
M  +41   -24   kmymoney/views/newspliteditor.cpp
M  +2    -0    kmymoney/views/newspliteditor.h
M  +29   -8    kmymoney/views/newtransactioneditor.cpp
M  +3    -0    kmymoney/views/newtransactioneditor.h
M  +1    -1    kmymoney/views/simpleledgerview.cpp
M  +14   -4    kmymoney/views/splitdelegate.cpp
M  +1    -0    kmymoney/views/splitdelegate.h
M  +35   -22   kmymoney/views/splitdialog.cpp
M  +1    -0    kmymoney/views/splitdialog.h
M  +8    -0    kmymoney/views/splitview.cpp
M  +2    -0    kmymoney/views/splitview.h
M  +13   -1    kmymoney/views/transactioneditorbase.cpp
M  +3    -0    kmymoney/views/transactioneditorbase.h

https://invent.kde.org/office/kmymoney/commit/e0e1c65ef53e631b3fea63ddc64340478794bf72</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>