436916 2021-05-11 09:37:53 +0000 Konsole Crashes When Zooming in Amp Editor 2021-06-24 08:32:34 +0000 1 1 2 Applications konsole general 21.04.0 Arch Linux Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=436676 NOR normal --- 1 rando7 konsole-bugs-null a.samirh78 cbc.alves christoph+bugtracker micraft.b nate ninjalj https://invent.kde.org/utilities/konsole/commit/2a78bb6ef3b81d1b381c0f48d4141597a4c953fa 0 oldest_to_newest 2031764 0 rando7 2021-05-11 09:37:53 +0000 SUMMARY In amp (https://amp.rs) editor, zooming causes a crash. This is reproducible on two Manjaro systems and on Arch Linux by another user, see this issue:https://github.com/jmacdonald/amp/issues/224 STEPS TO REPRODUCE 1. Open amp in Konsole 2. Use Ctrl+Scroll to Zoom in and out OBSERVED RESULT Konsole crashes EXPECTED RESULT Konsole does not crash SOFTWARE/OS VERSIONS Linux/KDE Plasma: Manjaro 21.0.3 (available in About System) KDE Plasma Version: 5.21.5 KDE Frameworks Version: 5.82.0 Qt Version: 5.15.2 ADDITIONAL INFORMATION Zooming does work, it just that it crashes after zooming in too far/zooming in and out. 2031780 1 138335 rando7 2021-05-11 10:01:59 +0000 Created attachment 138335 Backtrace on latest ArchLinux from another user 2035719 2 ninjalj 2021-05-25 20:47:08 +0000 *** This bug has been marked as a duplicate of bug 436676 *** 2036203 3 ninjalj 2021-05-27 20:10:40 +0000 Reopening, as apparently amp.rs crashes the new reflow code in more than one way. Repeatedly zooming in/out: #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49 #1 0x00007ffff54b4557 in __GI_abort () at abort.c:79 #2 0x00007ffff5a26c27 in QMessageLogger::fatal(char const*, ...) const () from /usr/lib64/libQt5Core.so.5 #3 0x00007ffff5a26016 in qt_assert_x(char const*, char const*, char const*, int) () from /usr/lib64/libQt5Core.so.5 #4 0x00007ffff7ddcdf5 in QVector<QVector<Konsole::Character> >::operator[] (this=0x555555b05090, i=0) at /usr/include/qt5/QtCore/qvector.h:462 #5 0x00007ffff7ddadcb in Konsole::Screen::fastAddHistLine (this=0x555555b05080) at /home/lj/src/term/konsole/src/Screen.cpp:1594 #6 0x00007ffff7dd68bd in Konsole::Screen::resizeImage (this=0x555555b05080, new_lines=13, new_columns=73) at /home/lj/src/term/konsole/src/Screen.cpp:445 #7 0x00007ffff7dbce4a in Konsole::Emulation::setImageSize (this=0x555555def980, lines=13, columns=73) at /home/lj/src/term/konsole/src/Emulation.cpp:314 #8 0x00007ffff7e8aeb5 in Konsole::Session::updateTerminalSize (this=0x555555a6c640) at /home/lj/src/term/konsole/src/session/Session.cpp:753 [...] (gdb) frame 6 #6 0x00007ffff7dd68bd in Konsole::Screen::resizeImage (this=0x555555b05080, new_lines=13, new_columns=73) at /home/lj/src/term/konsole/src/Screen.cpp:445 445 fastAddHistLine(); (gdb) p cursorLine $12 = -16 2043009 4 ninjalj 2021-06-22 11:42:43 +0000 Another crash: ASSERT failure in QList<T>::at: "index out of range", file /usr/include/qt5/QtCore/qlist.h, line 571 Thread 1 "konsole" received signal SIGABRT, Aborted. __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49 49 ../sysdeps/unix/sysv/linux/raise.c: No existe el fichero o el directorio. (gdb) bt #0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:49 #1 0x00007ffff54ab557 in __GI_abort () at abort.c:79 #2 0x00007ffff5a1dc27 in QMessageLogger::fatal(char const*, ...) const () from /usr/lib64/libQt5Core.so.5 #3 0x00007ffff5a1d016 in qt_assert_x(char const*, char const*, char const*, int) () from /usr/lib64/libQt5Core.so.5 #4 0x00007ffff7e11d5b in QList<int>::at (this=0x555555857cc0, i=258) at /usr/include/qt5/QtCore/qlist.h:571 #5 0x00007ffff7e11cb3 in Konsole::CompactHistoryScroll::startOfLine (this=0x555555857ca0, line=259) at /home/lj/src/term/konsole/src/history/compact/CompactHistoryScroll.h:57 #6 0x00007ffff7e11a49 in Konsole::CompactHistoryScroll::reflowLines (this=0x555555857ca0, columns=105) at /home/lj/src/term/konsole/src/history/compact/CompactHistoryScroll.cpp:155 #7 0x00007ffff7dcf998 in Konsole::Screen::resizeImage (this=0x5555559bacd0, new_lines=25, new_columns=105) at /home/lj/src/term/konsole/src/Screen.cpp:448 #8 0x00007ffff7db5f18 in Konsole::Emulation::setImageSize (this=0x555555dbf570, lines=25, columns=105) at /home/lj/src/term/konsole/src/Emulation.cpp:314 #9 0x00007ffff7e88953 in Konsole::Session::updateTerminalSize (this=0x555555996b30) at /home/lj/src/term/konsole/src/session/Session.cpp:757 #10 0x00007ffff7e8879a in Konsole::Session::onViewSizeChange (this=0x555555996b30) at /home/lj/src/term/konsole/src/session/Session.cpp:730 [...] (gdb) frame 6 #6 0x00007ffff7e11a49 in Konsole::CompactHistoryScroll::reflowLines (this=0x555555857ca0, columns=105) at /home/lj/src/term/konsole/src/history/compact/CompactHistoryScroll.cpp:155 155 endLine = startOfLine(currentPos + 1); (gdb) print getLines() $1 = 258 2043010 5 ninjalj 2021-06-22 11:43:14 +0000 A warning: (gdb) b HistoryFile.cpp:164 Breakpoint 2 at 0x7ffff7e0e9ec: file /home/lj/src/term/konsole/src/history/HistoryFile.cpp, line 164. (gdb) c Continuing. getHist(...,1,3630): invalid args. Thread 1 "konsole" hit Breakpoint 2, Konsole::HistoryFile::get (this=0x555556184218, buffer=0x7fffffffc557 "", size=1, loc=3630) at /home/lj/src/term/konsole/src/history/HistoryFile.cpp:164 164 return; (gdb) bt #0 Konsole::HistoryFile::get (this=0x555556184218, buffer=0x7fffffffc557 "", size=1, loc=3630) at /home/lj/src/term/konsole/src/history/HistoryFile.cpp:164 #1 0x00007ffff7e0f590 in Konsole::HistoryScrollFile::getLineProperty (this=0x5555561841a0, lineno=3630) at /home/lj/src/term/konsole/src/history/HistoryScrollFile.cpp:55 #2 0x00007ffff7e0f50d in Konsole::HistoryScrollFile::isWrappedLine (this=0x5555561841a0, lineno=3630) at /home/lj/src/term/konsole/src/history/HistoryScrollFile.cpp:48 #3 0x00007ffff7e0fa0f in Konsole::HistoryScrollFile::reflowLines (this=0x5555561841a0, columns=110) at /home/lj/src/term/konsole/src/history/HistoryScrollFile.cpp:130 #4 0x00007ffff7dcf998 in Konsole::Screen::resizeImage (this=0x5555559bb110, new_lines=19, new_columns=110) at /home/lj/src/term/konsole/src/Screen.cpp:448 #5 0x00007ffff7db5f18 in Konsole::Emulation::setImageSize (this=0x555555dbfbc0, lines=19, columns=110) at /home/lj/src/term/konsole/src/Emulation.cpp:314 #6 0x00007ffff7e88983 in Konsole::Session::updateTerminalSize (this=0x55555591f550) at /home/lj/src/term/konsole/src/session/Session.cpp:757 #7 0x00007ffff7e887ca in Konsole::Session::onViewSizeChange (this=0x55555591f550) at /home/lj/src/term/konsole/src/session/Session.cpp:730 [...] (gdb) p size $6 = 1 (gdb) p loc $7 = 3630 (gdb) p _length $8 = 3630 2043011 6 bug-janitor 2021-06-22 11:44:21 +0000 A possibly relevant merge request was started @ https://invent.kde.org/utilities/konsole/-/merge_requests/417 2043359 7 tcanabrava 2021-06-24 08:32:34 +0000 Git commit 2a78bb6ef3b81d1b381c0f48d4141597a4c953fa by Tomaz Canabrava, on behalf of Luis Javier Merino Morán. Committed on 24/06/2021 at 08:32. Pushed by tcanabrava into branch 'master'. Fix crash/warn on history reflow When the last line in history was marked as wrapped, the history reflow algorithm could try to make an out-of-bound access. These were found via repeteadly zooming-in and out in the amp.rs editor (available through Rust's cargo tool). amp.rs writes in the normal buffer (not in the alternate buffer). While at it, add a Q_ASSERT in HistoryScrollFile::startOfLine() to ensure parameters are in range. Note that after an addCells()/addLine() pair, HistoryScrollFile::startOfLine(getLines) always has the same value as _cells.len(). M +5 -3 src/history/HistoryScrollFile.cpp M +1 -1 src/history/compact/CompactHistoryScroll.cpp https://invent.kde.org/utilities/konsole/commit/2a78bb6ef3b81d1b381c0f48d4141597a4c953fa 138335 2021-05-11 10:01:59 +0000 2021-05-11 10:01:59 +0000 Backtrace on latest ArchLinux Backtrace_Archlinux_Latest text/plain 4528 rando7 ICBrZXJuZWw6IGtvbnNvbGVbNTI4OTFdOiBzZWdmYXVsdCBhdCAxMCBpcCAwMDAwN2ZlMDU0YTA5 Yjg0IHNwIDAwMDA3ZmZkYzY4MmVkZTAgZXJyb3IgNCBpbiBsaWJrb25zb2xlcHJpdmF0ZS5zby4y MS4wNC4wWzdmZTA1NDllNzAwMCtjZjAwMF0KICBrZXJuZWw6IENvZGU6IDQxIDU0IDU1IDg5IGY1 IGJlIDA4IDAwIDAwIDAwIDUzIDQ4IDgzIGVjIDA4IDQ4IDhiIDA3IGJmIDEwIDAwIDAwIDAwIDQ0 IDhiIDIwIGZmIDE1IGY2IDIwIDEwIDAwIDQ5IDhiIDRkIDAwIDQ4IDg5IGMzIDhiIDQxIDA0IDw0 OD4gOGIgN2IgMTAgODkgNDMgMDQgNDggOGIgNDEgMTAgNDggMDEgZGYgNDggNjMgNTEgMDQgNDgg OGQgMzQgMDEKCiAgU3RhY2sgdHJhY2Ugb2YgdGhyZWFkIDUyODkxOgogICMwICAweDAwMDA3ZmUw NTRhMDliODQgbi9hIChsaWJrb25zb2xlcHJpdmF0ZS5zby4yMSArIDB4N2NiODQpCiAgIzEgIDB4 MDAwMDdmZTA1NGEwODhkNCBfWk43S29uc29sZTZTY3JlZW4xNmRpc3BsYXlDaGFyYWN0ZXJFaiAo bGlia29uc29sZXByaXZhdGUuc28uMjEgKyAweDdiOGQ0KQogICMyICAweDAwMDA3ZmUwNTRhMWQ3 NDMgbi9hIChsaWJrb25zb2xlcHJpdmF0ZS5zby4yMSArIDB4OTA3NDMpCiAgIzMgIDB4MDAwMDdm ZTA1NDlmN2ExYSBfWk43S29uc29sZTlFbXVsYXRpb24xMXJlY2VpdmVEYXRhRVBLY2kgKGxpYmtv bnNvbGVwcml2YXRlLnNvLjIxICsgMHg2YWExYSkKICAjNCAgMHgwMDAwN2ZlMDU0ZmNiYjc2IG4v YSAobGliUXQ1Q29yZS5zby41ICsgMHgyZWRiNzYpCiAgIzUgIDB4MDAwMDdmZTA1NDllOTFiZSBf Wk43S29uc29sZTNQdHkxMnJlY2VpdmVkRGF0YUVQS2NpIChsaWJrb25zb2xlcHJpdmF0ZS5zby4y MSArIDB4NWMxYmUpCiAgIzYgIDB4MDAwMDdmZTA1NDlmZmVkNyBfWk43S29uc29sZTNQdHkxMmRh dGFSZWNlaXZlZEV2IChsaWJrb25zb2xlcHJpdmF0ZS5zby4yMSArIDB4NzJlZDcpCiAgIzcgIDB4 MDAwMDdmZTA1NGZjYmI3NiBuL2EgKGxpYlF0NUNvcmUuc28uNSArIDB4MmVkYjc2KQogICM4ICAw eDAwMDA3ZmUwNTJhNGExM2Qgbi9hIChsaWJLRjVQdHkuc28uNSArIDB4NjEzZCkKICAjOSAgMHgw MDAwN2ZlMDUyYTRhYWU5IG4vYSAobGliS0Y1UHR5LnNvLjUgKyAweDZhZTkpCiAgIzEwIDB4MDAw MDdmZTA1NGZjYmJiMCBuL2EgKGxpYlF0NUNvcmUuc28uNSArIDB4MmVkYmIwKQogICMxMSAweDAw MDA3ZmUwNTRmY2YxNzUgX1pOMTVRU29ja2V0Tm90aWZpZXI5YWN0aXZhdGVkRWlOU18xNFFQcml2 YXRlU2lnbmFsRSAobGliUXQ1Q29yZS5zby41ICsgMHgyZjExNzUpCiAgIzEyIDB4MDAwMDdmZTA1 NGZjZjkyOCBfWk4xNVFTb2NrZXROb3RpZmllcjVldmVudEVQNlFFdmVudCAobGliUXQ1Q29yZS5z by41ICsgMHgyZjE5MjgpCiAgIzEzIDB4MDAwMDdmZTA1M2YxODc2MiBfWk4xOVFBcHBsaWNhdGlv blByaXZhdGUxM25vdGlmeV9oZWxwZXJFUDdRT2JqZWN0UDZRRXZlbnQgKGxpYlF0NVdpZGdldHMu c28uNSArIDB4MTVhNzYyKQogICMxNCAweDAwMDA3ZmUwNTRmOTQ4MWEgX1pOMTZRQ29yZUFwcGxp Y2F0aW9uMTVub3RpZnlJbnRlcm5hbDJFUDdRT2JqZWN0UDZRRXZlbnQgKGxpYlF0NUNvcmUuc28u NSArIDB4MmI2ODFhKQogICMxNSAweDAwMDA3ZmUwNTRmZWRmMzYgbi9hIChsaWJRdDVDb3JlLnNv LjUgKyAweDMwZmYzNikKICAjMTYgMHgwMDAwN2ZlMDUyYjNiMDJjIGdfbWFpbl9jb250ZXh0X2Rp c3BhdGNoIChsaWJnbGliLTIuMC5zby4wICsgMHg1NDAyYykKICAjMTcgMHgwMDAwN2ZlMDUyYjhl YjU5IG4vYSAobGliZ2xpYi0yLjAuc28uMCArIDB4YTdiNTkpCiAgIzE4IDB4MDAwMDdmZTA1MmIz ODc4MSBnX21haW5fY29udGV4dF9pdGVyYXRpb24gKGxpYmdsaWItMi4wLnNvLjAgKyAweDUxNzgx KQogICMxOSAweDAwMDA3ZmUwNTRmZWQzMjEgX1pOMjBRRXZlbnREaXNwYXRjaGVyR2xpYjEzcHJv Y2Vzc0V2ZW50c0U2UUZsYWdzSU4xMFFFdmVudExvb3AxN1Byb2Nlc3NFdmVudHNGbGFnRUUgKGxp YlF0NUNvcmUuc28uNSArIDB4MzBmMzIxKQogICMyMCAweDAwMDA3ZmUwNTRmOTMxN2MgX1pOMTBR RXZlbnRMb29wNGV4ZWNFNlFGbGFnc0lOU18xN1Byb2Nlc3NFdmVudHNGbGFnRUUgKGxpYlF0NUNv cmUuc28uNSArIDB4MmI1MTdjKQogICMyMSAweDAwMDA3ZmUwNTRmOWI2MzQgX1pOMTZRQ29yZUFw cGxpY2F0aW9uNGV4ZWNFdiAobGliUXQ1Q29yZS5zby41ICsgMHgyYmQ2MzQpCiAgIzIyIDB4MDAw MDdmZTA1NTJmNmQ1MCBrZGVtYWluIChsaWJrZGVpbml0NV9rb25zb2xlLnNvICsgMHgyNmQ1MCkK ICAjMjMgMHgwMDAwN2ZlMDU0YjM4YjI1IF9fbGliY19zdGFydF9tYWluIChsaWJjLnNvLjYgKyAw eDI3YjI1KQogICMyNCAweDAwMDA1NTg0MWUyMjkwNWUgbi9hIChrb25zb2xlICsgMHgyMDVlKQog IAogIFN0YWNrIHRyYWNlIG9mIHRocmVhZCA1Mjg5MzoKICAjMCAgMHgwMDAwN2ZlMDU0YzA1Mzdm IF9fcG9sbCAobGliYy5zby42ICsgMHhmNDM3ZikKICAjMSAgMHgwMDAwN2ZlMDUyMGM0NjNiIG4v YSAobGlieGNiLnNvLjEgKyAweGM2M2IpCiAgIzIgIDB4MDAwMDdmZTA1MjBjNjM3YiB4Y2Jfd2Fp dF9mb3JfZXZlbnQgKGxpYnhjYi5zby4xICsgMHhlMzdiKQogICMzICAweDAwMDA3ZmUwNGVkNjQx NjEgbi9hIChsaWJRdDVYY2JRcGEuc28uNSArIDB4NWUxNjEpCiAgIzQgIDB4MDAwMDdmZTA1NGRh YzA4ZiBuL2EgKGxpYlF0NUNvcmUuc28uNSArIDB4Y2UwOGYpCiAgIzUgIDB4MDAwMDdmZTA1MzRm ODI5OSBzdGFydF90aHJlYWQgKGxpYnB0aHJlYWQuc28uMCArIDB4OTI5OSkKICAjNiAgMHgwMDAw N2ZlMDU0YzEwMDUzIF9fY2xvbmUgKGxpYmMuc28uNiArIDB4ZmYwNTMpCiAgCiAgU3RhY2sgdHJh Y2Ugb2YgdGhyZWFkIDUyODk1OgogICMwICAweDAwMDA3ZmUwNTRjMDUzN2YgX19wb2xsIChsaWJj LnNvLjYgKyAweGY0MzdmKQogICMxICAweDAwMDA3ZmUwNTJiOGVhZTggbi9hIChsaWJnbGliLTIu MC5zby4wICsgMHhhN2FlOCkKICAjMiAgMHgwMDAwN2ZlMDUyYjNhNTkzIGdfbWFpbl9sb29wX3J1 biAobGliZ2xpYi0yLjAuc28uMCArIDB4NTM1OTMpCiAgIzMgIDB4MDAwMDdmZTA0ZDljNjU1OCBu L2EgKGxpYmdpby0yLjAuc28uMCArIDB4MTAyNTU4KQogICM0ICAweDAwMDA3ZmUwNTJiNjkwYzEg bi9hIChsaWJnbGliLTIuMC5zby4wICsgMHg4MjBjMSkKICAjNSAgMHgwMDAwN2ZlMDUzNGY4Mjk5 IHN0YXJ0X3RocmVhZCAobGlicHRocmVhZC5zby4wICsgMHg5Mjk5KQogICM2ICAweDAwMDA3ZmUw NTRjMTAwNTMgX19jbG9uZSAobGliYy5zby42ICsgMHhmZjA1MykKICAKICBTdGFjayB0cmFjZSBv ZiB0aHJlYWQgNTI4OTQ6CiAgIzAgIDB4MDAwMDdmZTA1NGMwNTM3ZiBfX3BvbGwgKGxpYmMuc28u NiArIDB4ZjQzN2YpCiAgIzEgIDB4MDAwMDdmZTA1MmI4ZWFlOCBuL2EgKGxpYmdsaWItMi4wLnNv LjAgKyAweGE3YWU4KQogICMyICAweDAwMDA3ZmUwNTJiMzg3ODEgZ19tYWluX2NvbnRleHRfaXRl cmF0aW9uIChsaWJnbGliLTIuMC5zby4wICsgMHg1MTc4MSkKICAjMyAgMHgwMDAwN2ZlMDUyYjM4 N2QyIG4vYSAobGliZ2xpYi0yLjAuc28uMCArIDB4NTE3ZDIpCiAgIzQgIDB4MDAwMDdmZTA1MmI2 OTBjMSBuL2EgKGxpYmdsaWItMi4wLnNvLjAgKyAweDgyMGMxKQogICM1ICAweDAwMDA3ZmUwNTM0 ZjgyOTkgc3RhcnRfdGhyZWFkIChsaWJwdGhyZWFkLnNvLjAgKyAweDkyOTkpCiAgIzYgIDB4MDAw MDdmZTA1NGMxMDA1MyBfX2Nsb25lIChsaWJjLnNvLjYgKyAweGZmMDUzKQogIAogIFN0YWNrIHRy YWNlIG9mIHRocmVhZCA1Mjg5NjoKICAjMCAgMHgwMDAwN2ZlMDU0YzA1MzdmIF9fcG9sbCAobGli Yy5zby42ICsgMHhmNDM3ZikKICAjMSAgMHgwMDAwN2ZlMDUyYjhlYWU4IG4vYSAobGliZ2xpYi0y LjAuc28uMCArIDB4YTdhZTgpCiAgIzIgIDB4MDAwMDdmZTA1MmIzODc4MSBnX21haW5fY29udGV4 dF9pdGVyYXRpb24gKGxpYmdsaWItMi4wLnNvLjAgKyAweDUxNzgxKQogICMzICAweDAwMDA3ZmUw NTRmZWQzMjEgX1pOMjBRRXZlbnREaXNwYXRjaGVyR2xpYjEzcHJvY2Vzc0V2ZW50c0U2UUZsYWdz SU4xMFFFdmVudExvb3AxN1Byb2Nlc3NFdmVudHNGbGFnRUUgKGxpYlF0NUNvcmUuc28uNSArIDB4 MzBmMzIxKQogICM0ICAweDAwMDA3ZmUwNTRmOTMxN2MgX1pOMTBRRXZlbnRMb29wNGV4ZWNFNlFG bGFnc0lOU18xN1Byb2Nlc3NFdmVudHNGbGFnRUUgKGxpYlF0NUNvcmUuc28uNSArIDB4MmI1MTdj KQogICM1ICAweDAwMDA3ZmUwNTRkYWFlYTIgX1pON1FUaHJlYWQ0ZXhlY0V2IChsaWJRdDVDb3Jl LnNvLjUgKyAweGNjZWEyKQogICM2ICAweDAwMDA3ZmUwNTI1ZDAwOTggbi9hIChsaWJRdDVEQnVz LnNvLjUgKyAweDE3MDk4KQogICM3ICAweDAwMDA3ZmUwNTRkYWMwOGYgbi9hIChsaWJRdDVDb3Jl LnNvLjUgKyAweGNlMDhmKQogICM4ICAweDAwMDA3ZmUwNTM0ZjgyOTkgc3RhcnRfdGhyZWFkIChs aWJwdGhyZWFkLnNvLjAgKyAweDkyOTkpCiAgIzkgIDB4MDAwMDdmZTA1NGMxMDA1MyBfX2Nsb25l IChsaWJjLnNvLjYgKyAweGZmMDUzKQogCg==