<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>435533</bug_id>
          
          <creation_ts>2021-04-09 05:07:35 +0000</creation_ts>
          <short_desc>Keyboard layout change OSD no longer appears on X11 when switching using &quot;Alternative shortcut&quot;</short_desc>
          <delta_ts>2021-06-01 15:22:58 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>plasmashell</product>
          <component>Keyboard Layout widget</component>
          <version>5.20.90</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=408928</see_also>
          <bug_file_loc>https://invent.kde.org/plasma/plasma-desktop/-/commit/9021b3cb4d597413daa8f9960a0b69524fb77715?merge_request_iid=293</bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>regression</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>1.0</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chromer">downloader030</reporter>
          <assigned_to name="Andrey">butirsky</assigned_to>
          <cc>30secondtobeer</cc>
    
    <cc>butirsky</cc>
    
    <cc>nate</cc>
    
    <cc>nicolas.fella</cc>
          
          <cf_commitlink>https://invent.kde.org/plasma/plasma-desktop/commit/d2ff6eb331d3853f691367055a177eb3fdd13a0c</cf_commitlink>
          <cf_versionfixedin>5.22</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>2023750</commentid>
    <comment_count>0</comment_count>
    <who name="Chromer">downloader030</who>
    <bug_when>2021-04-09 05:07:35 +0000</bug_when>
    <thetext>SUMMARY

After the upgrade to Plasma 5.21, there is no longer a visual cue after I change the layout using the keyboard shortcuts. The one in the taskbar still changes properly, but the usual popup doesn&apos;t appear. The other popups, e.g. volume and brightness, work fine.
It happens only on X11, on wayland it&apos;s ok and working like charm.

STEPS TO REPRODUCE
1. Start Plasma on X11 session.
2. Change layout with keyboard shortcut
3. And no visual cue !

OBSERVED RESULT


EXPECTED RESULT
To show a visual cue when changing layout.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: Arch Linux
KDE Plasma Version: 5.21.4
KDE Frameworks Version: 5.80
Qt Version: 5.15.2

ADDITIONAL INFORMATION</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2023834</commentid>
    <comment_count>1</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-04-09 14:26:24 +0000</bug_when>
    <thetext>Do you use &quot;custom&quot; shortcuts to switch layout? I mean, how you configure them?
Because for ones in Keyboard KCM Advanced tab that never worked on X11 before.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2023894</commentid>
    <comment_count>2</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2021-04-09 20:03:33 +0000</bug_when>
    <thetext>Works on Wayland, known virtually unfixable bug on X11. :(

*** This bug has been marked as a duplicate of bug 408928 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2023902</commentid>
    <comment_count>3</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-04-09 20:15:34 +0000</bug_when>
    <thetext>(In reply to Nate Graham from comment #2)
&gt; Works on Wayland, known virtually unfixable bug on X11. :(
&gt; 
&gt; *** This bug has been marked as a duplicate of bug 408928 ***
This is different.

From https://bugs.kde.org/show_bug.cgi?id=408928#c7:
&quot;I see a similar behaviour (no OSD), but only when the keyboard shortcut is from the &quot;main&quot; shortcut list. If I switch keyboards using a user-defined &quot;alternative&quot; shortcut, the OSD appears.&quot;

Whereas now we seem don&apos;t have OSD in both shortcut cases - thus, a regression.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2023987</commentid>
    <comment_count>4</comment_count>
    <who name="Chromer">downloader030</who>
    <bug_when>2021-04-10 10:05:45 +0000</bug_when>
    <thetext>(In reply to Andrey from comment #1)
&gt; Do you use &quot;custom&quot; shortcuts to switch layout? I mean, how you configure
&gt; them?
&gt; Because for ones in Keyboard KCM Advanced tab that never worked on X11
&gt; before.

No, I use ALT+SHIFT available by default in settings.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2023989</commentid>
    <comment_count>5</comment_count>
    <who name="Chromer">downloader030</who>
    <bug_when>2021-04-10 10:06:39 +0000</bug_when>
    <thetext>(In reply to Nate Graham from comment #2)
&gt; Works on Wayland, known virtually unfixable bug on X11. :(
&gt; 
&gt; *** This bug has been marked as a duplicate of bug 408928 ***

But we had not this bug on 5.20 ! :( :( :(</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025443</commentid>
    <comment_count>6</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-04-15 23:38:30 +0000</bug_when>
    <thetext>I suppose you are speaking about Alternative shortcut in KCM for changing layout.
Because for Main shortcut, it never worked on X11.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025768</commentid>
    <comment_count>7</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-04-17 18:02:43 +0000</bug_when>
    <thetext>Probable reason:
https://invent.kde.org/plasma/plasma-desktop/-/commit/9021b3cb4d597413daa8f9960a0b69524fb77715?merge_request_iid=293

Thanks for reporting, I forgot about it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2025891</commentid>
    <comment_count>8</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-04-18 14:32:23 +0000</bug_when>
    <thetext>I admit this is a regression but let&apos;s truck it in the upstream bug indeed, as the solution should be common (and I have an idea how to fix it)

*** This bug has been marked as a duplicate of bug 408928 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2034966</commentid>
    <comment_count>9</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-05-22 23:10:25 +0000</bug_when>
    <thetext>*** Bug 437512 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2034969</commentid>
    <comment_count>10</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-05-22 23:17:33 +0000</bug_when>
    <thetext>*** Bug 437504 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036989</commentid>
    <comment_count>11</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-06-01 09:52:27 +0000</bug_when>
    <thetext>Long standing bug 408928 is much more trickier to fix, so let&apos;s track it separately.
Sorry for the noise.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036992</commentid>
    <comment_count>12</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2021-06-01 09:57:33 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/493</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036997</commentid>
    <comment_count>13</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-06-01 10:42:49 +0000</bug_when>
    <thetext>Git commit 7ff6711523f2ec18e117a39598398e3598b54d18 by Andrey Butirsky, on behalf of David Edmundson.
Committed on 01/06/2021 at 10:42.
Pushed by butirsky into branch &apos;master&apos;.

[kcms/keyboard] Restore keyboard layout OSD on X11

OSD for alternative shortcut has been removed in 9021b3cb, because that
approach didn&apos;t work well with new layout applet.

Here we restore it with original behavior - the OSD is shown when the
shortcut is invoked, but not when used via the applet.

M  +12   -1    kcms/keyboard/keyboard_daemon.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/7ff6711523f2ec18e117a39598398e3598b54d18</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036998</commentid>
    <comment_count>14</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-06-01 10:44:51 +0000</bug_when>
    <thetext>Git commit ec98b22b58e61eb887ddb0455beacb04e6faf94a by Andrey Butirsky, on behalf of David Edmundson.
Committed on 01/06/2021 at 10:44.
Pushed by butirsky into branch &apos;Plasma/5.22&apos;.

[kcms/keyboard] Restore keyboard layout OSD on X11

OSD for alternative shortcut has been removed in 9021b3cb, because that
approach didn&apos;t work well with new layout applet.

Here we restore it with original behavior - the OSD is shown when the
shortcut is invoked, but not when used via the applet.


(cherry picked from commit 7ff6711523f2ec18e117a39598398e3598b54d18)

M  +12   -1    kcms/keyboard/keyboard_daemon.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/ec98b22b58e61eb887ddb0455beacb04e6faf94a</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2036999</commentid>
    <comment_count>15</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-06-01 10:46:56 +0000</bug_when>
    <thetext>Git commit d2ff6eb331d3853f691367055a177eb3fdd13a0c by Andrey Butirsky, on behalf of David Edmundson.
Committed on 01/06/2021 at 10:46.
Pushed by butirsky into branch &apos;Plasma/5.21&apos;.

[kcms/keyboard] Restore keyboard layout OSD on X11

OSD for alternative shortcut has been removed in 9021b3cb, because that
approach didn&apos;t work well with new layout applet.

Here we restore it with original behavior - the OSD is shown when the
shortcut is invoked, but not when used via the applet.


(cherry picked from commit 7ff6711523f2ec18e117a39598398e3598b54d18)

M  +12   -1    kcms/keyboard/keyboard_daemon.cpp

https://invent.kde.org/plasma/plasma-desktop/commit/d2ff6eb331d3853f691367055a177eb3fdd13a0c</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2037074</commentid>
    <comment_count>16</comment_count>
    <who name="Andrey">butirsky</who>
    <bug_when>2021-06-01 14:59:52 +0000</bug_when>
    <thetext>Does it mean there will be no more 5.21 bugfix releases, Nate?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2037079</commentid>
    <comment_count>17</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2021-06-01 15:22:58 +0000</bug_when>
    <thetext>Yeah. The last 5.21 release was 5.21.5, which was shipped a few weeks ago.

See https://community.kde.org/Schedules/Plasma_5</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>