<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>429348</bug_id>
          
          <creation_ts>2020-11-19 14:45:59 +0000</creation_ts>
          <short_desc>Doesn&apos;t communicate to the user what&apos;s going on when the auth action has been locked due to excessive incorrect password attempts</short_desc>
          <delta_ts>2022-05-27 17:10:18 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>systemsettings</product>
          <component>kcm_sddm</component>
          <version>5.20.3</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=428613</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>usability</keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="postix">postix</reporter>
          <assigned_to name="David Edmundson">kde</assigned_to>
          <cc>bugseforuns</cc>
    
    <cc>eschwartz93</cc>
    
    <cc>nate</cc>
    
    <cc>null</cc>
    
    <cc>plasma-bugs-null</cc>
    
    <cc>postix</cc>
          
          <cf_commitlink>https://invent.kde.org/plasma/sddm-kcm/commit/c14253b0baeb6182c9b5bf888f6c8db77bf3c70e</cf_commitlink>
          <cf_versionfixedin>5.25</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1976692</commentid>
    <comment_count>0</comment_count>
    <who name="postix">postix</who>
    <bug_when>2020-11-19 14:45:59 +0000</bug_when>
    <thetext>SUMMARY

Make a change and click on apply. Enter no password or a wrong password three times.
The password dialog will vanish and the apply button will gray out.

I would not expect this. You wouldn&apos;t know if you didn&apos;t enter the correct password at the third try and would be surprised that the change was not applied afterwards.


SOFTWARE/OS VERSIONS
Operating System: Manjaro Linux
KDE Plasma Version: 5.20.3
KDE Frameworks Version: 5.76.0
Qt Version: 5.15.1</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1976793</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2020-11-19 20:39:33 +0000</bug_when>
    <thetext>This is caused by using the pam_deny module which Arch now used by default. You&apos;ll want to talk to the Arch packagers about it.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977190</commentid>
    <comment_count>2</comment_count>
    <who name="postix">postix</who>
    <bug_when>2020-11-20 16:57:22 +0000</bug_when>
    <thetext>&gt; You&apos;ll want to talk to the Arch packagers about it.

Done:

* https://forum.manjaro.org/t/pam-deny-entering-wrong-password-3x-leads-to-impression-that-password-was-correct/38728

* https://bugs.archlinux.org/task/68689</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977196</commentid>
    <comment_count>3</comment_count>
    <who name="postix">postix</who>
    <bug_when>2020-11-20 17:12:44 +0000</bug_when>
    <thetext>Patrick Silva, you are on Arch. Could you please try to reproduce it and report if you are successful report it to the Arch maintainers? My report was closed immediately, though I&apos;m on Manjaro.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977209</commentid>
    <comment_count>4</comment_count>
    <who name="Patrick Silva">bugseforuns</who>
    <bug_when>2020-11-20 17:57:18 +0000</bug_when>
    <thetext>it&apos;s not Arch specific. I can reproduce on neon unstable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977218</commentid>
    <comment_count>5</comment_count>
    <who name="postix">postix</who>
    <bug_when>2020-11-20 18:05:41 +0000</bug_when>
    <thetext>(In reply to Patrick Silva from comment #4)
&gt; it&apos;s not Arch specific. I can reproduce on neon unstable.

Thanks for checking!

Nate, against what does it need to be reported now?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977227</commentid>
    <comment_count>6</comment_count>
    <who name="Eli Schwartz">eschwartz93</who>
    <bug_when>2020-11-20 18:48:09 +0000</bug_when>
    <thetext>It&apos;s correctly reported against KDE.

&gt; This is caused by using the pam_deny module which Arch now used by default. You&apos;ll want to talk to the Arch packagers about it.

This is a fundamentally invalid argument; calling it a distro bug if KDE produces invalid results when PAM contains an active pam_deny module that rejected the authentication attempt, is missing all the points.
Unless the implication is that no one in their right mind would ever use a core module distributed by the Linux-PAM project, it&apos;s KDE&apos;s job to handle the case where the sysadmin is using it.

Pointing fingers at pam_deny is at best a workaround for people whose buggy KDE setups are currently causing usability issues. The correct response is therefore &quot;this is a bug in KDE, but until a fix is available you may wish to disable pam_deny from your current PAM stack&quot;.

As Patrick pointed out, the problem will just as well manifest on other distros.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1977268</commentid>
    <comment_count>7</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2020-11-20 20:47:38 +0000</bug_when>
    <thetext>Fair enough.

And yeah, I can also reproduce on openSUSE Tumbleweed without the pam_deny module loaded</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2127210</commentid>
    <comment_count>8</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2022-05-27 17:08:10 +0000</bug_when>
    <thetext>Git commit 30edb01b381f78ea2ac9898e33a4c1f9845f1509 by Nate Graham, on behalf of oioi 555.
Committed on 27/05/2022 at 17:08.
Pushed by ngraham into branch &apos;master&apos;.

Re-enable apply button on save failure

Allow user to know that save could not be done.
FIXED-IN: 5.25

M  +1    -0    src/sddmkcm.cpp

https://invent.kde.org/plasma/sddm-kcm/commit/30edb01b381f78ea2ac9898e33a4c1f9845f1509</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2127211</commentid>
    <comment_count>9</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2022-05-27 17:10:18 +0000</bug_when>
    <thetext>Git commit c14253b0baeb6182c9b5bf888f6c8db77bf3c70e by Nate Graham, on behalf of oioi 555.
Committed on 27/05/2022 at 17:10.
Pushed by ngraham into branch &apos;Plasma/5.25&apos;.

Re-enable apply button on save failure

Allow user to know that save could not be done.
FIXED-IN: 5.25


(cherry picked from commit 30edb01b381f78ea2ac9898e33a4c1f9845f1509)

M  +1    -0    src/sddmkcm.cpp

https://invent.kde.org/plasma/sddm-kcm/commit/c14253b0baeb6182c9b5bf888f6c8db77bf3c70e</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>