428559 2020-11-01 13:10:41 +0000 Bad ".desktop" file can easily screw up all gtk icons 2023-07-25 00:19:37 +0000 1 1 4 Plasma plasmashell Task Manager and Icons-Only Task Manager widgets 5.19.5 Other Linux RESOLVED FIXED NOR normal 1.0 0 quwenruo.btrfs hein justin.zobel nate nicolas.fella plasma-bugs-null qydwhotmail https://invent.kde.org/plasma/plasma-workspace/-/commit/5b59a1334c92d3edaf44b774df3fa608016913e8 5.27.7 0 oldest_to_newest 1970692 0 quwenruo.btrfs 2020-11-01 13:10:41 +0000 SUMMARY If installing a specific game (*) using steam with proton, proton would create a corrupted desktop file ".desktop" (exactly the name), to corrupt all gtk app icons used in decoration and "big icon" alt-tab switcher. The offending game is https://store.steampowered.com/app/1372300/Iwaihime/ But since the cause the ".desktop" in .local/share/applications, it doesn't need the game to do the trick. STEPS TO REPRODUCE 1. Create file ".local/share/applications/.desktop" with whatever icon you like 2. Check the icon of the window decoration of any running gtk applications 3. Check the icon of "big icon" alt-tab window OBSERVED RESULT Most GTK applications get wrong icon from the ".desktop" file. EXPECTED RESULT GTK applications still follow their original icon. SOFTWARE/OS VERSIONS Linux/KDE Plasma: Arch KDE Plasma Version: 5.20.2 KDE Frameworks Version: 5.75.0 Qt Version: 5.15.1 ADDITIONAL INFORMATION Maybe it's a bug in gtk icon cache? But strangely I only found the following icons get affects: - GTK app icons in window decoration (if enabled) - GTK app icons in big/small icon alt-tab task switcher QT applications like konsole, dolphin doesn't get affected. And of course, with that ".desktop" file renamed, everything comes back to normal. 1970868 1 justin.zobel 2020-11-01 23:55:13 +0000 It sounds like the issue to me is the bad .desktop file that Steam are providing, not a KDE issue. Perhaps they need to call the desktop file asterisk.desktop. 1970875 2 quwenruo.btrfs 2020-11-02 00:18:30 +0000 Yes, steam is the cause, but the problem is, shouldn't KDE be robust enough to detect such malfunctioning desktop file and don't allow it to corrupt other app's icon? 1970876 3 justin.zobel 2020-11-02 00:20:45 +0000 True I guess this could be solidified more to verify a .desktop file is within spec and if not, ignore it completely. 1970879 4 quwenruo.btrfs 2020-11-02 00:28:39 +0000 I guess that's the correct way to go. Although the only invalid part is the file name. ".desktop". Everything else is pretty OK, and I'm not sure if the name ".desktop" really breaks any spec though. 1971010 5 nicolas.fella 2020-11-02 10:02:10 +0000 I would guess this has to do with how libtaskmanager resolves/guesses the desktop entry for a window, but I haven't looked closer 2217080 6 qydwhotmail 2023-03-17 16:45:44 +0000 Cannot reproduce in 5.27 2242565 7 qydwhotmail 2023-07-24 23:59:32 +0000 Git commit 506fd06e5d07717bd0b52bdfc5970b181454228f by Fushan Wen. Committed on 25/07/2023 at 01:43. Pushed by fusionfuture into branch 'master'. libtaskmanager: skip empty appId when matching '*.appId.desktop' When appId is empty, "*..desktop" can be a match. Some games like Touhou tend to add an extra dot at the end of the desktop name, which causes Marisa to exist everywhere. Related: bug 472576 FIXED-IN: 5.27.7 A +8 -0 libtaskmanager/autotests/data/applications/marisa..desktop M +3 -0 libtaskmanager/autotests/tasktoolstest.cpp M +1 -1 libtaskmanager/tasktools.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/506fd06e5d07717bd0b52bdfc5970b181454228f 2242568 8 qydwhotmail 2023-07-25 00:19:37 +0000 Git commit 5b59a1334c92d3edaf44b774df3fa608016913e8 by Fushan Wen. Committed on 25/07/2023 at 02:08. Pushed by fusionfuture into branch 'Plasma/5.27'. libtaskmanager: skip empty appId when matching '*.appId.desktop' When appId is empty, "*..desktop" can be a match. Some games like Touhou tend to add an extra dot at the end of the desktop name, which causes Marisa to exist everywhere. Related: bug 472576 FIXED-IN: 5.27.7 (cherry picked from commit 506fd06e5d07717bd0b52bdfc5970b181454228f) A +8 -0 libtaskmanager/autotests/data/applications/marisa..desktop M +3 -0 libtaskmanager/autotests/tasktoolstest.cpp M +1 -1 libtaskmanager/tasktools.cpp https://invent.kde.org/plasma/plasma-workspace/-/commit/5b59a1334c92d3edaf44b774df3fa608016913e8