426557 2020-09-15 12:15:10 +0000 Unable to distinguish GtkToggleButton state when focused 2021-11-22 23:47:05 +0000 1 1 4 Plasma Breeze gtk theme 5.19.5 Arch Linux Linux RESOLVED FIXED NOR normal --- 1 kde uhhadd nate https://invent.kde.org/plasma/breeze-gtk/commit/ed314cf17880f71a897bd4a67cce2ffc9468610e 0 oldest_to_newest 1957589 0 131671 kde 2020-09-15 12:15:10 +0000 Created attachment 131671 Test script SUMMARY The state of GtkToggleButton is unclear when the button is also focused. STEPS TO REPRODUCE 1. Run the attached script with Breeze theme. OBSERVED RESULT There is basically no visual difference between the active and inactive state of the button. EXPECTED RESULT It should be easy to tell apart the two states. SOFTWARE/OS VERSIONS Linux/KDE Plasma: (available in About System) KDE Plasma Version: 5.19.5 KDE Frameworks Version: 5.74.0 Qt Version: 5.15.1 1992686 1 kde 2021-01-09 19:37:12 +0000 Recently I've been using PulseEffects, which makes heavy use of toggle buttons. It is really annoying that I'm unable to distinguish the state. I hope this issue is still on the radar, as Breeze is having a visual overhaul, it would be good if this can get fixed (the current breeze and breeze-gtk master doesn't seem to change anything for me). 2079708 2 uhhadd 2021-11-22 20:58:58 +0000 Git commit 19e285b42646c60bd5652c541723e95a3c24547d by Jan Blackquill. Committed on 22/11/2021 at 20:50. Pushed by cblack into branch 'master'. gtk3, gtk4: refactor buttons heavily, make look near-identical to breeze qstyle Related: bug 438185, bug 443919 M +2 -33 src/gtk3/widgets/_app_notifications.scss M +105 -295 src/gtk3/widgets/_button.scss M +2 -8 src/gtk3/widgets/_color_chooser.scss M +1 -69 src/gtk3/widgets/_headerbar.scss M +0 -2 src/gtk3/widgets/_menus.scss M +0 -4 src/gtk3/widgets/_notebook.scss M +1 -1 src/gtk3/widgets/_pathbar.scss M +2 -33 src/gtk4/widgets/_app_notifications.scss M +105 -292 src/gtk4/widgets/_button.scss M +2 -8 src/gtk4/widgets/_color_chooser.scss M +1 -72 src/gtk4/widgets/_headerbar.scss M +0 -11 src/gtk4/widgets/_menus.scss M +0 -4 src/gtk4/widgets/_notebook.scss M +1 -1 src/gtk4/widgets/_pathbar.scss M +1 -1 src/gtk4/widgets/_spinbutton.scss https://invent.kde.org/plasma/breeze-gtk/commit/19e285b42646c60bd5652c541723e95a3c24547d 2079736 3 nate 2021-11-22 23:47:05 +0000 Git commit ed314cf17880f71a897bd4a67cce2ffc9468610e by Nate Graham, on behalf of Jan Blackquill. Committed on 22/11/2021 at 23:46. Pushed by ngraham into branch 'Plasma/5.23'. gtk3, gtk4: refactor buttons heavily, make look near-identical to breeze qstyle Related: bug 438185, bug 443919 (cherry picked from commit 19e285b42646c60bd5652c541723e95a3c24547d) M +2 -33 src/gtk3/widgets/_app_notifications.scss M +105 -295 src/gtk3/widgets/_button.scss M +2 -8 src/gtk3/widgets/_color_chooser.scss M +1 -69 src/gtk3/widgets/_headerbar.scss M +0 -2 src/gtk3/widgets/_menus.scss M +0 -4 src/gtk3/widgets/_notebook.scss M +1 -1 src/gtk3/widgets/_pathbar.scss M +2 -33 src/gtk4/widgets/_app_notifications.scss M +105 -292 src/gtk4/widgets/_button.scss M +2 -8 src/gtk4/widgets/_color_chooser.scss M +1 -72 src/gtk4/widgets/_headerbar.scss M +0 -11 src/gtk4/widgets/_menus.scss M +0 -4 src/gtk4/widgets/_notebook.scss M +1 -1 src/gtk4/widgets/_pathbar.scss M +1 -1 src/gtk4/widgets/_spinbutton.scss https://invent.kde.org/plasma/breeze-gtk/commit/ed314cf17880f71a897bd4a67cce2ffc9468610e 131671 2020-09-15 12:15:10 +0000 2020-09-15 12:15:10 +0000 Test script gtk-toggle-button-test.py text/x-python 378 kde aW1wb3J0IGdpCmdpLnJlcXVpcmVfdmVyc2lvbignR3RrJywgJzMuMCcpCmZyb20gZ2kucmVwb3Np dG9yeSBpbXBvcnQgR3RrCgoKZGVmIHRvZ2dsZWQoYnV0dG9uOiBHdGsuVG9nZ2xlQnV0dG9uKToK ICAgIGJ1dHRvbi5zZXRfbGFiZWwoIkFjdGl2ZSIgaWYgYnV0dG9uLmdldF9hY3RpdmUoKSBlbHNl ICJJbmFjdGl2ZSIpCgoKd2luID0gR3RrLldpbmRvdygpCmJ1dHRvbiA9IEd0ay5Ub2dnbGVCdXR0 b24obGFiZWw9IkluYWN0aXZlIiwgYWN0aXZlPUZhbHNlKQpidXR0b24uY29ubmVjdCgidG9nZ2xl ZCIsIHRvZ2dsZWQpCndpbi5hZGQoYnV0dG9uKQp3aW4uY29ubmVjdCgiZGVzdHJveSIsIEd0ay5t YWluX3F1aXQpCndpbi5zaG93X2FsbCgpCkd0ay5tYWluKCkK