423501 2020-06-25 13:55:33 +0000 insertSingleFileBasicData ignorant of mounted remote file systems and causing gui blocks 2025-05-29 21:50:50 +0000 1 1 3 Frameworks and Libraries baloo-widgets general unspecified Other Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=178678 efficiency-and-performance NOR normal --- 504984 1 sitter stefan.bruens bharadwaj.raju777 nate postix tagwerk19 https://invent.kde.org/libraries/baloo-widgets/commit/7aeedc4492e7eb368261f5de9314a96a18cc357a 0 oldest_to_newest 1939755 0 sitter 2020-06-25 13:55:33 +0000 When browsing remote mounted file systems dolphin can intermittently lock up on subdirectory counting. This appears primarily the case because the insertSingleFileBasicData function is checking if an url has a local path, but a local path doesn't mean it's a local disk ``` bool isSizeUnknown = !item.isLocalFile(); if (!isSizeUnknown) { const QPair<int, int> counts = subDirectoriesCount(item.url().path()); ``` I'm not super sure what to do about it, possibly simply checking item->isSlow(). Along a similar note `static bool isDirectoryMounted` in KFileItem seems also relevant for this. #0 __GI___getdents64 (fd=29, buf=buf@entry=0x31e27f0, nbytes=<optimized out>) at ../sysdeps/unix/sysv/linux/getdents64.c:32 #1 0x00007f0766355365 in __GI___readdir64 (dirp=0x31e27c0) at ../sysdeps/posix/readdir.c:65 #2 0x00007f076851cfb7 in Baloo::FileMetaDataProvider::subDirectoriesCount (path=...) at /home/me/src/baloo-widgets/src/filemetadataprovider.cpp:546 #3 0x00007f076851c565 in Baloo::FileMetaDataProvider::insertSingleFileBasicData (this=0x29a51a0) at /home/me/src/baloo-widgets/src/filemetadataprovider.cpp:159 #4 0x00007f076851e4ff in Baloo::FileMetaDataProvider::setFileItem (this=0x29a51a0) at /home/me/src/baloo-widgets/src/filemetadataprovider.cpp:336 #5 0x00007f076851eae7 in Baloo::FileMetaDataProvider::setItems (this=0x29a51a0, items=...) at /home/me/src/baloo-widgets/src/filemetadataprovider.cpp:408 #6 0x00007f07685163cc in Baloo::FileMetaDataWidget::setItems (this=0x29a52f0, items=...) at /home/me/src/baloo-widgets/src/filemetadatawidget.cpp:297 #7 0x00007f076908f9e7 in InformationPanelContent::refreshMetaData (this=0x28a89a0) at /home/me/src/dolphin/src/panels/information/informationpanelcontent.cpp:299 2100270 1 bharadwaj.raju777 2022-02-02 08:45:46 +0000 https://invent.kde.org/libraries/baloo-widgets/-/merge_requests/14 2101066 2 meven.car 2022-02-04 19:35:48 +0000 Git commit 7aeedc4492e7eb368261f5de9314a96a18cc357a by Méven Car, on behalf of Bharadwaj Raju (away; can't respond). Committed on 04/02/2022 at 19:35. Pushed by meven into branch 'master'. Skip slow files Skips files which are slow according to `KFileItem::isSlow()`. Makes browsing local mounts of remote filesystems (like with rclone) much faster. M +4 -4 src/filemetadataprovider.cpp https://invent.kde.org/libraries/baloo-widgets/commit/7aeedc4492e7eb368261f5de9314a96a18cc357a