421612 2020-05-16 12:15:52 +0000 When formatting IDs, removed „small words” still get counted, leading to unexpected results 2020-07-07 18:06:00 +0000 1 1 2 Applications KBibTeX User interface 0.9.2 Manjaro Linux RESOLVED FIXED NOR normal --- 1 nobodyinperson fischer https://invent.kde.org/office/kbibtex/commit/5a35c183a3ed6c5a604aac2f1943db2ecfcf772d 0.10 0 oldest_to_newest 1930285 0 128510 nobodyinperson 2020-05-16 12:15:52 +0000 Created attachment 128510 could-be-fix for id title word counting SUMMARY KBibTeX can automatically format the IDs, a very handy feature. The possibility to define custom formats is also very useful. However, when removing „small words” (e.g. in the title), these removed words still get counted, leading to an unexpected and non-constant amount of words in the final id. STEPS TO REPRODUCE 1. Add a new ID formatting scheme 2. As only field choose "Title" 3. Choose "First Word" to "Third Word" 4. Enable removing small words 5. Format an entry with title "The very important Title" (even worse if choosing only "First Word" to "First Word" if one wants the first sensible word of the title) OBSERVED RESULT Id is formatted as "veryimportant" (Id is formatted as empty string "") EXPECTED RESULT Id should be formatted as "veryimportanttitle" (Id should be formatted as "very") SOFTWARE/OS VERSIONS up-to-date Manjaro with KBibTex 0.9.2 from the official repositories ADDITIONAL INFORMATION I couldn't compile it myself on the quick, but something along the lines in the attachment should result in the desired behaviour (only increasing the word count when a word was really appended), at least for the title. 1930395 1 fischer 2020-05-16 20:56:09 +0000 I can confirm this problem and I think I have may have fixed it, but I cannot push it due to maintenance on KDE's Git servers. Will try again in a few days and then you can test and confirm if this problem has been fixed. 1940943 2 nobodyinperson 2020-07-01 05:20:48 +0000 Thanks for your work! It seems KDE's migration to https://invent.gitlab.org is now officially live: https://dot.kde.org/2020/06/30/kdes-gitlab-now-live Are you now able to push? 1942204 3 fischer 2020-07-07 11:11:32 +0000 Ok, I pushed a potential fix to my personal clone of KBibTeX's Git repository: https://invent.kde.org/thomasfischer/kbibtex/commit/5a35c183a3ed6c5a604aac2f1943db2ecfcf772d To test the code: 0. Uninstall the distribution-provided KBibTeX installation (not sure if actually necessary; try if problems in following steps arise) 1. Get this script: https://invent.kde.org/thomasfischer/kbibtex-related/-/raw/master/run/run-kbibtex.sh?inline=false 2. Run as: bash run-kbibtex.sh https://invent.kde.org/thomasfischer/kbibtex.git bugs/kde421612 I hope all paths are set correctly after the migration to invent.kde.org 1942211 4 nobodyinperson 2020-07-07 12:17:50 +0000 It seems to work. I had to install a couple of dependencies unter Manjaro (qt5-networkauth, kdoctools and kate) to make it build. When run, the fonts look really ugly, but everything works. Small words are now not counted anymore, thanks. Personally, I'd prefer all non-word-characters (dashes, etc...) being word separators, not only whitespace. But I guess that's another issue... BTW, should one now post issues on GitLab? Or still here? 1942261 5 fischer 2020-07-07 18:03:41 +0000 (In reply to nobodyinperson from comment #4) > It seems to work. I had to install a couple of dependencies unter Manjaro > (qt5-networkauth, kdoctools and kate) to make it build. That is to be expected. > When run, the fonts ok really ugly, but everything works. Icons are likely not loading, either. Mostly a visual issue, the KBibTeX should still work, as you report. > Small words are now not counted anymore, thanks. Good. Then I will apply the patch for real. > Personally, I'd prefer all non-word-characters (dashes, etc...) being word > separators, not only whitespace. But I guess that's another issue... Indeed. Please open a new issue about this. As I am not sure what you mean here, please provide some examples in your new report. > BTW, should one now post issues on GitLab? Or still here? AFAIK, bugs.kde.org is still the primary place to report bugs and request features. For example, at https://community.kde.org/Infrastructure/GitLab is says: "The KDE community does not generally use GitLab for bug reporting. Please continue to submit bug reports on https://bugs.kde.org." 1942262 6 fischer 2020-07-07 18:03:58 +0000 Git commit 5a35c183a3ed6c5a604aac2f1943db2ecfcf772d by Thomas Fischer. Committed on 07/07/2020 at 10:14. Pushed by thomasfischer into branch 'kbibtex/0.10'. When suggesting entry ids, do not count 'small words' When generating entry ids based on title or journal title, a range of words, such as from first to fourth word can be specified. Before this commit, 'small words', despite being removed in the id generation process, were counted when determining the first, second, ... word. If the suggestion template stated 'first word only' and the first word was a 'small word' such as 'the', an empty suggestion may have been generated. M +1 -0 ChangeLog M +3 -2 src/processing/idsuggestions.cpp https://invent.kde.org/office/kbibtex/commit/5a35c183a3ed6c5a604aac2f1943db2ecfcf772d 1942263 7 fischer 2020-07-07 18:06:00 +0000 Git commit 8c4212e4d00ba92f4d9aeebe35cd5393702c2c05 by Thomas Fischer. Committed on 07/07/2020 at 18:00. Pushed by thomasfischer into branch 'master'. When suggesting entry ids, do not count 'small words' When generating entry ids based on title or journal title, a range of words, such as from first to fourth word can be specified. Before this commit, 'small words', despite being removed in the id generation process, were counted when determining the first, second, ... word. If the suggestion template stated 'first word only' and the first word was a 'small word' such as 'the', an empty suggestion may have been generated. Forward-port of commit 5a35c183a3ed6c5a604aa from branch 'kbibtex/0.10'. M +1 -0 ChangeLog M +3 -2 src/processing/idsuggestions.cpp https://invent.kde.org/office/kbibtex/commit/8c4212e4d00ba92f4d9aeebe35cd5393702c2c05 128510 2020-05-16 12:15:52 +0000 2020-05-16 12:15:52 +0000 could-be-fix for id title word counting file_421612.txt text/plain 1134 nobodyinperson ZGlmZiAtLWdpdCBhL3NyYy9wcm9jZXNzaW5nL2lkc3VnZ2VzdGlvbnMuY3BwIGIvc3JjL3Byb2Nl c3NpbmcvaWRzdWdnZXN0aW9ucy5jcHANCmluZGV4IDc1OTVhZTYwLi40ODk4OGM3MyAxMDA2NDQN Ci0tLSBhL3NyYy9wcm9jZXNzaW5nL2lkc3VnZ2VzdGlvbnMuY3BwDQorKysgYi9zcmMvcHJvY2Vz c2luZy9pZHN1Z2dlc3Rpb25zLmNwcA0KQEAgLTY5LDcgKzY5LDcgQEAgcHVibGljOg0KICAgICAg ICAgc3RhdGljIGNvbnN0IFFSZWd1bGFyRXhwcmVzc2lvbiBzZXF1ZW5jZU9mU3BhY2VzKFFTdHJp bmdMaXRlcmFsKCJcXHMrIikpOw0KICAgICAgICAgY29uc3QgUVN0cmluZ0xpc3QgdGl0bGVXb3Jk cyA9IFBsYWluVGV4dFZhbHVlOjp0ZXh0KGVudHJ5LnZhbHVlKEVudHJ5OjpmdFRpdGxlKSkuc3Bs aXQoc2VxdWVuY2VPZlNwYWNlcywgUVN0cmluZzo6U2tpcEVtcHR5UGFydHMpOw0KICAgICAgICAg aW50IGluZGV4ID0gMDsNCi0gICAgICAgIGZvciAoUVN0cmluZ0xpc3Q6OkNvbnN0SXRlcmF0b3Ig aXQgPSB0aXRsZVdvcmRzLmJlZ2luKCk7IGl0ICE9IHRpdGxlV29yZHMuZW5kKCk7ICsraXQsICsr aW5kZXgpIHsNCisgICAgICAgIGZvciAoUVN0cmluZ0xpc3Q6OkNvbnN0SXRlcmF0b3IgaXQgPSB0 aXRsZVdvcmRzLmJlZ2luKCk7IGl0ICE9IHRpdGxlV29yZHMuZW5kKCk7ICsraXQpIHsNCiAgICAg ICAgICAgICBjb25zdCBRU3RyaW5nIGxvd2VyVGV4dCA9IG5vcm1hbGl6ZVRleHQoKml0KS50b0xv d2VyKCk7DQogICAgICAgICAgICAgaWYgKChyZW1vdmVTbWFsbFdvcmRzICYmIHNtYWxsV29yZHMu Y29udGFpbnMobG93ZXJUZXh0KSkgfHwgaW5kZXggPCB0dGkuc3RhcnRXb3JkIHx8IGluZGV4ID4g dHRpLmVuZFdvcmQpDQogICAgICAgICAgICAgICAgIGNvbnRpbnVlOw0KQEAgLTg0LDYgKzg0LDcg QEAgcHVibGljOg0KICAgICAgICAgICAgICAgICB0aXRsZUNvbXBvbmVudCA9IHRpdGxlQ29tcG9u ZW50WzBdLnRvVXBwZXIoKSArIHRpdGxlQ29tcG9uZW50Lm1pZCgxKTsNCiANCiAgICAgICAgICAg ICByZXN1bHQuYXBwZW5kKHRpdGxlQ29tcG9uZW50KTsNCisgICAgICAgICAgICBpbmRleCsrOw0K ICAgICAgICAgfQ0KIA0KICAgICAgICAgc3dpdGNoICh0dGkuY2FzZUNoYW5nZSkgew0K