<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>410891</bug_id>
          
          <creation_ts>2019-08-14 08:52:58 +0000</creation_ts>
          <short_desc>Add mountpoint to default disk label</short_desc>
          <delta_ts>2021-07-01 09:18:37 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-solid</product>
          <component>general</component>
          <version>unspecified</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>usability</keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Guo Yunhe">i</reporter>
          <assigned_to name="Lukáš Tinkl">lukas</assigned_to>
          <cc>a.samirh78</cc>
    
    <cc>kdelibs-bugs-null</cc>
    
    <cc>nate</cc>
    
    <cc>till2.schaefer</cc>
          
          <cf_commitlink>https://invent.kde.org/frameworks/solid/commit/e0f9d9769f666b4a0ab02a53eb5bb9fc53b611e5</cf_commitlink>
          <cf_versionfixedin>5.84</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1874712</commentid>
    <comment_count>0</comment_count>
    <who name="Guo Yunhe">i</who>
    <bug_when>2019-08-14 08:52:58 +0000</bug_when>
    <thetext>I noticed that Dolphin has removed &quot;Root&quot; in places section. I think it is good because we can access &quot;Root&quot; in devices section. (Here must be some partition mounted at /, otherwise the system doesn&apos;t work)

Then I found a problem: the device list only show devices&apos; names as &quot;250GB Hard Drive&quot;, etc. This is clear when you have only one partition. But for some users, they have dual boot, and more partitions are created. The list may look like:

40GB Hard Drive
120GB Hard Drive
240GB Hard Drive
110GB Hard Drive
20GB Hard Drive

Users might be confused.

My suggestion is to add mount point and file system info to device labels or in tooltip:

40GB Hard Drive
    Btrfs, /
120GB Hard Drive
    XFS, /home
240GB Hard Drive
    Ext4, /data
110GB Hard Drive
    NTFS, ???
20GB Hard Drive
    FAT, ???</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874781</commentid>
    <comment_count>1</comment_count>
      <attachid>122114</attachid>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-08-14 15:24:43 +0000</bug_when>
    <thetext>Created attachment 122114
Disks, and one is mounted at /

The root volume uses a special icon so you can tell which one it is.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874782</commentid>
    <comment_count>2</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-08-14 15:27:25 +0000</bug_when>
    <thetext>Still, it might be a good idea to make the default label include the mountpoint.

So you would have:


40GB Hard Drive (/)
120GB Hard Drive (/home)
240GB Hard Drive (/data)
...etc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2038322</commentid>
    <comment_count>3</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2021-06-07 18:03:41 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/frameworks/solid/-/merge_requests/41</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2040109</commentid>
    <comment_count>4</comment_count>
    <who name="Ahmad Samir">a.samirh78</who>
    <bug_when>2021-06-13 00:04:49 +0000</bug_when>
    <thetext>FWIW, the most robust solution is adding partition labels using any partition manager (e.g. gparted), that works across OS&apos;s ...etc, because it&apos;s a property of the filesystem not specific to an OS.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2042222</commentid>
    <comment_count>5</comment_count>
    <who name="David Faure">faure</who>
    <bug_when>2021-06-19 09:34:34 +0000</bug_when>
    <thetext>Git commit e0f9d9769f666b4a0ab02a53eb5bb9fc53b611e5 by David Faure, on behalf of Ahmad Samir.
Committed on 19/06/2021 at 08:53.
Pushed by dfaure into branch &apos;master&apos;.

UDisks backend: improve the description of volume and storage devices

- Nowadays SSD&apos;s are pretty common, using &quot;Hard Drive&quot; doesn&apos;t seem correct,
  &quot;Hard Disk Drive&quot; v.s. &quot;Solid State Drive&quot;. Instead use: &quot;External Drive&quot;
  and &quot;Internal Drive&quot;, which should work for both cases

- Add the block device name (sdX[Y]) to the description, this is useful for
  devices without labels; the same goes for a whole disk device, e.g.
  /dev/sdc, which can&apos;t have a label at all.
  One can easily differentiate between devices based on the device name,
  /dev/sda, /dev/sdc2, /dev/sdd ...etc, which are always unique

An obvious use-case is the Places panel in Dolphin or KFileWidget, if you
have two or more partitions without labels, you can&apos;t tell which is which
easily with just the size.
FIXED-IN: 5.84

M  +13   -9    src/solid/devices/backends/udisks2/udisksdevice.cpp

https://invent.kde.org/frameworks/solid/commit/e0f9d9769f666b4a0ab02a53eb5bb9fc53b611e5</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044483</commentid>
    <comment_count>6</comment_count>
    <who name="Till Schäfer">till2.schaefer</who>
    <bug_when>2021-07-01 07:49:07 +0000</bug_when>
    <thetext>I much appreciate this change! 

However, I would like to argue, that mount points are far less technical and informative. Although they are not always present, one can fall back to device names in this case or present booth information if present. 


possibly related report Bug 433950</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044484</commentid>
    <comment_count>7</comment_count>
    <who name="Till Schäfer">till2.schaefer</who>
    <bug_when>2021-07-01 07:50:55 +0000</bug_when>
    <thetext>(In reply to Till Schäfer from comment #6)
&gt; I much appreciate this change! 
&gt; 
&gt; However, I would like to argue, that mount points are far less technical and
&gt; informative. 
are more informative...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044490</commentid>
    <comment_count>8</comment_count>
    <who name="Ahmad Samir">a.samirh78</who>
    <bug_when>2021-07-01 08:37:16 +0000</bug_when>
    <thetext>Adding the mount point to the text label would make the entry take more space, since this a side panel, the text would either get elided or a horizontal scrollbar would appear. The mount point is used in the tooltip, so you still get that info.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044495</commentid>
    <comment_count>9</comment_count>
    <who name="Till Schäfer">till2.schaefer</who>
    <bug_when>2021-07-01 09:09:39 +0000</bug_when>
    <thetext>sounds reasonable for dolphin. thx for the explanation. 

One further question, does this commit influence other places than sidebar panels (e.g. the labels mentioned in Bug 433950)?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2044500</commentid>
    <comment_count>10</comment_count>
    <who name="Ahmad Samir">a.samirh78</who>
    <bug_when>2021-07-01 09:18:37 +0000</bug_when>
    <thetext>Sorry, I don&apos;t know :)</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>122114</attachid>
            <date>2019-08-14 15:24:43 +0000</date>
            <delta_ts>2019-08-14 15:24:43 +0000</delta_ts>
            <desc>Disks, and one is mounted at /</desc>
            <filename>root disk icon.png</filename>
            <type>image/png</type>
            <size>4637</size>
            <attacher name="Nate Graham">nate</attacher>
            
              <data encoding="base64">iVBORw0KGgoAAAANSUhEUgAAAKkAAAB2CAIAAAA83ySCAAAACXBIWXMAAA7EAAAOxAGVKw4bAAAR
z0lEQVR4Xu2dd1hTZx+GnwwCIWGHJRsUwqYMQRAUB+Ki1i1VQYFaRVvX1/rV1Wpbdx1FUXGB1Tpq
bd1aR60DRVAUKw6GFAVlh7CTnHx/hBFSQPRrTeSc+8rldc7vfc+JXDfvGclzXmhPnjwhCEIqlQIg
CEK2LJFIpFKpbFW2LJFIZMuyBYIgRCKRrCIWiyWShwlRSwrCt8z3Y4nF4oyEmZtfDF40L5hWXj53
3vy027d9e/qAQsVgKhY6T3XOhX37T2c8KyqvEolEohpY1ogAVmOrvr4+UN5qAwrV4o3dl53+Zn5C
fejcjz+01NegS7L3L1iVB5FiLwoVRs59XWVJZR2To6/VNHQ75OHtDAQuifa1l4jFYkmloESg2INC
xaE3Lz1PmhwUFLTsllxjRxgbGYke3XnUAKCh+PrOI5mKHShUnZZxX1kpBMzMusk1doRdxMIZZRu+
nToVamq6TqHD+z3ZlaXYh0KlaXZfnJLynNV7bZQtIJXv0C4s28H/2TCo6TpfIhnUTywWi8ViAE5T
N26SSGTLFCpLk/u6lCv3bCafGKINonPqKd55mtxrDN3xcChBEATRqpmiC9NyrUdBNij35IVyT14o
9+SFck9eKPfkpSu4r808vmH97uQixTpFx7zx93j/D9Inp+KOpgtqxVIag8XW0jextHP17uluzqUp
9uwUDE0dnoG0c19BUbSgHPe1wopafZ9xQ5zZREONoOjp/bSTu9LSg8PDA83ewCDLKmjiZMUixStR
insAgLqeuaUFFwDsHN29XC8m7bn00wXL2MFWTACSiieXz13OeFpSy9I15weE9nflqUlzTq7f+8Ql
enaIGQBAmn1y9b5n/rHTAstPfLu/qN/sqX7aAFBXkHr2bPLDAqFYjWvoMSQypDsL0qqnyWcv3skp
qqJrmfTwDQnxNtUAUPcs+dS5lOyXQhGTo+8QMinMmdP8/+v6KM99K1jmffq6pP6Yfjt7kJUDvSHn
xJ6DuaZ9Bo4ZxKnO+v30L/ugMzPU0prvwE7LyS6BGQ8ACnJz64zcHA1axYOIF3/s3nVVZB8QOtpC
C1UVTB4LkBRcStx7h+s/YNQAvfr85DOn9p3izhzJ18i5cPDcM6vQsAHmHKKqRKSv2bIfMqAi7gGG
mZkJ7paUVMJBknIhXeIxaXSgLQOAxfuC7E3X7v0Vamljw7fXuP34cUUQTxcoevSo3NCZz2u1l7qM
368VGwbOGBsoV69Nv5gssA+L7u+qDsDSpC5v9fF7T97nOwqFtTQtM769pQ4NMG/ZgCSojPsWpIWF
L1BdtH/lvaYCAUKjoh5Qt3bsoX7g0SOhv69W8cPMUn0nR6NWm+JFfr5Y28O29S/Ey8JCQlR3fM03
x2XrUkIqNRZUgsn3C7h58Hz8llx3L2+f9+x56q026/KojHvJ82cvwOrB0waYDCYMPCeM89JpaVbj
sgAw7Jz5Ggfu/ynwtf3zQQnP2dm4pQcAgMlg4G83C0wmExzX4ZG9TeVqmtoAwzo45hPnh3du3Uj+
acs1q8ERE3x4XeGmt5OoyI/akP/7pT/rtD087eigGRkborywVI0nh44GDQCYPTzdtAvS72bczSg2
f89DYdQDBsbGdEFuTmmrIs/IiF5dWEIYyO1PV5MBAKCxjRz9h06ZMdaNlnPtdkGr7bo6yhv3dWX5
T/PYhKhG8PLpn7dv59SZB4f3t2IC0PcKcr1x8Py+n+t7O3fjMhoqi+sNvDwsWABAM/fxNE65drJM
ajfUXVdhlwDbPcj32p4r+w4RQW4WOmoNFbVcRxdz98CeVxOTfzyIQHdLXZa4qkTIdfa25RLPM26W
ss15HEZDeV5pAzgccl3sKcU9ja2lw85OO5SU2vTZjsuwqT3dzTmNh2sN+xExEy6fuZR6+kiVRI2j
rW/fz8WjKfnP8/KxvXLihWtPl7ZMMSz6R0Vwz/x26+yRqw10tp5tHysXc33LAVERWmd/u3X+6PUG
Bltbz6K3nTe4NYK8B5cyf6+sB4ujZ+Y+ItRPX3F3XRraP/RcjkS2IKN5tZx6LkeFUZHzPYUSoNyT
F8o9eaHckxfKPXmh3JMXyj15odyTF8o9eaHckxfKPXmh3JMXyj15Ucp3uC14eHopluRIv52mWPo3
EVz8avyqp+Gbd0/qrtjUJVH+uA8MDDz/27n022nNr/O/nQsMDFTsJ0/y1wGefeefrVAo16etDvX0
+vRErUK9k6jpdLOxtjJsKxbQJVG++6VLFvMMDACkpqVFxcQA4BkYLF2yWLGfHNVFRdUQnt8Yn9Yg
V5Xm7llz+AVQWlomV30NNL1itmz7MrSzs0298yjfvUw8gPitW6d//LFCsU2KiouhZ2Vd80vcT8+b
i5W/bd2ba2HdDaVlje6LTi0dNWRAgJ+vb/CI6d+dz5fN/Ci5u2NmxMhhIUEBft5+/cOmrTiR0/Qb
dH15L8+IfS8BADmHZo4c0ifAz9t/4Oi5W28Uy+aiqb616/MpY4b1C+zl7d//w4QHANDw/OKmTz4Y
4O/j13/EjHVn8+ob96byKPl8D2BiROQPiXtS09IAeHs1nv5jPprWqlNrysvLYTp+wYCLM3bvSB61
tJc6IM3+YfsFrZFbIl/OWFHaGNXUcRgUvWCosTZD+PjYhnULl5o675pgCsnzu9fva0xYvaqvlrg0
89iW+MVfGLociLZu9Q4Az2309IWTDbkovbt/3aZ5K63PrAvVQtWD388/0I5cOd9fixDU8awAwdlF
kxfcsp4461tfA0Hqj5v/OzGv4eim4a1T4qqJ8t3LkB/0r6S8vAI6um7jYkIT5+84Oq3XeJPqS7t+
fOY1O76nYTyn/kVZNcAB1O38B9sBADxcq2+eWpR2VzLBVBbPNXIO7OXDAnr6sB5fnX/hYn70VAv5
dwC0+X0HypbcrV9eDklIe4hQWe5Mzcor2LfpEvX+xvXnJaHrNs0L5gDo7WdcPix2447UoQu8lX9E
fRXKd//3QQ8gYfu29m8BagQCEUOLq8kOjA63HZW49+7o8Du7z3FGbA0zRCaXi4qKcoADlNxK2rTj
RMqTl0JocQgQ/KoaQKv1vjRsbExxs7gYaO1e8vyPbXGJ5+7kFtcwdDTqITSqatXeSMn9+y/g0su3
6TE+dR8/d/qv9zIK4S17aFCVUb57yA36Zt8d3t0JhUJwTLkAbMdPDU76MmFFxeOHLlPWeKkBXC4X
QqEQwPMDc2dtFobMXzLrPUNm1eUN0+MU9wMAUFfXgEikMAm09OGWWfMOaI5ZsHw+Xw/FJ7+dsbd1
hyZkGdd3FOW737pt+86EBNlys/Kt27a39FBEKBSCrcEGAK3+0WO2hO85ozNk3QcmAMBms1FZWQkg
60FmQ/eZ08b4mwFAoTEDsou4zlDz6M+nxHtfzhzuownAzKbd7Lahi7MRjt24WRMWrAkADakpdwm9
vk5yTwCpLqrgftvWbdsUqx1RJawCm60BAKA7TZgTU3HTcmKQbJ2tqYnqKqEU6MHnM84dT/i5+0hH
HovILZHI7+IVcPiO5rRDR7acMg610WVW5QuAdu76XSNnBx9b+PVsI+FkPwNB6v7vf63zXRLtq/on
e6iCe/nDu+yYL6u0f76vrqkGm81uXDMMil0S1NzG0dQEIRRWA93GfbPi5art2z47U1YHDS09U6f+
Rp34aWmgAXCYtnaxYG3i2nmHK+rpbB0DG5de7Yx9vSErktQ2r4rb8NkPNeqm7oOXJ80aqviUoIqi
5Gcz2hcMvOKs/88jOve574LaZcmbhpHjgdxOjIR/k7dstz2Ikuz0v/KuHLgO/hQ3coiH0t2rCGV/
bJixOkPXPnjRVxMsFRu7LJR7AOCN/P7GSMVil+eduCCl+Feg3JMXyj15odyTF8o9eaHckxcl3+Op
yOd61fm3Uwp0/X1tSfO5DqB09wACAwObI3sySkpLv1q2/MqVK3K95CGurh395bHCsuoGqHG09Yzs
3APej5wWxm/n65ZOkLbjkzn5M85T7t8yCuLRlNUcMDBEviiHVFCQV2L2YdwXA7VENeXPMi8c2L0k
KqP6wK4JCtkbig5R/vm+zVhmm8VWcM1cXF3dPX37hkUuXzLWvPburfuNkUui5FbCZ+EDA/x69gmb
8vWRR9XN20gF9w8unjwswM8vYPDE/ybdKZf/Y4Dp6wZ4enl4ennE/lIjV+7CKH/cy7KaCsWOs5ot
SMXVRY8vHrxUyPac7M4CgLrUFRHTT+m8H7ss1rw+8+ctqydNrzq8J8KKDsnjhOgpuxv6T1sc04P+
9NzW+I+mlO88/KmbmmxX/Midy4boAOAYyqIAXR7lu39D0tb2814LKUFIAZpur/krRnQDgPyDm46U
ei9KXDySByCgt23diPCEzRfGrB4oPv797my7qJ9XRFrTgMAAJ1p+2Mbvj4YnjDUEAGgYWHW3exfi
tf8Yyj/m/33QA0jY/qokj1PkzgMHDh3cn7Rt3aIP7R6ujYo9mCcFcT8jk7Dz82tySOf7+ejU3svI
Ah5n3G8w9vW1bppq2dyvp4UkI4PEf7v9nR33bJ5NdztdAHBw8/Fh5PT96sjZvHFRaDc82VGskkb7
2+TbJED5477NWGabxfapr28A6HQGGE7ODrTsmzeaJtImHqWkCtRdnLsD9i7Oai9TbuY1bVOQkvKM
7uTsAMjSvRUCQVMTSVD+uH/9rCYAQJh/Lz2dK6oTluSlnzuwL1XDe0GoBYDxn3xwOPa7T1eIo/uZ
N2T+HJdU4PjRhoGaAMJmRvwwaefsReqxQ+3pT8/Gb84wm5DwgTEA2Dk5qe8/Hr/fcWwPRuFLzaBh
Xnqt361Lonz3r5/VpOmYmBvcOjJ76o9SBoutzbOw95iyMjIixBwANH0XJsYZrdqwfeGvlQwDfr85
ifPG2dABgOn48a6d2qvW7Fs6u0yqa9s7Kv7zSA/ZhznaIXOW3Vv6XfyCy9A2d57EJ4d7KqtJXpQ8
7im7SkT513oUyoJyT14o9+SFck9eKPfkhXJPXij35IVyT16U/NkO9bmeElH+uH/9eTUlJ+d6eUzd
XyJfe7pjlGevxe2lOynaQvnu28tqylco/g2UfMxHO7HMNoudhyi5tXP1+kPXcgRMI+eBEQvmjHLg
AEDB6W8WJ97MfV4sqGfqWbgNnThYK/3YyesPngnVTNwGfbLkPwPNZfPvESWpe9fFHU3OKmUaOQRO
mDt3jJPC5GxdAOWP+4kRkYqlzmQ1pRJRQ0N980skaUnl1KWuiJi+55njlGXr1n4epnNj9aTpiXkE
AFQ8SUkrtY9ZE7f9+68m2eXvXf71KZH/lC9Wr18+yeavnxatOS0EAIgebIn5eG+JV/TKuI3/Ha51
fWXst5dkLV0K5Y/7N+TuhsF+G1qXWM4AOopragIA28rTz8sB8HIo++P8Kq7/2LBgTcDf6vml4fHJ
aRjWF4JjcUmFQV/+MGsIB4AHvzKtz/ITV5cFD25M9HYVlO++vaxmx7cA6BEetyhEu3m18PgXC44D
QGNcM7Z1XHP3tYwsDHRr7g4AumZmmkRuWYVs/jRTExOIysurAO6TB5mSeuGyYL/lso6EmCB6FLxQ
nHrznUf57t8Qjinf1bUlUq11s+lxKmn7cU0FWCw1SCSN8+4xmUxALBYDYKmzoDd46c4ox5a+arom
LStdBOWf79uMZbZZ7BwdxDU7iXX37syyzFyxpbWNddPLTLeLHfChCuP+DbOa7WPVflyzc2gPixm/
Kzpp9hxp1PueZuz64twi3qCxfv/XnYcqonz3r5/VfBXtxzU7Ccvj06QEw7XrD21cmFTL1Day8Jjq
PxZdzj2V1SQvSh73lF0l8jqHQoquBeWevLwN95oczZLiVt+6UagCb+N879DD/vHjx9m5uYoNFErl
bbin0+l8Pl+xSqFs3sYxn0I1odyTl7dxzBeLxVlZWdU1JJm+6p3hbbjPysoyNjE25JFqIqN3gLdx
zK+uqaHEqyBvwz2FakK5Jy+Ue/JCuScvlHvyQrknL5R78kKXNqHYQtHVaXQPgPoNIBtMGo0msy6b
S5rSTx7odnZ2HA5HFs+V/UvpJwl0Op1uYWHB5XJlWWxQB3/SQD98+DCNRrOysuJwOLLsPSj95OB/
55aIZV7jIm4AAAAASUVORK5CYII=
</data>

          </attachment>
      

    </bug>

</bugzilla>