<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>409954</bug_id>
          
          <creation_ts>2019-07-18 13:12:07 +0000</creation_ts>
          <short_desc>KIO FTP: kioclient hangs while copying file over existing file [copy() did not call finished() or error()]</short_desc>
          <delta_ts>2019-09-12 15:24:07 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>3</classification_id>
          <classification>Frameworks and Libraries</classification>
          <product>frameworks-kio</product>
          <component>FTP</component>
          <version>5.60.0</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Yaroslav Sidlovsky">zawertun</reporter>
          <assigned_to name="David Faure">faure</assigned_to>
          <cc>Dr</cc>
    
    <cc>jm.dev</cc>
    
    <cc>kdelibs-bugs-null</cc>
    
    <cc>KVAnton.WEB</cc>
    
    <cc>nate</cc>
    
    <cc>nortexoid</cc>
    
    <cc>sh200105</cc>
    
    <cc>simonebondi456</cc>
          
          <cf_commitlink>https://commits.kde.org/kio/ccae728a5494658d865705628bb6e89ead4dd54e</cf_commitlink>
          <cf_versionfixedin>5.62</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1869727</commentid>
    <comment_count>0</comment_count>
    <who name="Yaroslav Sidlovsky">zawertun</who>
    <bug_when>2019-07-18 13:12:07 +0000</bug_when>
    <thetext>How to reproduce:

1. Copy file to some dir:
kioclient5 cp f30.png ftp://127.0.0.1/Public 

2. Copy same file to the same dir:
kioclient5 cp f30.png ftp://127.0.0.1/Public 

After step 2 kioclient will hang indefinitely,
it&apos;ll also produce this warning: &quot;kf5.kio.core: copy() did not call finished() or error()! Please fix the &quot;kio_ftp&quot; KIO slave&quot;

 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1869728</commentid>
    <comment_count>1</comment_count>
    <who name="Yaroslav Sidlovsky">zawertun</who>
    <bug_when>2019-07-18 13:12:47 +0000</bug_when>
    <thetext>Proposed fix: https://phabricator.kde.org/D22528</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1869748</commentid>
    <comment_count>2</comment_count>
    <who name="Anton K">KVAnton.WEB</who>
    <bug_when>2019-07-18 15:07:14 +0000</bug_when>
    <thetext>I also have this problem in the Dolphin.

OS: KDE neon 5.16
DE: KDE 5.60.0 / Plasma 5.16.3
Qt: 5.12.3
Kernel: x86_64 Linux 5.0.0-050000-generic</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1870630</commentid>
    <comment_count>3</comment_count>
    <who name="Driglu4it">Dr</who>
    <bug_when>2019-07-24 06:01:45 +0000</bug_when>
    <thetext>Confirm this bug</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1872610</commentid>
    <comment_count>4</comment_count>
    <who name="Yaroslav Sidlovsky">zawertun</who>
    <bug_when>2019-08-02 13:44:49 +0000</bug_when>
    <thetext>Bug still present in plasma 5.16.4.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874397</commentid>
    <comment_count>5</comment_count>
    <who name="Yaroslav Sidlovsky">zawertun</who>
    <bug_when>2019-08-12 09:42:15 +0000</bug_when>
    <thetext>Duplicate of: https://bugs.kde.org/show_bug.cgi?id=410357.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874424</commentid>
    <comment_count>6</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-08-12 13:56:11 +0000</bug_when>
    <thetext>*** Bug 410357 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874451</commentid>
    <comment_count>7</comment_count>
    <who name="Simone">simonebondi456</who>
    <bug_when>2019-08-12 18:23:30 +0000</bug_when>
    <thetext>Can confirm. The dialogs either do not show or show after a long delay, but the FTP connections stay alive and have to be manually closed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1876342</commentid>
    <comment_count>8</comment_count>
    <who name="Harald Sitter">sitter</who>
    <bug_when>2019-08-22 13:09:19 +0000</bug_when>
    <thetext>Git commit ccae728a5494658d865705628bb6e89ead4dd54e by Harald Sitter, on behalf of Yaroslav Sidlovsky.
Committed on 22/08/2019 at 13:09.
Pushed by sitter into branch &apos;master&apos;.

KIO FTP: Fix file copy hanging when copying to existing file

Summary: BUG: 409954

Test Plan:
Before patch:
1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
2. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
Kioclient will hang with debug message: `kf5.kio.core: copy() did not call finished() or error()! Please fix the &quot;kio_ftp&quot; KIO slave`

After patch:
1. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
2. kioclient5 cp f30.png ftp://127.0.0.1/Public/f30.png
All is OK, kioclient5 will exit with error status and say that file already exists.

Reviewers: sitter, dfaure, cfeck

Reviewed By: sitter

Subscribers: ngraham, rikmills, kde-frameworks-devel

Tags: #frameworks

Differential Revision: https://phabricator.kde.org/D22528

M  +4    -6    src/ioslaves/ftp/ftp.cpp

https://commits.kde.org/kio/ccae728a5494658d865705628bb6e89ead4dd54e</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1879723</commentid>
    <comment_count>9</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-09-12 15:24:07 +0000</bug_when>
    <thetext>*** Bug 411819 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>