409949 2019-07-18 11:43:31 +0000 Clone layers cannot copy contents from pass-through group layers 2019-09-21 12:09:08 +0000 1 1 2 Applications krita Layer Stack 4.2.2 openSUSE Linux CONFIRMED NOR wishlist --- 1 akari krita-bugs-null dimula73 halla 0 oldest_to_newest 1869710 0 121605 akari 2019-07-18 11:43:31 +0000 Created attachment 121605 Test script Projection updates are actually all kinds of broken, apparently. Described in the summary is just a case that happened to completely ruin my workflow. This is a big deal for me, because it makes batch exports unreliable. Attached is a script that demonstrates the issue. It's a very simplified version of my actual export script, and is meant to be used with this document (too big to attach): https://akari.alienslab.net/krita-bug/cirno.kra STEPS TO REPRODUCE 1. $ PYTHONPATH=. kritarunner -s export_alphamaps cirno.kra 2. Grab a coffee, it's really slow. 3. Find the files `alphamap_normal.png` and `alphamap_defeated.png` in the working directory. 4. Open and compare them. OBSERVED RESULT The exported images are identical. EXPECTED RESULT The exported images must differ slightly. This is what `alphamap_defeated.png` is supposed to look like: https://akari.alienslab.net/krita-bug/alphamap_defeated_correct.png SOFTWARE/OS VERSIONS KDE Plasma Version: 5.16.2 KDE Frameworks Version: 5.59.0 Qt Version: 5.13.0 ADDITIONAL INFORMATION This particular problem is caused by the clone layer (root)->"alphamap"->"base mask group"->"variant mask", which refers to the group layer (root)->"variant", failing to update its contents when (root)->"variant"->"defeated" becomes visible, in spite of the refreshProjection() call. This problem occurs in the GUI as well, though the behavior seems to be more inconsistent. 1881020 1 dimula73 2019-09-19 19:21:33 +0000 The problem happens because layers "variant" "defeated" use Pass-through mode. Clone layers just copy the projection of the source layers, but pass-through nodes cannot have any projection by definition. I'll check if it is actually possible to implement such copying technically. 1881173 2 dimula73 2019-09-20 09:47:37 +0000 Git commit a0caf30f820581733b65b5b97d1641560531ad46 by Dmitry Kazakov. Committed on 20/09/2019 at 09:47. Pushed by dkazakov into branch 'master'. Strikethrough (and disable) a clone, whose source is a pass-through group Clone layers in Krita copy the projection of the source layer (and apply some effects to it, like offset, masks and etc). But pass-through group layers don't have any projection by definition, so clone layers cannot copy them. The only way to allow clone layers to copy pass-through groups is to copy their "projection plane" and "projection leaf" instead of projection device. But then there will be problems with masks, blending mode and other funny problems we never thought about. This patch just disables a clone layer that is connected to a pass-through group and notifies the user about it by striking-through its name. M +24 -4 libs/image/kis_projection_leaf.cpp M +9 -1 libs/image/kis_projection_leaf.h M +2 -2 libs/ui/kis_node_model.cpp M +1 -1 plugins/dockers/animation/timeline_frames_model.cpp https://invent.kde.org/kde/krita/commit/a0caf30f820581733b65b5b97d1641560531ad46 1881174 3 dimula73 2019-09-20 09:47:37 +0000 Git commit a2a1b600423be2b9ebf545d5bb89ede49c245748 by Dmitry Kazakov. Committed on 20/09/2019 at 09:47. Pushed by dkazakov into branch 'master'. Add user explanation about why the mask/clone is disabled The node tooltip will have an explanation, why the node has been disabled M +12 -0 libs/ui/kis_node_model.cpp M +5 -0 libs/ui/kis_node_model.h M +7 -0 plugins/dockers/layerdocker/NodeToolTip.cpp https://invent.kde.org/kde/krita/commit/a2a1b600423be2b9ebf545d5bb89ede49c245748 1881175 4 dimula73 2019-09-20 09:48:47 +0000 Okay, the user feedback is added. Now I'll downgrade this bug to a "wishlist". Perhaps one day we will implement cloning of pass-through nodes. 1881394 5 dimula73 2019-09-21 12:09:08 +0000 Git commit f78b6082f5c03d88fce513947f81901e6f31a1d4 by Dmitry Kazakov. Committed on 21/09/2019 at 10:07. Pushed by dkazakov into branch 'krita/4.2'. Strikethrough (and disable) a clone, whose source is a pass-through group Clone layers in Krita copy the projection of the source layer (and apply some effects to it, like offset, masks and etc). But pass-through group layers don't have any projection by definition, so clone layers cannot copy them. The only way to allow clone layers to copy pass-through groups is to copy their "projection plane" and "projection leaf" instead of projection device. But then there will be problems with masks, blending mode and other funny problems we never thought about. This patch just disables a clone layer that is connected to a pass-through group and notifies the user about it by striking-through its name. M +24 -4 libs/image/kis_projection_leaf.cpp M +9 -1 libs/image/kis_projection_leaf.h M +2 -2 libs/ui/kis_node_model.cpp M +1 -1 plugins/dockers/animation/timeline_frames_model.cpp https://invent.kde.org/kde/krita/commit/f78b6082f5c03d88fce513947f81901e6f31a1d4 121605 2019-07-18 11:43:31 +0000 2019-07-18 11:43:31 +0000 Test script export_alphamaps.py text/x-python 928 akari CmZyb20ga3JpdGEgaW1wb3J0ICoKCgpkZWYgZmluZE5vZGUobm9kZXMsIG5hbWUpOgogICAgZm9y IG5vZGUgaW4gbm9kZXM6CiAgICAgICAgaWYgbm9kZS5uYW1lKCkgPT0gbmFtZToKICAgICAgICAg ICAgcmV0dXJuIG5vZGUKCgpkZWYgX19tYWluX18oYXJncyk6CiAgICBrciA9IEtyaXRhLmluc3Rh bmNlKCkKICAgIGtyLnNldEJhdGNobW9kZShUcnVlKQoKICAgIGRvYyA9IGtyLm9wZW5Eb2N1bWVu dChhcmdzWzBdKQogICAgZG9jLnNldEJhdGNobW9kZShUcnVlKQoKICAgIHZhcmlhbnRzID0gZmlu ZE5vZGUoZG9jLnRvcExldmVsTm9kZXMoKSwgJ3ZhcmlhbnQnKQogICAgYWxwaGFtYXAgPSBmaW5k Tm9kZShkb2MudG9wTGV2ZWxOb2RlcygpLCAnYWxwaGFtYXAnKQoKICAgIGVjID0gSW5mb09iamVj dCgpCiAgICBlYy5zZXRQcm9wZXJ0eSgic2F2ZVNSR0JQcm9maWxlIiwgRmFsc2UpCiAgICBlYy5z ZXRQcm9wZXJ0eSgiY29tcHJlc3Npb24iLCAxKQogICAgYm91bmRzID0gZG9jLmJvdW5kcygpCgog ICAgdmFyX2RlZmVhdGVkID0gZmluZE5vZGUodmFyaWFudHMuY2hpbGROb2RlcygpLCAnZGVmZWF0 ZWQnKQogICAgdmFyX2RlZmVhdGVkLnNldFZpc2libGUoVHJ1ZSkKCiAgICBkb2MucmVmcmVzaFBy b2plY3Rpb24oKQogICAgZG9jLndhaXRGb3JEb25lKCkKICAgIGFscGhhbWFwLnNhdmUoJ2FscGhh bWFwX2RlZmVhdGVkLnBuZycsIDEsIDEsIGVjLCBib3VuZHMpCiAgICBkb2Mud2FpdEZvckRvbmUo KQoKICAgIHZhcl9kZWZlYXRlZC5zZXRWaXNpYmxlKEZhbHNlKQoKICAgIGRvYy5yZWZyZXNoUHJv amVjdGlvbigpCiAgICBkb2Mud2FpdEZvckRvbmUoKQogICAgYWxwaGFtYXAuc2F2ZSgnYWxwaGFt YXBfbm9ybWFsLnBuZycsIDEsIDEsIGVjLCBib3VuZHMpCiAgICBkb2Mud2FpdEZvckRvbmUoKQoK ICAgIGRvYy5jbG9zZSgpCg==