<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>408002</bug_id>
          
          <creation_ts>2019-05-27 16:38:58 +0000</creation_ts>
          <short_desc>Issue with selecting multiple layers</short_desc>
          <delta_ts>2019-06-06 02:23:56 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Layer Stack</component>
          <version>nightly build (please specify the git hash!)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Microsoft Windows</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>grzegorzpedrycz</reporter>
          <assigned_to name="vanyossi">ghevan</assigned_to>
          <cc>ghevan</cc>
          
          <cf_commitlink>https://invent.kde.org/kde/krita/commit/f56df71a77a9a3f3a60fd8b71d3f75976cc3ac2b</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1859080</commentid>
    <comment_count>0</comment_count>
    <who name="">grzegorzpedrycz</who>
    <bug_when>2019-05-27 16:38:58 +0000</bug_when>
    <thetext>SUMMARY

We can not select multiple layers using shift+LMB  when clicking on the layer thumbnail . We need to click in any other place in layer tab ( name etc ) 
 
4.2.0 Beta nigt builid git 77c9d6b 


STEPS TO REPRODUCE
1. Create few empty layers
2. Try to select multiple with shift+LMB clicking on the layer thumbnail 
3. 

OBSERVED RESULT
Nothing happend


EXPECTED RESULT
Multiple layer celected


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: 
(available in About System)
KDE Plasma Version: 
KDE Frameworks Version: 
Qt Version: 

ADDITIONAL INFORMATION</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1859138</commentid>
    <comment_count>1</comment_count>
    <who name="vanyossi">ghevan</who>
    <bug_when>2019-05-28 04:57:33 +0000</bug_when>
    <thetext>Git commit c475619ef738854bf40d6b6844510c13da1357dc by Ivan Yossi.
Committed on 28/05/2019 at 04:55.
Pushed by ivany into branch &apos;master&apos;.

Improve selection behaviour on layer docker when pressing thumbnail
BACKPORT:krita/4.2

M  +9    -1    plugins/dockers/layerdocker/NodeDelegate.cpp

https://invent.kde.org/kde/krita/commit/c475619ef738854bf40d6b6844510c13da1357dc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1859543</commentid>
    <comment_count>2</comment_count>
    <who name="">grzegorzpedrycz</who>
    <bug_when>2019-05-30 09:24:00 +0000</bug_when>
    <thetext>Why that improvement is not part of official krita 4.2 Relase ?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1859635</commentid>
    <comment_count>3</comment_count>
    <who name="vanyossi">ghevan</who>
    <bug_when>2019-05-30 16:04:55 +0000</bug_when>
    <thetext>The changes were sent after the installers were made. Binaries for distribution are prepared a few days before realease.

This changes will probably be available in 4.2.1  :)

In the mean time for multiple selections click on the name part of the layer</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860129</commentid>
    <comment_count>4</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2019-06-02 10:08:03 +0000</bug_when>
    <thetext>Git commit f56df71a77a9a3f3a60fd8b71d3f75976cc3ac2b by Boudewijn Rempt, on behalf of Ivan Yossi.
Committed on 02/06/2019 at 09:37.
Pushed by rempt into branch &apos;krita/4.2&apos;.

Improve selection behaviour on layer docker when pressing thumbnail
BACKPORT:krita/4.2
(cherry picked from commit c475619ef738854bf40d6b6844510c13da1357dc)

M  +9    -1    plugins/dockers/layerdocker/NodeDelegate.cpp

https://invent.kde.org/kde/krita/commit/f56df71a77a9a3f3a60fd8b71d3f75976cc3ac2b</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1860824</commentid>
    <comment_count>5</comment_count>
    <who name="">grzegorzpedrycz</who>
    <bug_when>2019-06-05 08:58:43 +0000</bug_when>
    <thetext>Bug still appear in Krita 4.2.1 even if in release note we read that is solved ;)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1861063</commentid>
    <comment_count>6</comment_count>
    <who name="vanyossi">ghevan</who>
    <bug_when>2019-06-06 02:23:56 +0000</bug_when>
    <thetext>This is ongoing: Shift click on the thumbnail will work only if the layer is not a parent layer (either group or have masks applied) unless we select it, but if we do select it multiple selection breaks.

I prefer to select using name area, but i will send the change to make it multiselect on thumbnail. This of course will make selection on groups not possible if pressing the thumbnail.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>