<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>406973</bug_id>
          
          <creation_ts>2019-04-27 14:24:41 +0000</creation_ts>
          <short_desc>Not possible to translate the ‘Reasons’ strings (for saving into non-Krita formats)</short_desc>
          <delta_ts>2019-08-15 07:53:50 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Translation</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Karl Ove Hufthammer">karl</reporter>
          <assigned_to name="Karl Ove Hufthammer">karl</assigned_to>
          <cc>halla</cc>
    
    <cc>tamtamy.tymona</cc>
          
          <cf_commitlink>https://invent.kde.org/kde/krita/commit/3dd45fdb1066042c59aa09cf014050a441c8ba47</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1853029</commentid>
    <comment_count>0</comment_count>
    <who name="Karl Ove Hufthammer">karl</who>
    <bug_when>2019-04-27 14:24:41 +0000</bug_when>
    <thetext>SUMMARY
It’s not possible to translate the three ‘Reason:/‘Reasons:’ strings, shown in the warning messages you get when trying to save an image into a non-Krita format.

ADDITIONAL INFORMATION
Here’s the relevant strings in the source code (KisImportExportManager.cpp, https://lxr.kde.org/source/extragear/graphics/krita/libs/ui/KisImportExportManager.cpp), AFAICS:

0482     if (!batchMode &amp;&amp; !errors.isEmpty()) {
0483         QString error =  &quot;&lt;html&gt;&lt;body&gt;&lt;p&gt;&lt;b&gt;&quot;
0484                 + i18n(&quot;Error: cannot save this image as a %1.&quot;, mimeUserDescription)
0485                 + &quot;&lt;/b&gt; Reasons:&lt;/p&gt;&quot;
0486                 + &quot;&lt;p/&gt;&lt;ul&gt;&quot;;
0487         Q_FOREACH(const QString &amp;w, errors) {
0488             error += &quot;\n&lt;li&gt;&quot; + w + &quot;&lt;/li&gt;&quot;;
0489         }

0526             QString warning = &quot;&lt;html&gt;&lt;body&gt;&lt;p&gt;&lt;b&gt;&quot;
0527                     + i18n(&quot;You will lose information when saving this image as a %1.&quot;, mimeUserDescription);
0528 
0529             if (warnings.size() == 1) {
0530                 warning += &quot;&lt;/b&gt; Reason:&lt;/p&gt;&quot;;
0531             }
0532             else {
0533                 warning += &quot;&lt;/b&gt; Reasons:&lt;/p&gt;&quot;;
0534             }
0535             warning += &quot;&lt;p/&gt;&lt;ul&gt;&quot;;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1853100</commentid>
    <comment_count>1</comment_count>
    <who name="Tiar">tamtamy.tymona</who>
    <bug_when>2019-04-27 20:51:31 +0000</bug_when>
    <thetext>Hey!

Basically, error messages in Krita are a one big mess. I&apos;m working on changing them to be more unified.

Please go to https://invent.kde.org/kde/krita/merge_requests/15 to see my sggestion of new error messages (that would replace the old ones, whatever the old ones were; and they were a lot of things...). There is a string freeze before May 1st, so I need to get it merged to master before that.

Please comment on the merge request if you have any suggestions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1853406</commentid>
    <comment_count>2</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2019-04-29 13:24:00 +0000</bug_when>
    <thetext>This is completely different from the error messages you get when saving, though: these are the warnings that are shown beforehand, and those warnings aren&apos;t a mess, but rather well designed and implemented :P</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1853407</commentid>
    <comment_count>3</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2019-04-29 13:25:04 +0000</bug_when>
    <thetext>No, I have to take that back... This isn&apos;t about that part of the code, sorry for being so confused.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874853</commentid>
    <comment_count>4</comment_count>
    <who name="Karl Ove Hufthammer">karl</who>
    <bug_when>2019-08-14 19:31:03 +0000</bug_when>
    <thetext>Git commit c091fce255d42f45e6add84451a64a5349941bd0 by Karl Ove Hufthammer.
Committed on 14/08/2019 at 19:30.
Pushed by huftis into branch &apos;master&apos;.

Make string for reasons for image export problems translatable

M  +3    -3    libs/ui/KisImportExportManager.cpp

https://invent.kde.org/kde/krita/commit/c091fce255d42f45e6add84451a64a5349941bd0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1874915</commentid>
    <comment_count>5</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2019-08-15 07:53:50 +0000</bug_when>
    <thetext>Git commit 3dd45fdb1066042c59aa09cf014050a441c8ba47 by Boudewijn Rempt, on behalf of Karl Ove Hufthammer.
Committed on 15/08/2019 at 07:46.
Pushed by rempt into branch &apos;krita/4.2&apos;.

Make string for reasons for image export problems translatable

M  +3    -3    libs/ui/KisImportExportManager.cpp

https://invent.kde.org/kde/krita/commit/3dd45fdb1066042c59aa09cf014050a441c8ba47</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>