<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>405935</bug_id>
          
          <creation_ts>2019-03-27 18:55:28 +0000</creation_ts>
          <short_desc>Allow people to change the name used for their reviews</short_desc>
          <delta_ts>2023-11-15 23:11:21 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>Discover</product>
          <component>discover</component>
          <version>5.14.5</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>HI</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nate Graham">nate</reporter>
          <assigned_to name="Dan Leinir Turthra Jensen">leinir</assigned_to>
          <cc>4wy78uwh</cc>
    
    <cc>aleixpol</cc>
          
          <cf_commitlink>https://invent.kde.org/plasma/discover/commit/ee3d6e9c912d901174a44fe96136583086cd6932</cf_commitlink>
          <cf_versionfixedin>5.26</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1847090</commentid>
    <comment_count>0</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2019-03-27 18:55:28 +0000</bug_when>
    <thetext>Right now it defaults to the name in their user account, which is a privacy violation in case they don&apos;t want to use their real name like that. We should make the name editable.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2148806</commentid>
    <comment_count>1</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2022-08-28 21:14:26 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/plasma/discover/-/merge_requests/362</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2149419</commentid>
    <comment_count>2</comment_count>
    <who name="Aleix Pol">aleixpol</who>
    <bug_when>2022-08-31 16:19:14 +0000</bug_when>
    <thetext>Git commit ee3d6e9c912d901174a44fe96136583086cd6932 by Aleix Pol Gonzalez, on behalf of Bernardo Gomes Negri.
Committed on 31/08/2022 at 16:19.
Pushed by apol into branch &apos;master&apos;.

Add option to change name in review dialog.

I only needed to change significantly the ODRS backend, since KNS appears to handle user names separately.

M  +7    -4    discover/qml/ReviewDialog.qml
M  +1    -1    discover/qml/ReviewsPage.qml
M  +30   -0    libdiscover/ReviewsBackend/AbstractReviewsBackend.cpp
M  +16   -5    libdiscover/ReviewsBackend/AbstractReviewsBackend.h
M  +2    -2    libdiscover/appstream/OdrsReviewsBackend.cpp
M  +8    -2    libdiscover/appstream/OdrsReviewsBackend.h
M  +2    -2    libdiscover/backends/DummyBackend/DummyReviewsBackend.cpp
M  +4    -1    libdiscover/backends/DummyBackend/DummyReviewsBackend.h
M  +1    -1    libdiscover/backends/KNSBackend/KNSReviews.cpp
M  +4    -2    libdiscover/backends/KNSBackend/KNSReviews.h

https://invent.kde.org/plasma/discover/commit/ee3d6e9c912d901174a44fe96136583086cd6932</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2266120</commentid>
    <comment_count>3</comment_count>
    <who name="Roke Julian Lockhart Beedell">4wy78uwh</who>
    <bug_when>2023-11-15 23:11:21 +0000</bug_when>
    <thetext>Is this still possible? I don&apos;t see any option to do so.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>