403384 2019-01-19 02:12:30 +0000 Previewing multiple wallpapers is slow 2022-06-29 03:10:27 +0000 1 1 4 Plasma plasmashell Image & Slideshow wallpaper plugins master unspecified All RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=398303 usability NOR wishlist 1.0 1 harogaston notmart bugseforuns kde mglb nate neilpadgett452 plasma-bugs-null qydwhotmail https://invent.kde.org/plasma/plasma-workspace/commit/18069a0f4a002830b7f66224ffdb17077346c2ee 5.26 0 oldest_to_newest 1833071 0 harogaston 2019-01-19 02:12:30 +0000 SUMMARY As a user I would like to be able to easily try/preview the different wallpapers from the Desktop Settings configuration dialog. STEPS TO REPRODUCE 1. Right-click on the desktop area. 2. Select "Configure desktop" 3. Select "Wallpaper" section 4. Select or hover over any wallpaper that is different from the current one. OBSERVED RESULT Nothing happens in the desktop. EXPECTED RESULT Desktop wallpaper should change accordingly to the currently hovered or last selected wallpaper image. SOFTWARE/OS VERSIONS KDE Plasma Version: 5.14.5 KDE Frameworks Version: 5.53.0 Qt Version: 5.12.0 ADDITIONAL INFORMATION Other popular Linux desktop environments offer this feature and it is really convenient to be able to preview various wallpapers like this, without the need to apply each one of them first. 1833282 1 nate 2019-01-20 02:30:49 +0000 This is basically a side effect of not using the instant-apply model. We're the only ones left with OK/Cancel/Apply buttons. One possible improvement might be if we implement Bug 398303. 1833283 2 harogaston 2019-01-20 02:40:14 +0000 I can do with OK/Cancel/Apply buttons. What I would like is that selecting a wallpaper would "soft apply it" but if you close or cancel the dialog then the selection is reverted and only if you click Apply/OK the selection persists. 1833380 3 kde 2019-01-20 16:22:33 +0000 >I can do with OK/Cancel/Apply buttons. Glad to hear it, I would be against instant apply, but this we can find some sort of compromise. The challenge with soft-apply is the communication aspect of what hitting cancel will do. Maybe that could be solved with a dialog on cancel: "you have unsaved changes [apply | cancel]" 1833385 4 nate 2019-01-20 16:55:37 +0000 Maybe we should temporarily apply the wallpaper when simply hovering over its delegate? Then you could move the mouse to quickly preview a bunch of wallpapers. 1833389 5 kde 2019-01-20 17:37:36 +0000 How would we include the "Positioning" combo box? 1833390 6 nate 2019-01-20 17:42:45 +0000 Yeah, feels like we're fighting the system with that idea. Since moving to instant-apply is not likely to happen any time soon, I think implementing Bug 398303 might be our best bet. I actually had this exact use case in mind when I opened that feature request. 1833400 7 kde 2019-01-20 18:14:14 +0000 That idea also wouldn't help with the positioning combo. 1833408 8 nate 2019-01-20 18:37:31 +0000 I think it might, actually: 1. Change item in positioning combobox 2. Double-click on a new image Result: new image is applied to the desktop with the positioning specified in the positioning combobox. 1833431 9 kde 2019-01-20 22:16:18 +0000 I think it's more likely a user would change the positioning / background colour to match the image you've just chosen than before. 1833432 10 nate 2019-01-20 22:26:23 +0000 Could be. This is just a hard problem to solve without implementing Instant Apply for the whole KCM or making the combobox and wallpaper chooser *visibly* apply their settings, but not *actually* apply them (which seems kinda weird). 1865631 11 mglb 2019-06-26 06:33:52 +0000 For example implementation see Konsole - it uses live preview & manual apply in Edit profile → Appearance dialog. 2127830 12 qydwhotmail 2022-05-30 16:37:00 +0000 Double click to apply wallpaper: https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1774 2127835 13 bug-janitor 2022-05-30 17:06:32 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/1785 2128533 14 bug-janitor 2022-06-02 15:28:40 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/969 2128613 15 nate 2022-06-02 18:52:24 +0000 Git commit 15110e1d2dde2fd48f57875a0fd198d7bb5ad6e0 by Nate Graham, on behalf of Fushan Wen. Committed on 02/06/2022 at 18:51. Pushed by ngraham into branch 'master'. desktoppackage: warn on cancel if there are unsaved settings When single click to preview wallpaper is enabled, it has the potential of confusing users. When they click on the image they might think the image is already applied and just close the window without hitting "apply". This could be solved if a window popped up asking users to apply if they try to close the window before applying, just like System Settings does. M +15 -3 desktoppackage/contents/configuration/AppletConfiguration.qml https://invent.kde.org/plasma/plasma-desktop/commit/15110e1d2dde2fd48f57875a0fd198d7bb5ad6e0 2128619 16 nate 2022-06-02 19:10:51 +0000 Git commit 18069a0f4a002830b7f66224ffdb17077346c2ee by Nate Graham, on behalf of Fushan Wen. Committed on 02/06/2022 at 18:52. Pushed by ngraham into branch 'master'. wallpapers/image: click image to preview FIXED-IN: 5.26 M +4 -0 wallpapers/image/imagepackage/contents/config/main.xml M +1 -0 wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml M +4 -0 wallpapers/image/imagepackage/contents/ui/config.qml M +11 -1 wallpapers/image/imagepackage/contents/ui/main.qml https://invent.kde.org/plasma/plasma-workspace/commit/18069a0f4a002830b7f66224ffdb17077346c2ee 2132273 17 bugseforuns 2022-06-17 17:14:48 +0000 *** Bug 455493 has been marked as a duplicate of this bug. *** 2135048 18 bug-janitor 2022-06-27 10:15:08 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-desktop/-/merge_requests/1006 2135694 19 nate 2022-06-29 03:10:27 +0000 Git commit 6bfef995d37e61b0e891f6eb4c8406b93c912e1b by Nate Graham, on behalf of Fushan Wen. Committed on 29/06/2022 at 03:09. Pushed by ngraham into branch 'master'. desktoppackage: warn on close if there are unsaved settings M +19 -6 desktoppackage/contents/configuration/AppletConfiguration.qml https://invent.kde.org/plasma/plasma-desktop/commit/6bfef995d37e61b0e891f6eb4c8406b93c912e1b