<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>403247</bug_id>
          
          <creation_ts>2019-01-15 18:54:12 +0000</creation_ts>
          <short_desc>Markdown backend: hyperlinks across multiple lines don&apos;t work</short_desc>
          <delta_ts>2019-01-29 17:36:20 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>okular</product>
          <component>general</component>
          <version>1.6.1</version>
          <rep_platform>Arch Linux</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter>destroyer2880</reporter>
          <assigned_to name="Okular developers">okular-devel</assigned_to>
          <cc>aacid</cc>
    
    <cc>nate</cc>
          
          <cf_commitlink>https://commits.kde.org/okular/27b76ee7c035b9f16452c56aa3ab997948ecfc7e</cf_commitlink>
          <cf_versionfixedin>19.04.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1832306</commentid>
    <comment_count>0</comment_count>
    <who name="">destroyer2880</who>
    <bug_when>2019-01-15 18:54:12 +0000</bug_when>
    <thetext>SUMMARY
With Okular&apos;s markdown backend, hyperlinks that are broken into multiple lines due to formatting appear as they should but are not clickable.

STEPS TO REPRODUCE
1. Open a markdown file in Okular that has hyperlinks with long names.
2. Find a hyperlink that starts on one line and ends on another.
3. Hover over said hyperlink.

OBSERVED RESULT
Hyperlink will not be clickable.

EXPECTED RESULT
Hyperlink should be clickable.

SOFTWARE/OS VERSIONS
Linux/KDE Plasma: 4.20.1-arch1-1-ARCH
KDE Plasma Version: 5.14.5
KDE Frameworks Version: 5.54.0
Qt Version: 5.12.0</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832337</commentid>
    <comment_count>1</comment_count>
    <who name="Albert Astals Cid">aacid</who>
    <bug_when>2019-01-15 21:32:53 +0000</bug_when>
    <thetext>Can you attach such a file?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832467</commentid>
    <comment_count>2</comment_count>
      <attachid>117489</attachid>
    <who name="">destroyer2880</who>
    <bug_when>2019-01-16 14:44:45 +0000</bug_when>
    <thetext>Created attachment 117489
Okular Link Test

I have created an example markdown file containing a link that works for me and a link that doesn&apos;t work for me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832493</commentid>
    <comment_count>3</comment_count>
    <who name="Albert Astals Cid">aacid</who>
    <bug_when>2019-01-16 18:06:06 +0000</bug_when>
    <thetext>Yep</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1832515</commentid>
    <comment_count>4</comment_count>
    <who name="Albert Astals Cid">aacid</who>
    <bug_when>2019-01-16 19:47:54 +0000</bug_when>
    <thetext>https://phabricator.kde.org/D18303</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1834673</commentid>
    <comment_count>5</comment_count>
    <who name="Albert Astals Cid">aacid</who>
    <bug_when>2019-01-28 21:09:37 +0000</bug_when>
    <thetext>Git commit 27b76ee7c035b9f16452c56aa3ab997948ecfc7e by Albert Astals Cid.
Committed on 28/01/2019 at 21:09.
Pushed by aacid into branch &apos;master&apos;.

TextDocumentGenerator: Support links that span more than one line

Summary:
If a link spans more than one line we need one rect for each of the lines

Subscribers: okular-devel

Tags: #okular

Differential Revision: https://phabricator.kde.org/D18303

M  +13   -0    core/area.cpp
M  +11   -0    core/area.h
M  +16   -7    core/textdocumentgenerator.cpp
M  +61   -0    core/textdocumentgenerator_p.h

https://commits.kde.org/okular/27b76ee7c035b9f16452c56aa3ab997948ecfc7e</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="0"
              isprivate="0"
          >
            <attachid>117489</attachid>
            <date>2019-01-16 14:44:45 +0000</date>
            <delta_ts>2019-01-16 14:44:45 +0000</delta_ts>
            <desc>Okular Link Test</desc>
            <filename>okular_test.md</filename>
            <type>text/markdown</type>
            <size>357</size>
            <attacher>destroyer2880</attacher>
            
              <data encoding="base64">W0hlcmUgaXMgYSBsaW5rIHRoYXQgd29ya3MuXShodHRwOi8va2RlLm9yZykKCltIZXJlIGlzIGEg
bGluayB0aGF0IGRvZXNuJ3Qgd29yayBiZWNhdXNlIGl0J3MgdG9vIGxvbmcgdG8gZml0IGluIG9u
ZSBsaW5lIGFuZCB0aGF0IHNjcmV3cyB3aXRoIE9rdWxhcidzIG1hcmtkb3duIGJhY2tlbmQgYW5k
IGtlZXBzIGl0IGZyb20gYmVpbmcgY2xpY2thYmxlLiAoSWYgdGhpcyBsaW5rIERPRVMgZml0IGlu
IG9uZSBsaW5lLCB5b3Ugc2hvdWxkIGluY3JlYXNlIHRoZSBmb250IHNpemUgaW4gdGhlIE1hcmtk
b3duIGJhY2tlbmQncyBzZXR0aW5ncyAoU2V0dGluZ3MgPiBDb25maWd1cmUgQmFja2VuZHMpKV0o
aHR0cDovL2tkZS5vcmcp
</data>

          </attachment>
      

    </bug>

</bugzilla>