402930 2019-01-06 15:58:40 +0000 After you use the image picker to change the background image, your chosen image appears in the picker, but disappears if you navigate away from the KCM and then go back 2019-02-05 16:31:39 +0000 1 1 2 Applications systemsettings kcm_sddm 5.14.4 Arch Linux Linux RESOLVED FIXED NOR normal --- 1 nate kde bugseforuns https://commits.kde.org/sddm-kcm/159e2dcbf935c1aa543a33b1865b6f4a986401e6 5.15.0 0 oldest_to_newest 1830673 0 nate 2019-01-06 15:58:40 +0000 SUMMARY STEPS TO REPRODUCE 1. Use the image picker to select an image 2. Apply 3. See that the image shows up in the image picker 4. Navigate somewhere else 5. Go back to the SDDM KCM OBSERVED RESULT The image picker shows a generic image EXPECTED RESULT The image picker should show the image you chose last time 1830745 1 kde 2019-01-06 21:46:50 +0000 Works here. After apply and go through all the kauth stuff? 1830750 2 nate 2019-01-06 21:58:45 +0000 Found the bug: it's storing the file path as just the filename, not the full path. Putting a full absolute file path in the Background= key in /usr/share/sddm/themes/breeze/theme.conf.user fixes the issue for me. Patch coming soon... 1830762 3 117312 nate 2019-01-06 23:32:55 +0000 Created attachment 117312 Prospective patch I might need a little help here, if you can spare the time. The attached patch fixes the issue in the KCM for me, but then SDDM doesn't load after a reboot, and I'm not really knowledgeable enough about how it works to figure out why. 1830852 4 nate 2019-01-07 11:38:42 +0000 Hmm, even putting an absolute path in /usr/share/sddm/themes/breeze/theme.conf.user without changing any code breaks login in the same way. 1830853 5 117326 nate 2019-01-07 11:39:48 +0000 Created attachment 117326 Patch take two This one might be a better approach but also breaks. 1835020 6 nate 2019-01-31 00:26:22 +0000 It turns out that the breakage I encountered while trying patches to fix this bug is a pre-existing issue that was not introduced with my patch: https://github.com/sddm/sddm/issues/1132 Both patches actually worked! 1835830 7 kde 2019-02-05 10:39:36 +0000 Git commit dc1922e6aa486500cb3d4cfeb0243bb2f5fdeb25 by David Edmundson. Committed on 05/02/2019 at 10:39. Pushed by davidedmundson into branch 'Plasma/5.15'. Fix loading of background image preview Summary: 50445f794b3142f29dcc043f3af83c549c694bcd changed how wallpapers worked. Instead of storing an absolute path in the config we move the file and saves a relative path. The preview icon still expected an absolute path. This patch loads the image in the same way SDDM expects. FIXED-IN: 5.15.0 Test Plan: Set image Reopened KCM Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D18614 M +6 -4 src/themeconfig.cpp M +1 -1 src/themeconfig.h https://commits.kde.org/sddm-kcm/dc1922e6aa486500cb3d4cfeb0243bb2f5fdeb25 1835831 8 kde 2019-02-05 10:39:36 +0000 Git commit 159e2dcbf935c1aa543a33b1865b6f4a986401e6 by David Edmundson. Committed on 05/02/2019 at 10:39. Pushed by davidedmundson into branch 'Plasma/5.15'. Fix mime type filter on background selection button Summary: Ported to explicit QFileDialog instance instead of static method partly because I don't understand how to use the magic nameFilter syntax to set mimes, partly to ease the eventual porting to QtQuick which can't have a blockign dialog. Test Plan: Clicked on the button Only image files were listed Selecting one still worked Reviewers: #plasma, ngraham Reviewed By: ngraham Subscribers: plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D18615 M +16 -5 src/configwidgets/selectimagebutton.cpp https://commits.kde.org/sddm-kcm/159e2dcbf935c1aa543a33b1865b6f4a986401e6 117312 2019-01-06 23:32:55 +0000 2019-01-06 23:32:55 +0000 Prospective patch 402930.patch text/plain 1057 nate ZGlmZiAtLWdpdCBhL3NyYy90aGVtZWNvbmZpZy5jcHAgYi9zcmMvdGhlbWVjb25maWcuY3BwCmlu ZGV4IGJjNWE1YjkuLmY4N2M2ZGQgMTAwNjQ0Ci0tLSBhL3NyYy90aGVtZWNvbmZpZy5jcHAKKysr IGIvc3JjL3RoZW1lY29uZmlnLmNwcApAQCAtMTYxLDYgKzE2MSw5IEBAIHZvaWQgVGhlbWVDb25m aWc6OmJhY2tncm91bmRDaGFuZ2VkKGNvbnN0IFFTdHJpbmcgJmltYWdlUGF0aCkKIHZvaWQgVGhl bWVDb25maWc6OnByZXBhcmVDb25maWd1cmF0aW9uVWkoY29uc3QgUVN0cmluZyAmY29uZmlnUGF0 aCkKIHsKICAgICBtVGhlbWVDb25maWdQYXRoID0gY29uZmlnUGF0aDsKKyAgICBjb25zdCBRU3Ry aW5nIHRoZW1lQ29uZmlnRGlyZWN0b3J5ID0gbVRoZW1lQ29uZmlnUGF0aC5yZW1vdmUoUVN0cmlu Z0xpdGVyYWwoInRoZW1lLmNvbmYiKSk7CisKKyAgICBxSW5mbygpIDw8ICJ0aGVtZUNvbmZpZ0Rp cmVjdG9yeSBpczogIiA8PCB0aGVtZUNvbmZpZ0RpcmVjdG9yeTsKIAogICAgIFFGaWxlIGNvbmZp Z0ZpbGUoY29uZmlnUGF0aCk7CiAgICAgCkBAIC0xNjksNyArMTcyLDcgQEAgdm9pZCBUaGVtZUNv bmZpZzo6cHJlcGFyZUNvbmZpZ3VyYXRpb25VaShjb25zdCBRU3RyaW5nICZjb25maWdQYXRoKQog ICAgICAgICB0aGVtZUNvbmZpZy0+YWRkQ29uZmlnU291cmNlcyh7Y29uZmlnRmlsZS5maWxlTmFt ZSgpfSk7CiAKICAgICAgICAgY29uZmlnVWktPmN1c3RvbWl6ZUJveC0+c2V0VmlzaWJsZSh0cnVl KTsKLSAgICAgICAgY29uZmlnVWktPnNlbGVjdEJhY2tncm91bmRCdXR0b24tPnNldEltYWdlUGF0 aCh0aGVtZUNvbmZpZy0+Z3JvdXAoIkdlbmVyYWwiKS5yZWFkRW50cnkoImJhY2tncm91bmQiKSk7 CisgICAgICAgIGNvbmZpZ1VpLT5zZWxlY3RCYWNrZ3JvdW5kQnV0dG9uLT5zZXRJbWFnZVBhdGgo dGhlbWVDb25maWdEaXJlY3RvcnkgKyB0aGVtZUNvbmZpZy0+Z3JvdXAoIkdlbmVyYWwiKS5yZWFk RW50cnkoImJhY2tncm91bmQiKSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgY29uZmlnVWktPmN1 c3RvbWl6ZUJveC0+c2V0VmlzaWJsZShmYWxzZSk7Cg== 117326 2019-01-07 11:39:48 +0000 2019-01-07 11:39:48 +0000 Patch take two 402930 take 2.patch text/plain 1411 nate ZGlmZiAtLWdpdCBhL3NyYy90aGVtZWNvbmZpZy5jcHAgYi9zcmMvdGhlbWVjb25maWcuY3BwCmlu ZGV4IGJjNWE1YjkuLmEzZWZiYTcgMTAwNjQ0Ci0tLSBhL3NyYy90aGVtZWNvbmZpZy5jcHAKKysr IGIvc3JjL3RoZW1lY29uZmlnLmNwcApAQCAtMTY1LDExICsxNjUsMjMgQEAgdm9pZCBUaGVtZUNv bmZpZzo6cHJlcGFyZUNvbmZpZ3VyYXRpb25VaShjb25zdCBRU3RyaW5nICZjb25maWdQYXRoKQog ICAgIFFGaWxlIGNvbmZpZ0ZpbGUoY29uZmlnUGF0aCk7CiAgICAgCiAgICAgaWYgKGNvbmZpZ0Zp bGUuZXhpc3RzKCkpIHsKKyAgICAgICAgcUluZm8oKSA8PCBjb25maWdGaWxlLmZpbGVOYW1lKCk7 CiAgICAgICAgIEtTaGFyZWRDb25maWdQdHIgdGhlbWVDb25maWcgPSBLU2hhcmVkQ29uZmlnOjpv cGVuQ29uZmlnKGNvbmZpZ0ZpbGUuZmlsZU5hbWUoKSArIFFTdHJpbmdMaXRlcmFsKCIudXNlciIp LCBLQ29uZmlnOjpDYXNjYWRlQ29uZmlnKTsKICAgICAgICAgdGhlbWVDb25maWctPmFkZENvbmZp Z1NvdXJjZXMoe2NvbmZpZ0ZpbGUuZmlsZU5hbWUoKX0pOwogCisgICAgICAgIGNvbnN0IFFTdHJp bmcgYmFja2dyb3VuZCA9IHRoZW1lQ29uZmlnLT5ncm91cCgiR2VuZXJhbCIpLnJlYWRFbnRyeSgi YmFja2dyb3VuZCIpOworICAgICAgICBRRmlsZSBiYWNrZ3JvdW5kRmlsZShiYWNrZ3JvdW5kKTsK KworICAgICAgICAvLyBJdCdzIGFuIGFic29sdXRlIHBhdGgsIGp1c3QgdXNlIGl0IGRpcmVjdGx5 CisgICAgICAgIGlmIChiYWNrZ3JvdW5kRmlsZS5leGlzdHMoKSkgeworICAgICAgICAgICAgY29u ZmlnVWktPnNlbGVjdEJhY2tncm91bmRCdXR0b24tPnNldEltYWdlUGF0aChiYWNrZ3JvdW5kKTsK KyAgICAgICAgLy8gSXQncyBhIHJlbGF0aXZlIHBhdGg7IHByZXBlbmQgdGhlIHByZWZpeCB3aGVu IHBhc3NpbmcgaXQgdG8gdGhlIHBpY2tlciBidXR0b24KKyAgICAgICAgfSBlbHNlIHsKKyAgICAg ICAgICAgIGNvbnN0IFFTdHJpbmcgcHJlZml4ID0gY29uZmlnVWktPnRoZW1lc0xpc3RWaWV3LT5j dXJyZW50SW5kZXgoKS5kYXRhKFRoZW1lc01vZGVsOjpQYXRoUm9sZSkudG9TdHJpbmcoKTsKKyAg ICAgICAgICAgIGNvbmZpZ1VpLT5zZWxlY3RCYWNrZ3JvdW5kQnV0dG9uLT5zZXRJbWFnZVBhdGgo cHJlZml4ICsgYmFja2dyb3VuZCk7CisgICAgICAgIH0KKwogICAgICAgICBjb25maWdVaS0+Y3Vz dG9taXplQm94LT5zZXRWaXNpYmxlKHRydWUpOwotICAgICAgICBjb25maWdVaS0+c2VsZWN0QmFj a2dyb3VuZEJ1dHRvbi0+c2V0SW1hZ2VQYXRoKHRoZW1lQ29uZmlnLT5ncm91cCgiR2VuZXJhbCIp LnJlYWRFbnRyeSgiYmFja2dyb3VuZCIpKTsKICAgICB9IGVsc2UgewogICAgICAgICBjb25maWdV aS0+Y3VzdG9taXplQm94LT5zZXRWaXNpYmxlKGZhbHNlKTsKICAgICB9Cg==