401894 2018-12-08 18:02:25 +0000 IMBD Rating not parsed from IMBD website 2019-01-05 02:06:07 +0000 1 1 2 Applications tellico general 3.1.3 Other Linux RESOLVED FIXED NOR normal --- 1 axela74 robby https://commits.kde.org/tellico/509d339f81d05a00e73d037102db20c56c8db42a 3.1.5 0 oldest_to_newest 1825264 0 axela74 2018-12-08 18:02:25 +0000 SUMMARY STEPS TO REPRODUCE 1. Search a film on IMBD 2. Select one result 3. Add element. In the database the IMDB rating field remains empty OBSERVED RESULT EXPECTED RESULT SOFTWARE/OS VERSIONS Windows: MacOS: Linux/KDE Plasma: (available in About System) KDE Plasma Version: KDE Frameworks Version: Qt Version: ADDITIONAL INFORMATION 1825311 1 robby 2018-12-09 02:43:18 +0000 The handful of searches I just did seemed to work correctly. Can you confirm that you have "IMDB Rating" checked in the IMDB data source settings to include in results? If you do, could you tell me a specific search and result that is failing? 1828189 2 axela74 2018-12-23 16:32:33 +0000 Sorry, I replied to the email but didn't add a comment on bugs.kde.org. I'll do it now. Yes, it's set. I tried to debug a bit the problem. I wrote the following lines after "bool ok;" (the line 1117 of imdbfetcher.cpp) myWarning() << ratingRx.cap(1) <<"\n"; myWarning() << ratingRx.cap(1).toFloat() <<"\n"; And for the film Mission Impossible Fallot ( https://www.imdb.com/title/tt4912910/?ref_=nv_sr_1 ) I get: "7,9" 0 I don't know why the number is 7,9 instead of 7.9. When I go directly to the imdb webpage I see only 7.9 Can this be a locale problem? My locale is set to italian/italy and here the numbers are written with the comma (7.9 -> 7,9) For the moment I fixed it with: QLocale italian(QLocale::Italian); float value = italian.toFloat(ratingRx.cap(1),&ok); 1828316 3 robby 2018-12-24 13:37:28 +0000 Ah, locale would explain it. Thanks for the follow-up details. I'll check into it. 1830396 4 robby 2019-01-05 02:06:07 +0000 Git commit 509d339f81d05a00e73d037102db20c56c8db42a by Robby Stephenson. Committed on 05/01/2019 at 02:01. Pushed by rstephenson into branch '3.1'. Fallback to user's locale for setting IMDB rating The IMDB fetcher assumed the decimal point would always be '.' which is obviously incorrect in many locales. While the IMDB website apparently always uses the period, fall back to using the default locale to convert to a float. FIXED-IN: 3.1.5 M +4 -0 ChangeLog M +3 -0 src/fetch/imdbfetcher.cpp M +7 -0 src/tests/imdbfetchertest.cpp M +1 -1 src/tests/tellicotest.config https://commits.kde.org/tellico/509d339f81d05a00e73d037102db20c56c8db42a