397932 2018-08-27 14:11:17 +0000 Cannot hold shift and make add selection while drawing a selection with bezier curve tool 2018-09-07 14:26:08 +0000 1 1 2 Applications krita Tools git master (please specify the git hash!) Other Linux RESOLVED FIXED NOR normal --- 1 raghu krita-bugs-null dimula73 freebox64 scottpetrovic https://commits.kde.org/krita/6739f46bb6388d7d139fa3bb7c4c046801752644 0 oldest_to_newest 1774467 0 raghu 2018-08-27 14:11:17 +0000 While drawing a selection with bezier selection, it is not possible to hold the shift key and add to the selection like other selection tools. While Holding shift and drawing a bezier curve the tool gets deactivated when you click the second node. To reproduce : 1. Open a new document 2. Draw a selection with bezier selection tool 3. Now hold shift and try to draw a new selection to add to the previous selection The result is when you click to add the second node, the tool gets deactivated and the first node is gone. 1774483 1 freebox64 2018-08-27 15:36:47 +0000 Yes, I can confirm the issue which affects only the "Bezier Curve Selection Tool" (tested with 4.2.0-pre-alpha (git 95e1b63) on Ubuntu 14.04). (A temporary workaround is to release the SHIFT key soon after the first click) 1774725 2 dimula73 2018-08-28 12:12:43 +0000 The problem is that in Curve tool is used as a "finish polygon" shortcut. Basically, it was invented to avoid double-clicking with a stylus, which is a really complicated operation. How should I fix this? Here are the options: 1) Remove Shift+click/"finish polygon" shortcut at all 2) Assign "finish polygon" to some other shortcut. Which one? 1774729 3 dimula73 2018-08-28 12:20:37 +0000 15:18 < raghukamath> dmitryK|log: i think pressing enter would be an alternative to complete selection instead of shift click 15:18 < raghukamath> which works now 15:19 < raghukamath> but i need to know deevad and scotts or Wolthera_laptop opinion on this 15:19 < raghukamath> since not providing shift is also a wrong thing, 15:20 < raghukamath> so if we remove shift click to complete , it won't take away any feature since pressing enter already is there 1774733 4 raghu 2018-08-28 12:31:25 +0000 Currently you can check the polygon selection tool and polygon tool, if it is a selection tool the polygon selection tool ignore the shift left click to complete and uses shift to activate add to selection. while if it is a polygon tool, it uses shift to complete the shape. I think bezier selection tool also should follow this paradigm, shift left click complete can be limited to bezier curve tool (where it shows this in tool tip too) but can be left out of the bezier curve selection tool, in the selection tool it can behave like all selection tool to add to selection when shift is held. So to summarise properly Remove shift + left click to complete from selection tool but keep it in normal bezier curve tool. this is the same behavior as polygon tool and polygon selection tool 1774735 5 scottpetrovic 2018-08-28 12:39:42 +0000 it seems odd that we have two different shortcuts for completing a selection 1. Shift + click 2. Enter We generally have Shift to be an addition modifier for selections, so it seems odd that we would ever use that for a "complete" action. I would say remove the Shift + click option. 1774741 6 raghu 2018-08-28 12:58:52 +0000 @ scott currently we have shift + left click to complete shape for only shape tools and not selection, so we can retain the behavior with the shape tools but remove it from selection tools. Example is how polygon tool and polygon selection tool works now. we need to follow this same thing for bezier selection and bezier curve tool. 1774774 7 dimula73 2018-08-28 15:15:59 +0000 Git commit fa65d03d27e70d9118445acef0350122ea888a18 by Dmitry Kazakov. Committed on 28/08/2018 at 15:05. Pushed by dkazakov into branch 'master'. Fix shift modifier in Curve Selection Tool The modifier of the point clicked the last should define the selection mode. For selection tools we just disable shift+click "path-close" shortcut of the base path tool M +10 -8 libs/basicflakes/tools/KoCreatePathTool.cpp M +2 -3 libs/basicflakes/tools/KoCreatePathTool.h M +3 -4 libs/basicflakes/tools/KoCreatePathTool_p.h M +1 -12 plugins/tools/selectiontools/kis_tool_select_path.cc M +0 -2 plugins/tools/selectiontools/kis_tool_select_path.h https://commits.kde.org/krita/fa65d03d27e70d9118445acef0350122ea888a18 1779450 8 halla 2018-09-07 14:26:08 +0000 Git commit 6739f46bb6388d7d139fa3bb7c4c046801752644 by Boudewijn Rempt, on behalf of Dmitry Kazakov. Committed on 07/09/2018 at 12:50. Pushed by rempt into branch 'krita/4.1'. Fix shift modifier in Curve Selection Tool The modifier of the point clicked the last should define the selection mode. For selection tools we just disable shift+click "path-close" shortcut of the base path tool M +10 -8 libs/basicflakes/tools/KoCreatePathTool.cpp M +2 -3 libs/basicflakes/tools/KoCreatePathTool.h M +3 -4 libs/basicflakes/tools/KoCreatePathTool_p.h M +1 -12 plugins/tools/selectiontools/kis_tool_select_path.cc M +0 -2 plugins/tools/selectiontools/kis_tool_select_path.h https://commits.kde.org/krita/6739f46bb6388d7d139fa3bb7c4c046801752644