<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>397092</bug_id>
          
          <creation_ts>2018-08-02 15:37:13 +0000</creation_ts>
          <short_desc>Retain prior search when KRunner is re-opened</short_desc>
          <delta_ts>2020-08-30 16:19:30 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>krunner</product>
          <component>general</component>
          <version>5.13.3</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>usability</keywords>
          <priority>NOR</priority>
          <bug_severity>wishlist</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Nate Graham">nate</reporter>
          <assigned_to name="Alexander Lohnau">alexander.lohnau</assigned_to>
          <cc>alexander.lohnau</cc>
    
    <cc>rwbarat</cc>
          
          <cf_commitlink>https://invent.kde.org/plasma/plasma-workspace/commit/ddd005b1f5bd802193d9393f68cf2bd1e01dee6d</cf_commitlink>
          <cf_versionfixedin>5.20</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1769942</commentid>
    <comment_count>0</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2018-08-02 15:37:13 +0000</bug_when>
    <thetext>It would be nice if KRunner remembered the previous search text when it&apos;s closed and re-opened. The previous search text shuold be selected so you can immediately start typing to replace it with a new search.

Reasons why this would be handy behavior:
- Lets you return to the results of a previous search if they would still be relevant (e.g. you searched for an item, opened one of the search results, then discovered that it wasn&apos;t the item you were looking for)
- Makes it easier to use KRunner as a calculator for complex expressions where you&apos;re updating the expression in response to data in another app (currently, interacting with the app closes KRunner and clears the mathematical expression you were working on)
- Allows you to use KRunner as a handy systemwide text field for the purpose of building up strings (sounds weird, but I use Spotlight for this all the time in macOS)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1943228</commentid>
    <comment_count>1</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2020-07-12 13:52:26 +0000</bug_when>
    <thetext>*** Bug 424121 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1943373</commentid>
    <comment_count>2</comment_count>
    <who name="Alexander Lohnau">alexander.lohnau</who>
    <bug_when>2020-07-13 08:08:06 +0000</bug_when>
    <thetext>Super interesting idea!

Although I am against setting this behavior by default, because this would lead to the case where we run a query with the last term. This is contrary to the the current workflow of KRunner which only shows results when explicitly asked for. Also this would feel like a big visual change for the users. Maybe we can make this an option in the KCM.

PS: Also there have been quite a few feature request to add more options for the
KRunner UI. Because of that I had the idea of adding an &quot;Advanced&quot; expandable section to the KCM, but that might be a VDG discussion for another time :-).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1943583</commentid>
    <comment_count>3</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2020-07-13 21:20:29 +0000</bug_when>
    <thetext>(In reply to Alexander Lohnau from comment #2)
&gt; Super interesting idea!
&gt; 
&gt; Although I am against setting this behavior by default, because this would
&gt; lead to the case where we run a query with the last term. This is contrary
&gt; to the the current workflow of KRunner which only shows results when
&gt; explicitly asked for. Also this would feel like a big visual change for the
&gt; users. Maybe we can make this an option in the KCM.
We could probably change it to not run a new query when it&apos;s shown but there&apos;s already search text in the text field, FWIW.

&gt; PS: Also there have been quite a few feature request to add more options for
&gt; the
&gt; KRunner UI. Because of that I had the idea of adding an &quot;Advanced&quot;
&gt; expandable section to the KCM, but that might be a VDG discussion for
&gt; another time :-).
Not sure we explicitly need an &quot;Advanced&quot; section, but I wouldn&apos;t be averse to judiciously adding some more options if needed.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1952752</commentid>
    <comment_count>4</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2020-08-24 10:48:27 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/226</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1954100</commentid>
    <comment_count>5</comment_count>
    <who name="Alexander Lohnau">alexander.lohnau</who>
    <bug_when>2020-08-30 16:19:30 +0000</bug_when>
    <thetext>Git commit ddd005b1f5bd802193d9393f68cf2bd1e01dee6d by Alexander Lohnau.
Committed on 30/08/2020 at 16:19.
Pushed by alex into branch &apos;master&apos;.

Add option to retain prior search
FIXED-IN: 5.20

M  +11   -1    krunner/view.cpp
M  +5    -0    krunner/view.h
M  +14   -2    lookandfeel/contents/runcommand/RunCommand.qml

https://invent.kde.org/plasma/plasma-workspace/commit/ddd005b1f5bd802193d9393f68cf2bd1e01dee6d</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>