<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>396211</bug_id>
          
          <creation_ts>2018-07-05 17:01:16 +0000</creation_ts>
          <short_desc>Plot summary does not alway work</short_desc>
          <delta_ts>2018-08-25 00:34:09 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>tellico</product>
          <component>general</component>
          <version>3.1.2</version>
          <rep_platform>Arch Linux</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Joachim">joschae</reporter>
          <assigned_to name="Robby Stephenson">robby</assigned_to>
          
          
          <cf_commitlink>https://commits.kde.org/tellico/714874e03c610682b3e84192a2f61297a6fcab75</cf_commitlink>
          <cf_versionfixedin>3.1.3</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1765507</commentid>
    <comment_count>0</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-05 17:01:16 +0000</bug_when>
    <thetext>Hello, 
I&apos;ve got the problem that the plot summary isn&apos;t always transfered correctly from Amazon to Tellico. 

Example: https://www.amazon.de/dp/B0143R4K24 (The Diabolical Blu Ray) shows &quot;Das Haus der Familie Heller wird jede Nacht von unheimlichen...&quot; as &quot;Produktbeschreibung&quot; but adding this film to tellico the plot summary is &quot;Besonderheiten: FSK 16 Jahre&quot;. This doesn&apos;t match. 

Thanks for help</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1765977</commentid>
    <comment_count>1</comment_count>
    <who name="Robby Stephenson">robby</who>
    <bug_when>2018-07-09 00:50:43 +0000</bug_when>
    <thetext>Is this just for amazon.de? I don&apos;t have a current access ID for Amazon Germany to test...

Could you possibly go to https://webservices.amazon.com/scratchpad/index.html# Select ItemSearch on the left, change marketplace to Germany, enter all your information, along with the search term (such as Diabolical) in the keyword box, and do &quot;Run Request&quot; ? If that works, inside the Response box, select the &quot;XML&quot; tab and either comment here (remove your access information first) or email to me directly..</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1766053</commentid>
    <comment_count>2</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-09 15:35:21 +0000</bug_when>
    <thetext>Emaild just two examples directly to you</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1767076</commentid>
    <comment_count>3</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-15 15:38:58 +0000</bug_when>
    <thetext>Hi, 
I think the plot can be in two segments of the XML structure. I did the following changes in amazon2tellico.xsl: 

   &lt;xsl:when test=&quot;$mode=&apos;Video&apos;&quot;&gt;
    &lt;plot&gt;
     &lt;xsl:value-of select=&quot;aws:EditorialReviews/aws:EditorialReview[1]/aws:Content&quot;/&gt;
    &lt;/plot&gt;


Changed it to 

   &lt;xsl:when test=&quot;$mode=&apos;Video&apos;&quot;&gt;
    &lt;plot&gt;
     &lt;xsl:value-of select=&quot;aws:EditorialReviews/aws:EditorialReview[2]/aws:Content&quot;/&gt;
     &lt;xsl:value-of select=&quot;aws:EditorialReviews/aws:EditorialReview[1]/aws:Content&quot;/&gt;
    &lt;/plot&gt;

And now I can get both plots. Is there a possibility to add e.g. linebreak between the two plots? I tried it with &lt;br&gt; but this did not help.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1767134</commentid>
    <comment_count>4</comment_count>
    <who name="Robby Stephenson">robby</who>
    <bug_when>2018-07-16 00:41:02 +0000</bug_when>
    <thetext>(In reply to Joachim from comment #3)
&gt; Hi, 
&gt; I think the plot can be in two segments of the XML structure. I did the
&gt; following changes in amazon2tellico.xsl: 
&gt; 
&gt;    &lt;xsl:when test=&quot;$mode=&apos;Video&apos;&quot;&gt;
&gt;     &lt;plot&gt;
&gt;      &lt;xsl:value-of
&gt; select=&quot;aws:EditorialReviews/aws:EditorialReview[1]/aws:Content&quot;/&gt;
&gt;     &lt;/plot&gt;
&gt; 
&gt; 
&gt; Changed it to 
&gt; 
&gt;    &lt;xsl:when test=&quot;$mode=&apos;Video&apos;&quot;&gt;
&gt;     &lt;plot&gt;
&gt;      &lt;xsl:value-of
&gt; select=&quot;aws:EditorialReviews/aws:EditorialReview[2]/aws:Content&quot;/&gt;
&gt;      &lt;xsl:value-of
&gt; select=&quot;aws:EditorialReviews/aws:EditorialReview[1]/aws:Content&quot;/&gt;
&gt;     &lt;/plot&gt;
&gt; 
&gt; And now I can get both plots. Is there a possibility to add e.g. linebreak
&gt; between the two plots? I tried it with &lt;br&gt; but this did not help.

Try this:

    &lt;plot&gt;
     &lt;xsl:if test=&quot;aws:EditorialReviews/aws:EditorialReview[2]&quot;&gt;
      &lt;xsl:value-of select=&quot;aws:EditorialReviews/aws:EditorialReview[2]/aws:Content&quot;/&gt;
      &lt;xsl:text&gt;&amp;#10;&lt;/xsl:text&gt; &lt;!-- newline character --&gt;
     &lt;/xsl:if&gt;
     &lt;xsl:value-of select=&quot;aws:EditorialReviews/aws:EditorialReview[1]/aws:Content&quot;/&gt;
    &lt;/plot&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1767142</commentid>
    <comment_count>5</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-16 07:05:58 +0000</bug_when>
    <thetext>Thank you! But

      &lt;xsl:text&gt;&amp;#10;&lt;/xsl:text&gt; &lt;!-- newline character --&gt;

did not work for me. It perfectly inserts a new line in the plot at &quot;change entry&quot; but this linebreak is not shown in the main window. I played a bit around and 

     &lt;xsl:text&gt;&lt;![CDATA[&lt;p&gt;]]&gt;&lt;/xsl:text&gt;

helped.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1767171</commentid>
    <comment_count>6</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-16 09:07:40 +0000</bug_when>
    <thetext>(In reply to Joachim from comment #5)
&gt; Thank you! But
&gt; 
&gt;       &lt;xsl:text&gt;&amp;#10;&lt;/xsl:text&gt; &lt;!-- newline character --&gt;
&gt; 
&gt; did not work for me. It perfectly inserts a new line in the plot at &quot;change
&gt; entry&quot; but this linebreak is not shown in the main window. I played a bit
&gt; around and 
&gt; 
&gt;      &lt;xsl:text&gt;&lt;![CDATA[&lt;p&gt;]]&gt;&lt;/xsl:text&gt;
&gt; 
&gt; helped.


How can I use custom fields and update it with Amazon data? I created a cusotm field named &quot;EAN&quot; in Tellico. The EAN code is submitted in the XML structure from Amazon. How to update the cusom field with the content of the according XML element? Nothing I tried did work.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1767298</commentid>
    <comment_count>7</comment_count>
    <who name="Robby Stephenson">robby</who>
    <bug_when>2018-07-17 01:47:12 +0000</bug_when>
    <thetext>(In reply to Joachim from comment #6)
&gt; How can I use custom fields and update it with Amazon data? I created a
&gt; cusotm field named &quot;EAN&quot; in Tellico. The EAN code is submitted in the XML
&gt; structure from Amazon. How to update the cusom field with the content of the
&gt; according XML element? Nothing I tried did work.

With your collection that has the custom EAN field in it, export to an XML and find the &lt;field .. title=&quot;EAN&quot; ... &gt; line in it. Copy that to your amazon2tellico.xsl file up in the beginning within the &lt;fields&gt; element. Then add 
&lt;ean&gt;&lt;xsl:value-of select=&quot;[whatever the EAN element is in the XML from Amazon]&quot;&gt;&lt;/ean&gt; somewhere in the Item template.

Does that make sense?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1767565</commentid>
    <comment_count>8</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-18 17:14:45 +0000</bug_when>
    <thetext>Got it, thank you! 

Also did some German related optimization (e.g. the FSK rating). 

Except that the plot isn&apos;t available via Amazon sometimes (I checked it with the scratchpad) all works like a charm and I was able to learn some XSLT :-) 

I think you can close this Bug because it really isn&apos;t one. Perhups you can overtake the changes to the plot element in a future version. 

Thanks for your great support!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769456</commentid>
    <comment_count>9</comment_count>
    <who name="Joachim">joschae</who>
    <bug_when>2018-07-30 11:49:09 +0000</bug_when>
    <thetext>A further question to entry update via Amazon: what&apos;s the search criteria? Can I change it?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1769854</commentid>
    <comment_count>10</comment_count>
    <who name="Robby Stephenson">robby</who>
    <bug_when>2018-08-02 03:13:51 +0000</bug_when>
    <thetext>(In reply to Joachim from comment #9)
&gt; A further question to entry update via Amazon: what&apos;s the search criteria?
&gt; Can I change it?

For books, it uses the ISBN if possible, followed by a title/author or title/artist search, followed by just title, and then tries to choose the best match out of all those.

It&apos;s not changeable without editing the code and recompiling.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1774131</commentid>
    <comment_count>11</comment_count>
    <who name="Robby Stephenson">robby</who>
    <bug_when>2018-08-25 00:30:22 +0000</bug_when>
    <thetext>(In reply to Joachim from comment #8)
&gt; Got it, thank you! 
&gt; 
&gt; Also did some German related optimization (e.g. the FSK rating). 
&gt; 
&gt; Except that the plot isn&apos;t available via Amazon sometimes (I checked it with
&gt; the scratchpad) all works like a charm and I was able to learn some XSLT :-) 
&gt; 
&gt; I think you can close this Bug because it really isn&apos;t one. Perhups you can
&gt; overtake the changes to the plot element in a future version. 
&gt; 
&gt; Thanks for your great support!

I&apos;m interested in improving the FSK support. If you can send me or post them here, I&apos;ll include them in next release.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1774132</commentid>
    <comment_count>12</comment_count>
    <who name="Robby Stephenson">robby</who>
    <bug_when>2018-08-25 00:34:09 +0000</bug_when>
    <thetext>Git commit 714874e03c610682b3e84192a2f61297a6fcab75 by Robby Stephenson.
Committed on 25/08/2018 at 00:33.
Pushed by rstephenson into branch &apos;3.1&apos;.

Include multiple content elements from Amazon fetcher for movie plots
FIXED-IN: 3.1.3

M  +4    -0    ChangeLog
M  +6    -1    xslt/amazon2tellico.xsl

https://commits.kde.org/tellico/714874e03c610682b3e84192a2f61297a6fcab75</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>