<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>396064</bug_id>
          
          <creation_ts>2018-07-01 19:43:06 +0000</creation_ts>
          <short_desc>Restore defaults button resets to the previous saved setting and not the actual default settings</short_desc>
          <delta_ts>2022-04-28 15:25:55 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Shortcuts and Canvas Input Settings</component>
          <version>4.1.0 beta</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antti Savolainen">antti.savo</reporter>
          <assigned_to name="Krita Bugs">krita-bugs-null</assigned_to>
          <cc>1012468643</cc>
    
    <cc>halla</cc>
    
    <cc>tamtamy.tymona</cc>
          
          <cf_commitlink>https://invent.kde.org/graphics/krita/commit/f5bf73f98491fb01949b09285a54b92c05b93059</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1764751</commentid>
    <comment_count>0</comment_count>
    <who name="Antti Savolainen">antti.savo</who>
    <bug_when>2018-07-01 19:43:06 +0000</bug_when>
    <thetext>Video visualization: https://youtu.be/Z5ODitlqHU0

Steps to reproduce:
Open settings
Select &apos;Canvas Input Settings&apos;
Open &apos;Show Popup Palette&apos; (I haven&apos;t tested any other setting)
Add a shortcut and save
Go back to that setting and Restore Defaults
Delete the new binding and try Restore Defaults again

Expected behavior: Only Right button should be left in the binding

Actual behavior: The last saved setting gets restored

Build &amp; Platform:
    krita 4.2.0-pre-alpha
    Xubuntu 17.10</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1976726</commentid>
    <comment_count>1</comment_count>
    <who name="Tiar">tamtamy.tymona</who>
    <bug_when>2020-11-19 16:02:42 +0000</bug_when>
    <thetext>Note for a developer: see that there is also an option to reset configuration from Settings -&gt; Reset Krita Configurations . I think it would be good to just rename this one as &quot;Restore Previous&quot;? (Reset Krita Configurations does something that might not be visible from the dialog, because it also resets the workspace etc.).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2115281</commentid>
    <comment_count>2</comment_count>
    <who name="sh_zam">shzam</who>
    <bug_when>2022-04-04 08:32:38 +0000</bug_when>
    <thetext>Git commit c14d3bbdc2301c24ccf74186f654172ff40dc26a by Sharaf Zaman.
Committed on 04/04/2022 at 08:32.
Pushed by szaman into branch &apos;master&apos;.

Bugfix: Restore Defaults doesn&apos;t work properly in Canvas Input Settings

Reason of the bug being, profileDir.entryList() returned an empty list.

M  +1    -1    libs/ui/input/config/kis_input_configuration_page.cpp

https://invent.kde.org/graphics/krita/commit/c14d3bbdc2301c24ccf74186f654172ff40dc26a</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2116721</commentid>
    <comment_count>3</comment_count>
    <who name="sh_zam">shzam</who>
    <bug_when>2022-04-11 09:11:37 +0000</bug_when>
    <thetext>Git commit f5bf73f98491fb01949b09285a54b92c05b93059 by Sharaf Zaman.
Committed on 11/04/2022 at 09:11.
Pushed by szaman into branch &apos;krita/5.0&apos;.

Bugfix: Restore Defaults doesn&apos;t work properly in Canvas Input Settings

Reason of the bug being, profileDir.entryList() returned an empty list.
(cherry picked from commit c14d3bbdc2301c24ccf74186f654172ff40dc26a)

M  +1    -1    libs/ui/input/config/kis_input_configuration_page.cpp

https://invent.kde.org/graphics/krita/commit/f5bf73f98491fb01949b09285a54b92c05b93059</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2120060</commentid>
    <comment_count>4</comment_count>
    <who name="Eranthis stellata Maxim">1012468643</who>
    <bug_when>2022-04-28 15:25:55 +0000</bug_when>
    <thetext>*** Bug 450483 has been marked as a duplicate of this bug. ***</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>