395609 2018-06-19 13:59:06 +0000 New Text File is created with 600 (-rw-------) permissions 2019-10-24 18:21:08 +0000 1 1 2 Applications krusader general 2.7.0 Other Linux RESOLVED FIXED triaged NOR normal --- 1 gbophuk_alt alex.bikadorov alex.bikadorov bb0072 krusader-bugs-null nikita+kde toni.asensi vercha https://commits.kde.org/krusader/262a96c795c702c7568803b64d3c67df9625364e 0 oldest_to_newest 1762293 0 gbophuk_alt 2018-06-19 13:59:06 +0000 KDE Frameworks 5.46.0 QT 5.9.4 Krusader 2.7.0 Reproducing: Open fro menu File -> New Text File What we get: New file with 600 permissions What we expect: New File with 644 permissions like in Dolphin 1762472 1 nikita+kde 2018-06-20 07:36:15 +0000 I confirm on my end. Same for Shift+F4. Permissions should be the same as when you touch the file and depend on umask setting. 1762496 2 toni.asensi 2018-06-20 10:52:10 +0000 Confirmed using Kubuntu 18.04; this doesn't happen when creating folders, by the way. 1833851 3 vercha 2019-01-23 12:52:58 +0000 kde5-krusader-2.7.1 Bug is still actual 1838654 4 alex.bikadorov 2019-02-17 16:30:02 +0000 Heck! I cannot find out why it's not working. It should done by krusader/Panel/panelfunc.cpp:522 > KIO::CopyJob *job = KIO::copy(QUrl::fromLocalFile(tempFile->fileName()), > job->setDefaultPermissions(true); The same way it is done by KIO for Dolphin filewidgets/knewfilemenu.cpp:615 > KIO::CopyJob *job = KIO::copyAs(uSrc, dest); > job->setDefaultPermissions(true); 1838818 5 gbophuk_alt 2019-02-18 13:42:22 +0000 Maybe you should write a test app? Also I couldn't find what the default permission are in the kio docs. 1838915 6 nikita+kde 2019-02-18 18:57:12 +0000 Alex, the problem is not with the KIO::copy code. It's QTemporaryFile which is created with the restricted permissions. I think we should refactor the code and possibly remove the QTemporaryFile calls. I'm not yet sure how to deal with remote file systems. Another option is not creating a file and let editor save it. I checked that it saves with proper permissions. 1840234 7 alex.bikadorov 2019-02-24 15:28:09 +0000 You're right Nikita, I missed that. But this means that KIO::CopyJob::setDefaultPermissions() is not working. The documentation says it for exactly this use case - having umask applied when copying temporary files. And AFAIK there is no way to create a file with KIO (KIO::open() seems to be only for opening existing files). All KIO code I have seen also uses the way to copy already existing files to a final destination. 1840246 8 alex.bikadorov 2019-02-24 16:04:35 +0000 A patch that sets the permissions to 644 until the bug in KIO is fixed: https://phabricator.kde.org/D19277 1841280 9 nikita+kde 2019-03-02 07:34:54 +0000 I checked KIO::CopyJob::setDefaultPermissions and follow up code and this piece looks suspicious: filecopyjob.cpp: 501 if (d->m_mustChmod) { 502 // If d->m_permissions == -1, keep the default permissions 503 if (d->m_permissions != -1) { 504 d->m_chmodJob = chmod(d->m_dest, d->m_permissions); 505 addSubjob(d->m_chmodJob); 506 } 507 d->m_mustChmod = false; 508 } Haven't debugged though since KIO likely requires special debugging environment but according to the code (d->m_permissions == -1) is exactly happens after we call setDefaultPermissions and then chmod is never called. So far I think the best way is to handle local files differently and create them with QFile to get the default permissions. The downside is that it should be handled carefully given the async nature of that code. Probably, we should look more into the Dolphin code. They get around it somehow. 1842758 10 alex.bikadorov 2019-03-08 19:42:29 +0000 Fixed with commit dce5c5057c85a2d42e161f0dbd2dc6cd26c17a32. Bug 404777 in KIO is still open. 1866469 11 nikita+kde 2019-07-01 07:19:53 +0000 Git commit 262a96c795c702c7568803b64d3c67df9625364e by Nikita Melnichenko. Committed on 01/07/2019 at 07:10. Pushed by melnichenko into branch 'stable'. Fixed new file permissions Combined and adapted the following commits from master: dce5c5057c85a2d42e161f0dbd2dc6cd26c17a32 c6db82bcb2d61e34e1c8bfb87aade25c7fed9093 FIXED: [ 395609 ] New Text File is created with 600 (-rw-------) permissions Differential Revision: https://phabricator.kde.org/D19277 M +3 -6 krusader/Panel/listpanel.cpp M +1 -1 krusader/Panel/listpanel.h M +2 -3 krusader/Panel/listpanelactions.cpp M +2 -2 krusader/Panel/listpanelactions.h M +2 -11 krusader/Panel/panelcontextmenu.cpp M +0 -2 krusader/Panel/panelcontextmenu.h M +53 -41 krusader/Panel/panelfunc.cpp M +4 -4 krusader/Panel/panelfunc.h https://commits.kde.org/krusader/262a96c795c702c7568803b64d3c67df9625364e 1887580 12 alex.bikadorov 2019-10-24 18:21:08 +0000 *** Bug 413389 has been marked as a duplicate of this bug. ***