<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>395324</bug_id>
          
          <creation_ts>2018-06-13 16:35:33 +0000</creation_ts>
          <short_desc>QQC2.StackView does not respect the global animation speed</short_desc>
          <delta_ts>2022-06-10 16:24:42 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>Breeze</product>
          <component>QStyle</component>
          <version>5.13.90</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          <see_also>https://bugs.kde.org/show_bug.cgi?id=426770</see_also>
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>junior-jobs</keywords>
          <priority>NOR</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Christoph Feck">cfeck</reporter>
          <assigned_to name="Plasma Bugs List">plasma-bugs-null</assigned_to>
          <cc>kde</cc>
    
    <cc>nate</cc>
    
    <cc>noahadvs</cc>
    
    <cc>plasma-bugs-null</cc>
    
    <cc>qydwhotmail</cc>
    
    <cc>uhhadd</cc>
          
          <cf_commitlink>https://invent.kde.org/frameworks/qqc2-desktop-style/commit/ae1606281c35e0fcd6cea0cbee3a4f1120952c07</cf_commitlink>
          <cf_versionfixedin>5.96</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1760913</commentid>
    <comment_count>0</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2018-06-13 16:35:33 +0000</bug_when>
    <thetext>Steps to reproduce:
- Add &quot;[Units] longDuration=0&quot; to plasmarc
- Right-click desktop &gt; Configure Desktop &gt; Wallpaper
- Switch between different &quot;Wallpaper Type&quot; modes

Actual result:
- The configuration pages slide in and out

Expected result:
- The configuration pages just switch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1764840</commentid>
    <comment_count>1</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2018-07-02 08:24:32 +0000</bug_when>
    <thetext>Wallpaper slideshow has it&apos;s own duration in its config due to reason in another bug report.


I don&apos;t know how we can merge the two things in a sane way</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1782863</commentid>
    <comment_count>2</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2018-09-20 00:22:19 +0000</bug_when>
    <thetext>Note that this ticket is about the dialog animations, not the actual slideshow transitions.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1788575</commentid>
    <comment_count>3</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2018-09-27 02:43:43 +0000</bug_when>
    <thetext>My initial investigation: The wallpaper configuration dialog[1] uses QtControls StackView for the different pages. According to its documentation[2], pushing/popping a page causes transition animations. These can be customized; the documentation shows some examples with customized &apos;duration&apos; property, so it should be possible to use the Plasma global animation duration for these.

[1] https://cgit.kde.org/plasma-desktop.git/tree/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
[2] http://doc.qt.io/qt-5/qml-qtquick-controls-stackview.html</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1791127</commentid>
    <comment_count>4</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2018-10-01 23:08:15 +0000</bug_when>
    <thetext>We can control the animation speed, and in fact we do already.

The issue is that slideshow has it&apos;s own config option for duration as it was decided it needed to be slower. Understanding how to have two config options control the same thing is the problem</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1791130</commentid>
    <comment_count>5</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2018-10-01 23:18:28 +0000</bug_when>
    <thetext>David, comment #2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1887166</commentid>
    <comment_count>6</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2019-10-22 17:45:44 +0000</bug_when>
    <thetext>The same StackView animations are now also in the kscreen KCM (switching between monitors). Should I report it separately?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1887224</commentid>
    <comment_count>7</comment_count>
    <who name="David Edmundson">kde</who>
    <bug_when>2019-10-22 21:47:12 +0000</bug_when>
    <thetext>You&apos;re right I hadn&apos;t read #2 properly, sorry.

We need two parts:
 - breeze to follow the global animation speed

 - qqc2-desktop-theme to follow the qstyle in stackviews

Maybe that should be two bugs, I don&apos;t think we need one on the symptoms in kscreen.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1962704</commentid>
    <comment_count>8</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2020-10-05 20:06:31 +0000</bug_when>
    <thetext>Should follow the global speed now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1962705</commentid>
    <comment_count>9</comment_count>
    <who name="Nate Graham">nate</who>
    <bug_when>2020-10-05 20:09:00 +0000</bug_when>
    <thetext>Never mind, I also mis-read. The dialog itself now respects the global animation speed scale.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2129123</commentid>
    <comment_count>10</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2022-06-05 14:01:20 +0000</bug_when>
    <thetext>The issue persists. While recent animations in the Places panel where fixed, this one remains animating. Animation speed slider is set to &quot;Instant&quot;.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2130236</commentid>
    <comment_count>11</comment_count>
    <who name="Fushan Wen">qydwhotmail</who>
    <bug_when>2022-06-10 02:03:33 +0000</bug_when>
    <thetext>Git commit 8df97ad32394500af9e1195048e5121a1b9c9adc by Fushan Wen.
Committed on 10/06/2022 at 02:02.
Pushed by fusionfuture into branch &apos;master&apos;.

wallpapers/image: follow system animation speed setting in wallpaper transition

The value is to keep compatible with the old feeling defined by
&quot;TransitionAnimationDuration&quot; (default: 1000)
FIXED-IN: 5.26

M  +0    -4    wallpapers/image/imagepackage/contents/config/main.xml
M  +4    -2    wallpapers/image/imagepackage/contents/ui/main.qml
M  +0    -4    wallpapers/image/slideshowpackage/contents/config/main.xml

https://invent.kde.org/plasma/plasma-workspace/commit/8df97ad32394500af9e1195048e5121a1b9c9adc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2130237</commentid>
    <comment_count>12</comment_count>
    <who name="Fushan Wen">qydwhotmail</who>
    <bug_when>2022-06-10 02:03:41 +0000</bug_when>
    <thetext>Git commit 8df97ad32394500af9e1195048e5121a1b9c9adc by Fushan Wen.
Committed on 10/06/2022 at 02:02.
Pushed by fusionfuture into branch &apos;master&apos;.

wallpapers/image: follow system animation speed setting in wallpaper transition

The value is to keep compatible with the old feeling defined by
&quot;TransitionAnimationDuration&quot; (default: 1000)
FIXED-IN: 5.26

M  +0    -4    wallpapers/image/imagepackage/contents/config/main.xml
M  +4    -2    wallpapers/image/imagepackage/contents/ui/main.qml
M  +0    -4    wallpapers/image/slideshowpackage/contents/config/main.xml

https://invent.kde.org/plasma/plasma-workspace/commit/8df97ad32394500af9e1195048e5121a1b9c9adc</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2130278</commentid>
    <comment_count>13</comment_count>
    <who name="Christoph Feck">cfeck</who>
    <bug_when>2022-06-10 07:44:57 +0000</bug_when>
    <thetext>Please read comment #2.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2130290</commentid>
    <comment_count>14</comment_count>
    <who name="Fushan Wen">qydwhotmail</who>
    <bug_when>2022-06-10 09:10:46 +0000</bug_when>
    <thetext>Sorry, but I guess it has nothing to do with Image Wallpaper because it&apos;s a StackView with the default animation settings</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2130301</commentid>
    <comment_count>15</comment_count>
    <who name="Bug Janitor Service">bug-janitor</who>
    <bug_when>2022-06-10 09:38:33 +0000</bug_when>
    <thetext>A possibly relevant merge request was started @ https://invent.kde.org/frameworks/qqc2-desktop-style/-/merge_requests/158</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>2130402</commentid>
    <comment_count>16</comment_count>
    <who name="Fushan Wen">qydwhotmail</who>
    <bug_when>2022-06-10 16:24:42 +0000</bug_when>
    <thetext>Git commit ae1606281c35e0fcd6cea0cbee3a4f1120952c07 by Fushan Wen.
Committed on 10/06/2022 at 16:21.
Pushed by fusionfuture into branch &apos;master&apos;.

Make StackView obey the global animation speed setting

Use `Kirigami.Units.veryLongDuration` instead of 400.
FIXED-IN: 5.96

A  +108  -0    org.kde.desktop/StackView.qml     [License: GPL(v2.0+) LGPL(v3.0)]

https://invent.kde.org/frameworks/qqc2-desktop-style/commit/ae1606281c35e0fcd6cea0cbee3a4f1120952c07</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>