<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>392559</bug_id>
          
          <creation_ts>2018-03-31 12:25:04 +0000</creation_ts>
          <short_desc>Playback no longer works with isolate layer</short_desc>
          <delta_ts>2018-05-04 14:01:09 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Animation</component>
          <version>4.0</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Microsoft Windows</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Bollebib">kwadraatnope</reporter>
          <assigned_to name="Dmitry Kazakov">dimula73</assigned_to>
          <cc>halla</cc>
          
          <cf_commitlink>https://commits.kde.org/krita/4a1b6717835a38a371afc799f9390e5e7e58d310</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1742234</commentid>
    <comment_count>0</comment_count>
    <who name="Bollebib">kwadraatnope</who>
    <bug_when>2018-03-31 12:25:04 +0000</bug_when>
    <thetext>I use isolate layer very often


in 3.3 i could use isolate layer and playback the contents,it would only play the isolated layer.


in current 4.0 this is broken. It ALWAYS shows the normal viex.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1743263</commentid>
    <comment_count>1</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2018-04-05 07:01:41 +0000</bug_when>
    <thetext>Hi, Bollebib!

I guess this bug was a consequence of the save/autosave bug. I cannot reproduce it anymore. If you happen to see it on the nightly builds, please reopen the bug :)

*** This bug has been marked as a duplicate of bug 392233 ***</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1745574</commentid>
    <comment_count>2</comment_count>
    <who name="Bollebib">kwadraatnope</who>
    <bug_when>2018-04-14 19:22:44 +0000</bug_when>
    <thetext>This still happens,isolate layer doesnt work well with playback,it flickers.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1745657</commentid>
    <comment_count>3</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2018-04-15 11:20:50 +0000</bug_when>
    <thetext>If it flickers, it might be that some of the cached frames still keep old contents...</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749971</commentid>
    <comment_count>4</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2018-05-04 12:17:05 +0000</bug_when>
    <thetext>Git commit 739536ba847b3b179463e1301833b763a6d0327f by Dmitry Kazakov.
Committed on 04/05/2018 at 12:16.
Pushed by dkazakov into branch &apos;master&apos;.

Fix playback in isolated mode

Since we copy the image into multiple threads while doing
animation cache generation, we should also copy the isolated
root node parameter.

M  +12   -3    libs/image/kis_image.cc

https://commits.kde.org/krita/739536ba847b3b179463e1301833b763a6d0327f</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1749998</commentid>
    <comment_count>5</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2018-05-04 14:01:09 +0000</bug_when>
    <thetext>Git commit 4a1b6717835a38a371afc799f9390e5e7e58d310 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 04/05/2018 at 12:55.
Pushed by rempt into branch &apos;krita/4.0&apos;.

Fix playback in isolated mode

Since we copy the image into multiple threads while doing
animation cache generation, we should also copy the isolated
root node parameter.
(cherry picked from commit 739536ba847b3b179463e1301833b763a6d0327f)

M  +12   -3    libs/image/kis_image.cc

https://commits.kde.org/krita/4a1b6717835a38a371afc799f9390e5e7e58d310</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>