<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>390581</bug_id>
          
          <creation_ts>2018-02-16 19:57:54 +0000</creation_ts>
          <short_desc>Toggle layer visibility clears un-do history</short_desc>
          <delta_ts>2018-04-03 11:47:08 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>krita</product>
          <component>Layer Stack</component>
          <version>git master (please specify the git hash!)</version>
          <rep_platform>Compiled Sources</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Quiralta">rjquiralte</reporter>
          <assigned_to name="Dmitry Kazakov">dimula73</assigned_to>
          <cc>halla</cc>
          
          <cf_commitlink>https://commits.kde.org/krita/8f6856236d549f50b70d337ed0aac0c00b5da194</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1731052</commentid>
    <comment_count>0</comment_count>
    <who name="Quiralta">rjquiralte</who>
    <bug_when>2018-02-16 19:57:54 +0000</bug_when>
    <thetext>I&apos;m re posting this as It seems to be different from 389876 after all, the clearing of the un-do history can create a potential accidental loss of work as reported previously here:

https://bugs.kde.org/show_bug.cgi?id=389561

to reproduce: ...A simple way to reproduce is to do 4-5 strokes, undo some of them, toggle view of the layer, the redo history will be cleared and without showing any indication of any other step (as the view toggle doesn&apos;t gets recorded).

Video showing the issue: https://drive.google.com/file/d/1gQUo8KGpVjyExLIrbJGSRmLUGWT5a9tr/view?usp=sharing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1742636</commentid>
    <comment_count>1</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2018-04-02 15:14:45 +0000</bug_when>
    <thetext>Confirm</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1742638</commentid>
    <comment_count>2</comment_count>
    <who name="Dmitry Kazakov">dimula73</who>
    <bug_when>2018-04-02 15:22:51 +0000</bug_when>
    <thetext>Git commit 515afb63df55cecc5aaa1e8f01618c306251b79f by Dmitry Kazakov.
Committed on 02/04/2018 at 15:22.
Pushed by dkazakov into branch &apos;master&apos;.

Do not reset redo history when changing layer&apos;s visibility

M  +9    -1    libs/image/commands/kis_node_property_list_command.cpp

https://commits.kde.org/krita/515afb63df55cecc5aaa1e8f01618c306251b79f</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1742851</commentid>
    <comment_count>3</comment_count>
    <who name="Halla Rempt">halla</who>
    <bug_when>2018-04-03 11:47:08 +0000</bug_when>
    <thetext>Git commit 8f6856236d549f50b70d337ed0aac0c00b5da194 by Boudewijn Rempt, on behalf of Dmitry Kazakov.
Committed on 03/04/2018 at 11:21.
Pushed by rempt into branch &apos;krita/4.0&apos;.

Do not reset redo history when changing layer&apos;s visibility
(cherry picked from commit 515afb63df55cecc5aaa1e8f01618c306251b79f)

M  +9    -1    libs/image/commands/kis_node_property_list_command.cpp

https://commits.kde.org/krita/8f6856236d549f50b70d337ed0aac0c00b5da194</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>