390349 2018-02-12 23:01:10 +0000 Move "Help" menu onto the GlobalDrawer (orsome other globally-available location) with an appropriate UI 2018-11-09 00:22:13 +0000 1 1 2 Applications Discover discover 5.12.0 Other Linux RESOLVED FIXED NOR normal --- 389717 1 nate aleixpol thomas.pfeiffer https://commits.kde.org/discover/078dd8e1096b307f44639e5c95d1dae7f1ca5039 5.15.0 0 oldest_to_newest 1729788 0 nate 2018-02-12 23:01:10 +0000 This will remove it from the Settings page's header, which will let us put the window title there and rename it to be "Sources". 1735254 1 aleixpol 2018-03-02 15:35:53 +0000 Where would you put this, in master? Would it make sense to move this menu as a context action in the featured page? 1735334 2 nate 2018-03-02 20:58:16 +0000 Honestly I'd add a real menu bar with a full "Help" menu. The issue is that this isn't really page-specific at all; it's global. No matter where we put it, if it's not globally-available, it's not really the right location. As a next-best option, we could put it on the globalDrawer, which is our only other mostly-globally-visible UI element. 1735371 3 aleixpol 2018-03-02 23:42:07 +0000 After all the work we've done to save the work the banner used, I'm not wasting 50px of vertical space only to add a menu bar with just the one menu with 2 items. They may be global, but they don't need to be accessible at all times. Remember we are talking about "About Discover" and "Report a bug". 1810025 4 thomas.pfeiffer 2018-11-08 16:31:10 +0000 Putting it in the global drawer makes perfect sense. As Nate said, it's not specific to any page, which is exactly what the global drawer is for. 1810033 5 aleixpol 2018-11-08 17:23:30 +0000 Git commit 078dd8e1096b307f44639e5c95d1dae7f1ca5039 by Aleix Pol. Committed on 08/11/2018 at 17:18. Pushed by apol into branch 'master'. Move settings contextual menu into the drawer, under "Help" M +17 -0 discover/qml/DiscoverDrawer.qml M +0 -5 discover/qml/SourcesPage.qml https://commits.kde.org/discover/078dd8e1096b307f44639e5c95d1dae7f1ca5039