<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>388465</bug_id>
          
          <creation_ts>2018-01-02 21:03:23 +0000</creation_ts>
          <short_desc>VFAT-safe file names cannot end with dot or space</short_desc>
          <delta_ts>2018-05-13 20:54:35 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>amarok</product>
          <component>Collections/Organize Files Dialog</component>
          <version>2.8.0</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>2.9</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Stefano Pettini">stefano</reporter>
          <assigned_to name="Amarok Bugs">amarok-bugs-null</assigned_to>
          <cc>ralf-engels</cc>
    
    <cc>simonandric5</cc>
          
          <cf_commitlink>https://commits.kde.org/amarok/fc9cce2bd8483a0473ea9b2514f239c07625466d</cf_commitlink>
          <cf_versionfixedin>2.9.0</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1719728</commentid>
    <comment_count>0</comment_count>
    <who name="Stefano Pettini">stefano</who>
    <bug_when>2018-01-02 21:03:23 +0000</bug_when>
    <thetext>According to Microsoft documentation, not only the following characters are not supported in VFAT &lt;&gt;:&quot;/\|?* but also filenames cannot end with space of dot.

This last part is not corrected by the &quot;VFAT-safe file name&quot; option when renaming tracks. For example, songs ending with &quot;...&quot; create a problem.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1719729</commentid>
    <comment_count>1</comment_count>
    <who name="Stefano Pettini">stefano</who>
    <bug_when>2018-01-02 21:03:48 +0000</bug_when>
    <thetext>https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733032</commentid>
    <comment_count>2</comment_count>
    <who name="Stefano Pettini">stefano</who>
    <bug_when>2018-02-22 23:46:57 +0000</bug_when>
    <thetext>Git commit fc9cce2bd8483a0473ea9b2514f239c07625466d by Stefano Pettini.
Committed on 22/02/2018 at 23:45.
Pushed by spettini into branch &apos;master&apos;.

VFAT-safe file and directory names cannot end with dot

This adds special handling of trailing dots to vfatPath(),
that are replaced with &apos;_&apos;. This doesn&apos;t affect &apos;.&apos; and &apos;..&apos;.

  ../Music/R.E.M./Monster -&gt; ../Music/R.E.M_/Monster

Unit tests updated, minor bugs when vfatPath() is invoked
with a PathSeparatorBehaviour not matching the system
detected by improving unit tests and fixed.

M  +23   -11   src/core/support/Amarok.cpp
M  +43   -11   tests/TestAmarok.cpp

https://commits.kde.org/amarok/fc9cce2bd8483a0473ea9b2514f239c07625466d</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>