386271 2017-10-27 22:27:42 +0000 [Wayland] Implement "Active window" mode in the KWin screenshot plugin 2022-04-05 21:19:33 +0000 1 1 4 Plasma kwin general git master Arch Linux Linux RESOLVED FIXED https://bugs.kde.org/show_bug.cgi?id=452309 usability, wayland-only HI wishlist --- 1 bugseforuns kwin-bugs-null alexander.reimelt andrea.ippo indecisiveautomator jm.ouwerkerk m.weghorn meven29 mspehar nate null xpamych https://invent.kde.org/graphics/spectacle/commit/9db9ace43a386e07df15a8d3fd28a343c83e6d66 Spectacle 21.12 with Plasma 5.24 0 oldest_to_newest 1708574 0 bugseforuns 2017-10-27 22:27:42 +0000 neon dev unstable Nothing happens when meta+print shortcut is pressed under Wayland. 1708582 1 nate 2017-10-28 01:12:51 +0000 Does Active Window mode also not work when invoked from the app's main window, or is this just a case of the keyboard shortcut not doing what it's supposed to? 1708583 2 bugseforuns 2017-10-28 01:29:16 +0000 Also It does not work when I open spectacle from apps menu, select "Active window" in "Area" drop down, set delay and click "take a new screenshot". Spectacle takes an empty "screenshot". 1708584 3 nate 2017-10-28 01:34:18 +0000 Thanks for the info! 1724293 4 bugseforuns 2018-01-23 13:10:38 +0000 same problem with spectacle 17.12.1 + plasma 5.12 beta on Arch Linux. 1737343 5 jm.ouwerkerk 2018-03-11 21:39:32 +0000 Note that by contrast "window under cursor" mode does work. 1743390 6 andrius 2018-04-05 19:13:52 +0000 *** Bug 392585 has been marked as a duplicate of this bug. *** 1753499 7 bugseforuns 2018-05-18 21:49:55 +0000 same bug on Arch Linux, plasma 5.13 beta, spectacle 18.04.1. 1753501 8 null 2018-05-18 21:52:14 +0000 > same bug on Arch Linux, plasma 5.13 beta, spectacle 18.04.1. This is now the third bug you added this message to. Please stop spamming Bugzilla, because as I've explained to you before, we are only interested in //new// information, e.g. new steps to reproduce, or whether the bug has been solved but is still marked as open. 1820742 9 aleixpol 2018-11-22 16:09:46 +0000 Git commit 053e903727138c30609b9cc92aeeab46101b148f by Aleix Pol. Committed on 22/11/2018 at 16:07. Pushed by apol into branch 'master'. Don't advertise on Wayland features that aren't available Summary: It's quite stressful and it clearly doesn't push developers to implement the features. Related: bug 377157 Test Plan: Now I don't choose to take a screenshot of the active window and get sad when I can't. Reviewers: #plasma, mart Reviewed By: #plasma, mart Subscribers: hein, ngraham, #spectacle Tags: #spectacle Differential Revision: https://phabricator.kde.org/D17082 M +3 -3 src/Gui/KSMainWindow.cpp M +1 -1 src/Gui/KSMainWindow.h M +13 -7 src/Gui/KSWidget.cpp M +1 -1 src/Gui/KSWidget.h M +1 -0 src/PlatformBackends/DummyImageGrabber.h M +1 -0 src/PlatformBackends/ImageGrabber.h M +1 -0 src/PlatformBackends/KWinWaylandImageGrabber.h M +1 -0 src/PlatformBackends/X11ImageGrabber.h M +1 -1 src/SpectacleConfig.cpp M +1 -1 src/SpectacleCore.cpp https://commits.kde.org/spectacle/053e903727138c30609b9cc92aeeab46101b148f 1862209 10 me 2019-06-11 23:28:35 +0000 This is a feature that has to be implemented in KWin. Once the feature is available, it's simply a matter of invoking the right DBus call into KWin. 1862278 11 vlad.zahorodnii 2019-06-12 08:53:23 +0000 Hmm, it seems like there are several ways to take a screenshot of the active window: * either by pressing Meta+PrtScr shortcut. This one seems to be straightforward to implement. Spectacle calls a method to take a screenshot and kwin spews pixel data to a pipe; * or by pressing PrtScr and then selecting "Active window" capture mode. This one is not straightforward. Spectacle would need to ensure that its window is closed before asking kwin to take a screenshot. Also, I wonder what security implications this feature will have. 1862403 12 mgraesslin 2019-06-12 19:42:29 +0000 From a security perspective the best way would be KWin to handle the shortcut and launch spectacle (or any other tool) and pipe it the screenshot. The alternative would be spectacle asking and KWin showing the same user interaction pattern to click the window or some other way to have the user confirm that it wants a screenshot to be taken. From a security perspective having a call to take screenshots is terrible. That was one of the biggest security issues on X11 (it allowed e.g. to take over a browser instance). 1997273 13 bugseforuns 2021-01-24 16:51:25 +0000 This feature is still missing from Plasma 5.21 beta. :( 2070182 14 nate 2021-10-19 13:53:37 +0000 *** Bug 443942 has been marked as a duplicate of this bug. *** 2070742 15 bugseforuns 2021-10-20 20:10:19 +0000 *** Bug 444120 has been marked as a duplicate of this bug. *** 2071532 16 bugseforuns 2021-10-23 12:20:07 +0000 *** Bug 437782 has been marked as a duplicate of this bug. *** 2071554 17 bug-janitor 2021-10-23 14:48:18 +0000 A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/82 2071556 18 bug-janitor 2021-10-23 14:48:20 +0000 A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/82 2072924 19 meven29 2021-10-28 14:55:07 +0000 In fact since we have a copy whole screen option that is slightly guarded by the key in the desktop files, KWin should allow to take ActiveWindow screenshots as well. https://invent.kde.org/graphics/spectacle/-/merge_requests/82 could be merged in the meantime. 2073180 20 bug-janitor 2021-10-29 08:56:24 +0000 A possibly relevant merge request was started @ https://invent.kde.org/plasma/kwin/-/merge_requests/1582 2073184 21 bug-janitor 2021-10-29 09:07:15 +0000 A possibly relevant merge request was started @ https://invent.kde.org/graphics/spectacle/-/merge_requests/90 2073211 22 vlad.zahorodnii 2021-10-29 12:07:04 +0000 Git commit b135a1c7b09182dd48b42cc81db6e088bb561901 by Vlad Zahorodnii. Committed on 29/10/2021 at 12:06. Pushed by vladz into branch 'master'. effects/screenshot: Add org.kde.KWin.ScreenShot2.CaptureActiveWindow M +42 -0 src/effects/screenshot/org.kde.KWin.ScreenShot2.xml M +26 -0 src/effects/screenshot/screenshotdbusinterface2.cpp M +2 -0 src/effects/screenshot/screenshotdbusinterface2.h https://invent.kde.org/plasma/kwin/commit/b135a1c7b09182dd48b42cc81db6e088bb561901 2073212 23 vlad.zahorodnii 2021-10-29 12:07:16 +0000 Git commit 9db9ace43a386e07df15a8d3fd28a343c83e6d66 by Vlad Zahorodnii. Committed on 29/10/2021 at 09:46. Pushed by vladz into branch 'master'. Add support for Active Window mode on Wayland M +27 -1 src/Platforms/PlatformKWinWayland2.cpp M +15 -0 src/Platforms/PlatformKWinWayland2.h https://invent.kde.org/graphics/spectacle/commit/9db9ace43a386e07df15a8d3fd28a343c83e6d66 2091844 24 bugseforuns 2022-01-10 20:41:28 +0000 *** Bug 448205 has been marked as a duplicate of this bug. ***