<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>385180</bug_id>
          
          <creation_ts>2017-09-28 20:12:39 +0000</creation_ts>
          <short_desc>investactivities.cpp: 8 * Redundant condition</short_desc>
          <delta_ts>2018-10-14 10:36:11 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>2</classification_id>
          <classification>Applications</classification>
          <product>kmymoney</product>
          <component>general</component>
          <version>unspecified</version>
          <rep_platform>Other</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>minor</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter>dcb314</reporter>
          <assigned_to name="KMyMoney Devel Mailing List">kmymoney-devel</assigned_to>
          
          
          <cf_commitlink>https://commits.kde.org/kmymoney/e53ee0804bc71d309e955ce39141c8adf8e22d5f</cf_commitlink>
          <cf_versionfixedin>5.0.2</cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1703470</commentid>
    <comment_count>0</comment_count>
    <who name="">dcb314</who>
    <bug_when>2017-09-28 20:12:39 +0000</bug_when>
    <thetext>[investactivities.cpp:111]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:135]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:263]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:269]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:349]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:355]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:498]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;
[investactivities.cpp:504]: (style) Redundant condition: isMultiSelection(). &apos;!A
 || (A &amp;&amp; B)&apos; is equivalent to &apos;!A || B&apos;

First one is

  if (!isMultiSelection() || (isMultiSelection() &amp;&amp; !cat-&gt;currentText().isEmpty())) {</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1794216</commentid>
    <comment_count>1</comment_count>
    <who name="Thomas Baumgart">tbaumgart</who>
    <bug_when>2018-10-14 10:33:42 +0000</bug_when>
    <thetext>Apparently, the automatic bug close did not work here. So I close it manually.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1794217</commentid>
    <comment_count>2</comment_count>
    <who name="Thomas Baumgart">tbaumgart</who>
    <bug_when>2018-10-14 10:35:50 +0000</bug_when>
    <thetext>(In reply to Thomas Baumgart from comment #1)
&gt; Apparently, the automatic bug close did not work here. So I close it
&gt; manually.

No, I just noticed, that I still need to push it. Shame on me.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1794218</commentid>
    <comment_count>3</comment_count>
    <who name="Thomas Baumgart">thb</who>
    <bug_when>2018-10-14 10:36:11 +0000</bug_when>
    <thetext>Git commit e53ee0804bc71d309e955ce39141c8adf8e22d5f by Thomas Baumgart.
Committed on 13/10/2018 at 16:34.
Pushed by tbaumgart into branch &apos;5.0&apos;.

Simplify logical expressions in source code
FIXED-IN: 5.0.2

M  +8    -8    kmymoney/dialogs/investactivities.cpp

https://commits.kde.org/kmymoney/e53ee0804bc71d309e955ce39141c8adf8e22d5f</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>