<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.kde.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.6"
          urlbase="https://bugs.kde.org/"
          
          maintainer="sysadmin@kde.org"
>

    <bug>
          <bug_id>383191</bug_id>
          
          <creation_ts>2017-08-06 09:54:03 +0000</creation_ts>
          <short_desc>Mismatch of default font settings and default kcm_fonts selection</short_desc>
          <delta_ts>2017-11-29 22:19:37 +0000</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>4</classification_id>
          <classification>Plasma</classification>
          <product>plasma-integration</product>
          <component>general</component>
          <version>master</version>
          <rep_platform>openSUSE</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>NOR</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>0</everconfirmed>
          <reporter name="Fabian Vogt">fabian</reporter>
          <assigned_to name="Martin Flöser">mgraesslin</assigned_to>
          <cc>bugseforuns</cc>
          
          <cf_commitlink>https://commits.kde.org/osx-integration/8ed5863a2664a3635381d58893704824eeac83d4</cf_commitlink>
          <cf_versionfixedin></cf_versionfixedin>
          <cf_sentryurl></cf_sentryurl>
          <votes>0</votes>

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1693085</commentid>
    <comment_count>0</comment_count>
    <who name="Fabian Vogt">fabian</who>
    <bug_when>2017-08-06 09:54:03 +0000</bug_when>
    <thetext>Found by openQA: https://openqa.opensuse.org/tests/462041#step/start_wayland_plasma5/12

The font of the polkit authentication dialog is slightly bolder before saving (without changes!) in kcm_fonts. The culprit seems to be the:

[General]
font=Noto Sans,10,-1,5,50,0,0,0,0,0,Regular

line in .config/kdeglobals. Removing &quot;Regular&quot; makes it bolder again.

AFAICS this is due to a missing default QFont::setStyleName in plasma-integration.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1693088</commentid>
    <comment_count>1</comment_count>
    <who name="Fabian Vogt">fabian</who>
    <bug_when>2017-08-06 09:57:46 +0000</bug_when>
    <thetext>(In reply to Fabian Vogt from comment #0)
&gt; AFAICS this is due to a missing default QFont::setStyleName in
&gt; plasma-integration.

I was able to confirm this and created https://phabricator.kde.org/D7160</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1694025</commentid>
    <comment_count>2</comment_count>
    <who name="Fabian Vogt">fabian</who>
    <bug_when>2017-08-11 09:14:34 +0000</bug_when>
    <thetext>Git commit 1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e by Fabian Vogt.
Committed on 11/08/2017 at 09:14.
Pushed by fvogt into branch &apos;master&apos;.

Also specify a default StyleName for fonts

Summary:
When saving, kcm_fonts adds the default selected StyleName,
so it needs to specified here as well to avoid mismatches.

Test Plan:
Ran pkcon install with no kdeglobals.
Without this change: Bold title in the auth dialog
With this change:  Normal title in the auth dialog

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7160

M  +8    -7    src/platformtheme/kfontsettingsdata.cpp
M  +1    -0    src/platformtheme/kfontsettingsdata.h

https://commits.kde.org/plasma-integration/1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1714338</commentid>
    <comment_count>3</comment_count>
    <who name="RJVB">rjvbertin</who>
    <bug_when>2017-11-29 22:19:37 +0000</bug_when>
    <thetext>Git commit 8ed5863a2664a3635381d58893704824eeac83d4 by R.J.V. Bertin.
Committed on 29/11/2017 at 21:53.
Pushed by rjvbb into branch &apos;qt590&apos;.

Also specify a default StyleName for fonts

Summary:
When saving, kcm_fonts adds the default selected StyleName,
so it needs to specified here as well to avoid mismatches.

Test Plan:
Ran pkcon install with no kdeglobals.
Without this change: Bold title in the auth dialog
With this change:  Normal title in the auth dialog

Reviewers: #plasma

Subscribers: plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D7160

Cherry-picked from plasma-integration:1b21b5977c2068c5bd30c9f9f641f60bdba9ea8e
and slightly adapted for OS X

Committed from host : Portia.local

M  +8    -7    src/platformtheme/kfontsettingsdata.cpp
M  +1    -0    src/platformtheme/kfontsettingsdata.h
M  +9    -8    src/platformtheme/kfontsettingsdatamac.mm
M  +1    -0    src/platformtheme/plintegration-cumpatch1.diff

https://commits.kde.org/osx-integration/8ed5863a2664a3635381d58893704824eeac83d4</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>